From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eERcZ-0003Me-IL for ath10k@lists.infradead.org; Tue, 14 Nov 2017 03:10:45 +0000 Subject: Re: Anyone get txbf to work on ath10k when using the linux driver? References: <5A0A21C7.20505@candelatech.com> From: Ben Greear Message-ID: <1d1fd019-cb3e-17e5-f7d5-dfe1debf95d5@candelatech.com> Date: Mon, 13 Nov 2017 19:10:07 -0800 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sebastian Gottschall , ath10k@lists.infradead.org On 11/13/2017 06:05 PM, Sebastian Gottschall wrote: > Am 13.11.2017 um 23:50 schrieb Ben Greear: >> From what I can tell, the 10.4 firmware will not even enable txbf unless the driver >> tells it too, and I don't think the driver is doing the correct call to enable this >> (it is a testing interface hack, it appears). >> >> But, maybe I am missing something? > so the firmware does not take care about the vht flags? There is a flag to enable implicit beamforming, but it is mis-defined in the driver as far as I can tell: diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index ff15c37..9522f22 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -5195,7 +5195,8 @@ enum wmi_10_4_vdev_param { #define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3) #define WMI_TXBF_STS_CAP_OFFSET_LSB 4 -#define WMI_TXBF_STS_CAP_OFFSET_MASK 0xf0 +#define WMI_TXBF_STS_CAP_OFFSET_MASK 0x70 +#define WMI_TXBF_CONF_IMPLICIT_BF BIT(7) #define WMI_BF_SOUND_DIM_OFFSET_LSB 8 #define WMI_BF_SOUND_DIM_OFFSET_MASK 0xf00 Possibly that bit is somehow set anyway, dunno. And the other explicit-beamforming appears to need a special hack to enable the feature in the firmware. But, someone using my firmware gets txbf to work, so I must be missing something. I will dig into it more tomorrow. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k