All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jef Driesen <jefdriesen@hotmail.com>,
	Nanako Shiraishi <nanako3@lavabit.com>, <git@vger.kernel.org>
Subject: [PATCH v3 4/5] stash list: use new %g formats instead of sed
Date: Fri, 16 Oct 2009 16:20:36 +0200	[thread overview]
Message-ID: <1d2a75bdb94691839f4a8ce0d1712d2bac6e405d.1255701207.git.trast@student.ethz.ch> (raw)
In-Reply-To: <cover.1255701207.git.trast@student.ethz.ch>

With the new formats, we can rewrite 'git stash list' in terms of an
appropriate pretty format, instead of hand-editing with sed.  This has
the advantage that it obeys the normal settings for git-log, notably
the pager.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 git-stash.sh |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/git-stash.sh b/git-stash.sh
index 4febbbf..f8847c1 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -205,8 +205,7 @@ have_stash () {
 
 list_stash () {
 	have_stash || return 0
-	git log --no-color --pretty=oneline -g "$@" $ref_stash -- |
-	sed -n -e 's/^[.0-9a-f]* refs\///p'
+	git log --format="%gd: %gs" -g "$@" $ref_stash --
 }
 
 show_stash () {
-- 
1.6.5.116.gfe4b9

  parent reply	other threads:[~2009-10-16 14:25 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 15:47 git stash list with more than 10 items? Jef Driesen
2009-10-12 17:52 ` Jeff King
2009-10-12 19:37   ` [PATCH] git-stash documentation: mention default options for 'list' Miklos Vajna
2009-10-12 19:39     ` Jeff King
2009-10-12 21:06   ` [RFC PATCH 0/5] Pretty formats for reflog data Thomas Rast
2009-10-12 21:06     ` [RFC PATCH 1/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-12 21:06     ` [RFC PATCH 2/5] Introduce new pretty formats %g and %G for reflog information Thomas Rast
2009-10-14  4:59       ` Jeff King
2009-10-14  9:58         ` Thomas Rast
2009-10-14  9:13       ` Junio C Hamano
2009-10-12 21:06     ` [RFC PATCH 3/5] stash: Use new %g/%G formats instead of sed Thomas Rast
2009-10-14  5:00       ` Jeff King
2009-10-12 21:06     ` [RFC PATCH 4/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-14  5:02       ` Jeff King
2009-10-12 21:06     ` [RFC PATCH 5/5] stash: change built-in ref to 'stash' instead of 'refs/stash' Thomas Rast
2009-10-14  5:06       ` Jeff King
2009-10-15 22:41         ` [PATCH v2 0/5] Pretty formats for reflog data Thomas Rast
2009-10-15 22:41           ` [PATCH v2 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-15 22:41           ` [PATCH v2 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-15 22:41           ` [PATCH v2 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-16  5:32             ` Jeff King
2009-10-16  8:50               ` Thomas Rast
2009-10-16 14:20               ` [PATCH v3 0/5] Pretty formats for reflog data Thomas Rast
2009-10-16 14:20                 ` [PATCH v3 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-17 17:05                   ` Junio C Hamano
2009-10-18 18:51                     ` Thomas Rast
2009-10-18 22:47                       ` Junio C Hamano
2009-10-19 15:48                         ` [PATCH v4 0/5] Pretty formats for reflog data Thomas Rast
2009-10-19 15:48                           ` [PATCH v4 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-19 15:48                           ` [PATCH v4 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-19 15:48                           ` [PATCH v4 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-19 15:48                           ` [PATCH v4 4/5] stash list: use new %g formats instead of sed Thomas Rast
2009-10-19 15:48                           ` [PATCH v4 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-16 14:20                 ` [PATCH v3 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-16 14:20                 ` [PATCH v3 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-17 14:48                   ` [PATCH v3.1 " Thomas Rast
2009-10-17 15:06                     ` Jakub Narebski
2009-10-18  7:18                     ` Jeff King
2009-10-18 10:34                       ` Nanako Shiraishi
2009-10-16 14:20                 ` Thomas Rast [this message]
2009-10-16 14:20                 ` [PATCH v3 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-17  0:50                 ` [PATCH v3 0/5] Pretty formats for reflog data Junio C Hamano
2009-10-17  1:18                 ` Jeff King
2009-10-15 22:41           ` [PATCH v2 4/5] stash list: use new %g formats instead of sed Thomas Rast
2009-10-15 22:41           ` [PATCH v2 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-16  5:20           ` [PATCH v2 0/5] Pretty formats for reflog data Jeff King
2009-10-16  9:00             ` Jakub Narebski
2009-10-12 21:37     ` [RFC PATCH " Jeff King
2009-10-12 21:52       ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d2a75bdb94691839f4a8ce0d1712d2bac6e405d.1255701207.git.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jefdriesen@hotmail.com \
    --cc=nanako3@lavabit.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.