From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v11 01/11] RDMA/rxe: Move mcg_lock to rxe
Date: Fri, 11 Feb 2022 13:27:37 -0600 [thread overview]
Message-ID: <1d4fc859-2f6b-eba9-01a0-a0246f0cdfc7@gmail.com> (raw)
In-Reply-To: <20220211190035.GA612278@nvidia.com>
On 2/11/22 13:00, Jason Gunthorpe wrote:
> On Tue, Feb 08, 2022 at 03:16:35PM -0600, Bob Pearson wrote:
>
>> @@ -62,7 +61,7 @@ static int rxe_mcast_get_grp(struct rxe_dev *rxe, union ib_gid *mgid,
>> if (rxe->attr.max_mcast_qp_attach == 0)
>> return -EINVAL;
>>
>> - write_lock_bh(&pool->pool_lock);
>> + spin_lock_bh(&rxe->mcg_lock);
>
>> grp = rxe_pool_get_key_locked(pool, mgid);
>
> Now this calls rxe_pool_get_key_locked() without the lock :\
>
> This is all fixed up a few patches later, so it only hurts
> bisect-ability, do you want to fix it?
>
> I looked up to 'Remove mcg from rxe pools' and it seems fine to me
> otherwise
>
> Thanks,
> Jason
It is locked. Just a different lock. All uses of the red-black tree in rxe_pool for this object pool will be using the same lock. And as you say we are heading towards replacing it all. Just leave it.
Bob
next prev parent reply other threads:[~2022-02-11 19:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 21:16 [PATCH for-next v11 00/11] Move two object pools to rxe_mcast.c Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 01/11] RDMA/rxe: Move mcg_lock to rxe Bob Pearson
2022-02-11 19:00 ` Jason Gunthorpe
2022-02-11 19:27 ` Bob Pearson [this message]
2022-02-08 21:16 ` [PATCH for-next v11 02/11] RDMA/rxe: Use kzmalloc/kfree for mca Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 03/11] RDMA/rxe: Replace grp by mcg, mce by mca Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 04/11] RDMA/rxe: Replace int num_qp by atomic_t qp_num Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 05/11] RDMA/rxe: Replace pool key by rxe->mcg_tree Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 06/11] RDMA/rxe: Remove key'ed object support Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 07/11] RDMA/rxe: Remove mcg from rxe pools Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 08/11] RDMA/rxe: Add code to cleanup mcast memory Bob Pearson
2022-02-11 18:43 ` Jason Gunthorpe
2022-02-11 19:36 ` Bob Pearson
2022-02-11 19:56 ` Jason Gunthorpe
2022-02-12 0:37 ` Bob Pearson
2022-02-14 17:41 ` Jason Gunthorpe
2022-02-08 21:16 ` [PATCH for-next v11 09/11] RDMA/rxe: Finish cleanup of rxe_mcast.c Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 10/11] RDMA/rxe: For mcast copy qp list to temp array Bob Pearson
2022-02-08 21:16 ` [PATCH for-next v11 11/11] RDMA/rxe: Convert mca read locking to RCU Bob Pearson
2022-02-11 20:09 ` Jason Gunthorpe
2022-02-11 20:04 ` [PATCH for-next v11 00/11] Move two object pools to rxe_mcast.c Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4fc859-2f6b-eba9-01a0-a0246f0cdfc7@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.