From: Marek Vasut <marex@denx.de>
To: KONRAD Frederic <frederic.konrad@adacore.com>,
Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
Deniz Eren <deniz.eren@icloud.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU
Date: Mon, 30 Oct 2017 11:51:10 +0100 [thread overview]
Message-ID: <1d51d638-6046-2f7a-890d-a9d1fd0889a7@denx.de> (raw)
In-Reply-To: <5a436a93-9538-e61b-32ef-4e92b5aad499@adacore.com>
On 10/30/2017 10:19 AM, KONRAD Frederic wrote:
[...]
>> CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.
>> hw/can/can_mioe3680_pci.c
>>
>> If you think that this is more logical even that the first
>> commits introduce something which cannot be tested/compiles
>> only into library, then I rearrange patchyes this way.
>
> I don't know all those PCI cards. But if the simple SJA1000
> doesn't exist in real life maybe better dropping it?
SJA1000 is the only sensible card to emulate IMO, at least initially,
it's the de-facto standard for CAN devices.
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-10-30 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 23:12 [Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far) pisa
2017-10-24 23:12 ` [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU pisa
2017-10-27 14:18 ` KONRAD Frederic
2017-10-29 22:43 ` Pavel Pisa
2017-10-30 9:19 ` KONRAD Frederic
2017-10-30 10:51 ` Marek Vasut [this message]
2017-10-30 11:38 ` KONRAD Frederic
2017-10-30 12:27 ` Pavel Pisa
2017-10-24 23:29 ` [Qemu-devel] [PATCH 2/6] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added pisa
2017-10-24 23:29 ` [Qemu-devel] [PATCH 3/6] CAN bus PCM-3680I PCI (dual " pisa
2017-10-24 23:29 ` [Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci pisa
2017-10-25 6:53 ` KONRAD Frederic
2017-10-25 7:40 ` Pavel Pisa
2017-10-25 7:46 ` KONRAD Frederic
2017-10-24 23:29 ` [Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci pisa
2017-10-25 7:46 ` KONRAD Frederic
2017-10-24 23:29 ` [Qemu-devel] [PATCH 6/6] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added pisa
-- strict thread matches above, loose matches on Subject: below --
2017-01-05 23:11 [Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far) pisa
2017-01-05 23:11 ` [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU pisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d51d638-6046-2f7a-890d-a9d1fd0889a7@denx.de \
--to=marex@denx.de \
--cc=deniz.eren@icloud.com \
--cc=frederic.konrad@adacore.com \
--cc=jan.kiszka@siemens.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-devel@nongnu.org \
--cc=socketcan@hartkopp.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.