From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus From: Christian Zigotzky To: Olof Johansson , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Darren Stevens , Bjorn Helgaas , linuxppc-dev References: <87tvxl15qx.fsf@concordia.ellerman.id.au> <4cfe3cc0-7fe3-9774-7d20-1b7fcb7aa910@xenosoft.de> <28b43e1a-3643-9edb-7123-be1cb0dc846a@xenosoft.de> <527175f7-8a13-37a1-9f0a-0b918aeebd64@xenosoft.de> <20171130224243.GB19640@bhelgaas-glaptop.roam.corp.google.com> <406ba7c4-7305-4069-227f-81afed202e47@xenosoft.de> <20171201232716.GA18780@bhelgaas-glaptop.roam.corp.google.com> <6d2505ab-a985-bdb0-ad3a-e7659cc2c54d@xenosoft.de> <20171202230052.34y2ivxgpgr3osct@localhost> <4CEE49CE-68F3-457F-B302-54BA8550F36A@xenosoft.de> Message-ID: <1d5276c3-1d29-114a-c868-6f022eee58e7@xenosoft.de> Date: Wed, 6 Dec 2017 09:37:39 +0100 MIME-Version: 1.0 In-Reply-To: <4CEE49CE-68F3-457F-B302-54BA8550F36A@xenosoft.de> Content-Type: multipart/mixed; boundary="------------49430AA4B75205C66C8FB399" List-ID: This is a multi-part message in MIME format. --------------49430AA4B75205C66C8FB399 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 03 December 2017 10:43AM, Christian Zigotzky wrote: > > On 3. Dec 2017, at 00:02, Olof Johansson wrote: >> >>> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson wrote: >>> >>> The below patch, together with Bjorn's, should do it. Christian, can you test >>> and report back? >>> >>> I'm guessing it won't do any harm to set this on non-X1000 platforms. My >>> test system is currently powered down so I can't check. >>> >>> >>> From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 >>> From: Olof Johansson >>> Date: Sat, 2 Dec 2017 14:56:36 -0800 >>> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS >>> >>> Needed on Amiga X1000 with SB600. >>> >>> Reported-by: Christian Zigotzky >>> Cc: Bjorn Helgaas >>> Signed-off-by: Olof Johansson >>> --- >>> arch/powerpc/platforms/pasemi/pci.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c >>> index 5ff6108..ea54ed2 100644 >>> --- a/arch/powerpc/platforms/pasemi/pci.c >>> +++ b/arch/powerpc/platforms/pasemi/pci.c >>> @@ -224,6 +224,8 @@ void __init pas_pci_init(void) >>>                return; >>>        } >>> >>> +       pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): >> >> Typo, should be ';', not ':'. I obviously didn't even try compiling this. :) >> >> >> -Olof > > Hi Olof, > > Thanks a lot for your patch! I will test it on Wednesday. > > Cheers, > Christian Hi Olof, I tested your patch today. Unfortunately the kernel 4.15-rc2 doesn't compile with your patch. Error messages:                        ^~~~~~~~~ arch/powerpc/platforms/pasemi/pci.c: In function ‘pas_pci_init’: arch/powerpc/platforms/pasemi/pci.c:298:2: error: implicit declaration of function ‘pci_set_flag’ [-Werror=implicit-function-declaration]   pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS);   ^~~~~~~~~~~~ cc1: some warnings being treated as errors --- I figured out that we need 'pci_set_flags' instead of 'pci_set_flag'. I modified your patch and after that the kernel compiles. Please find attached the new patch. Cheers, Christian --------------49430AA4B75205C66C8FB399 Content-Type: text/x-patch; name="pci.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pci.c.patch" arch/powerpc/platforms/pasemi/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 5ff6108..ea54ed2 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -224,6 +224,8 @@ void __init pas_pci_init(void) return; } + pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS); + for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) of_node_get(np); --------------49430AA4B75205C66C8FB399--