From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D33C433FE for ; Mon, 21 Nov 2022 08:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbiKUIrP (ORCPT ); Mon, 21 Nov 2022 03:47:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbiKUIrN (ORCPT ); Mon, 21 Nov 2022 03:47:13 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53B5E6D971 for ; Mon, 21 Nov 2022 00:47:11 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id r12so17813591lfp.1 for ; Mon, 21 Nov 2022 00:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kndWz83Xral0dUFOAKp2Vmc6vOTcnvs9YYJQaOTyYnk=; b=GkKeSc7TMYPu00JKJp1CrxzXew8hnss4sAxmBEZL77QYVr4TQJH3CCXlOHWB5jYFOF HzIkSXnikeqEkdZyu1D7qCsup3SRNe6xlUC1+2kRq/nX5NtysB8HHy9EhYAdS12XIGou Nnwg/xioCRfzd+sQtO0+Rmioz0ATbT1CqVn5bweUjOjxtQx/7N17UAAKTwTuK9gOfd9F qUrlYnFdVJ91dUvpwZViz+sI6kdOXXqyvbmW9KvVZeaXAoDiTBdJVI4ntStblyflwU8P +KAHYcDkP/CuCew59BihYdSHxSeWwPP9VH+LEQnl2aLMmHWfuZcba8oJp5tNYaoJn1pz BV6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kndWz83Xral0dUFOAKp2Vmc6vOTcnvs9YYJQaOTyYnk=; b=r4R3+uGd6xneITkU9u0NvihFPTepfxzF4vdu2yqKhCX7uDjwRpKCqKAoYOn7qzRS9h 0U/CRHam9BVkNIxY2rB1Of5FnCc4T2z1pE9g0+A3ucVhUDsGx6rER8/rDxs5L9fCNmtk 9atZx6h15x5tS5fjA87utCZscs+Zfcx5O/X+UUTVFePig3C3STX1V7PbEDNu3BIR2r4x YiEvefKZRFEtrb+hI2Y9QgkIIC78O6rbv5T2nZFafn8pqG26hy7LUEliJv7WK2FSy17O baL3txb2/jDKFClU/U0T3WzmGTWDvKyaZ1GAmxM7VZrKLe8StTqU3IyoP3nn5Tpa1VD+ 3nQQ== X-Gm-Message-State: ANoB5pko68Ma7BFf42ljrdLigJgT9d9ljVr7b3v1jn/OYGxJJ8ObTjdR iifiiMi/8wRuVtWQmPdQhx6eXA== X-Google-Smtp-Source: AA0mqf7ezaup3NdGbhw0Yyfz7OPrbPKKL4Om6RxHB8XBzBJN4qpHopH6igjgvEXoxu+a4RwhtFpnuA== X-Received: by 2002:ac2:508d:0:b0:4a4:72b0:9a2b with SMTP id f13-20020ac2508d000000b004a472b09a2bmr5324334lfm.469.1669020429698; Mon, 21 Nov 2022 00:47:09 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t17-20020a056512209100b0049ebc44994fsm1944613lfr.128.2022.11.21.00.47.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 00:47:09 -0800 (PST) Message-ID: <1d62f95f-0edc-afd4-abb4-37fadc0b6a47@linaro.org> Date: Mon, 21 Nov 2022 09:47:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 09/14] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Content-Language: en-US To: Hal Feng , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Michael Turquette , Philipp Zabel , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20221118010627.70576-1-hal.feng@starfivetech.com> <20221118010627.70576-10-hal.feng@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20221118010627.70576-10-hal.feng@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2022 02:06, Hal Feng wrote: > From: Emil Renner Berthing > > Add bindings for the system clock and reset generator (SYSCRG) on the > JH7110 RISC-V SoC by StarFive Ltd. > > Signed-off-by: Emil Renner Berthing > Signed-off-by: Hal Feng Binding headers are coming with the file bringing bindings for the device, so you need to squash patches. > --- > .../clock/starfive,jh7110-syscrg.yaml | 80 +++++++++++++++++++ > MAINTAINERS | 2 +- > 2 files changed, 81 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > > diff --git a/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml b/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > new file mode 100644 > index 000000000000..a8cafbc0afe2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/starfive,jh7110-syscrg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 System Clock and Reset Generator > + > +maintainers: > + - Emil Renner Berthing > + > +properties: > + compatible: > + const: starfive,jh7110-syscrg > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Main Oscillator (24 MHz) > + - description: RMII reference clock > + - description: RGMII RX clock > + - description: I2S TX bit clock > + - description: I2S TX left/right clock > + - description: I2S RX bit clock > + - description: I2S RX left/right clock > + - description: TDM > + - description: mclk > + > + clock-names: > + items: > + - const: osc > + - const: gmac1_rmii_refin > + - const: gmac1_rgmii_rxin > + - const: i2stx_bclk_ext > + - const: i2stx_lrck_ext > + - const: i2srx_bclk_ext > + - const: i2srx_lrck_ext > + - const: tdm_ext > + - const: mclk_ext > + > + '#clock-cells': > + const: 1 > + description: > + See for valid indices. Fix filename. > + > + '#reset-cells': > + const: 1 > + description: > + See for valid indices. Fix filename. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - '#clock-cells' > + - '#reset-cells' > + Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05151C433FE for ; Mon, 21 Nov 2022 08:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3XnLg9j6capeMC3tGOgruRHgMbL9fNwtdiwHl24zEsk=; b=0QKgdPpS2Kzwky rG2uIB9+yBZKJNu7u9A1A8gsXTGetPIvJOJ0kCrHfthkOIy8cdjGJyfQVx/SAwP7opRkkcDqj4MJq rR9UGpRdGw2R2kTo8KuQXqOuNnUFphDRvwh18fHGGK9KP4PdEM+KGfy7D9bq8f3PWXsmJOw/5uKPx 5RIpFiCrxOsRJIi7dlVj0sdhSS3IIJ7o4MNCjDZxxp6YggRnS++7guN0L/3HnSrm4bHMNd7Ii5rRW yGLncjE9baf0Vc03SC6BEBdrnbfsqhGGtvOx86Z5pyuxsvc55z1oRisc47bq8g809nV5yVEvUHYFX 6Rm5KRbmnRBdzb8eFuvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox2SS-00BSxi-4c; Mon, 21 Nov 2022 08:47:16 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox2SQ-00BSwP-1O for linux-riscv@lists.infradead.org; Mon, 21 Nov 2022 08:47:15 +0000 Received: by mail-lf1-x12c.google.com with SMTP id p8so17750042lfu.11 for ; Mon, 21 Nov 2022 00:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kndWz83Xral0dUFOAKp2Vmc6vOTcnvs9YYJQaOTyYnk=; b=GkKeSc7TMYPu00JKJp1CrxzXew8hnss4sAxmBEZL77QYVr4TQJH3CCXlOHWB5jYFOF HzIkSXnikeqEkdZyu1D7qCsup3SRNe6xlUC1+2kRq/nX5NtysB8HHy9EhYAdS12XIGou Nnwg/xioCRfzd+sQtO0+Rmioz0ATbT1CqVn5bweUjOjxtQx/7N17UAAKTwTuK9gOfd9F qUrlYnFdVJ91dUvpwZViz+sI6kdOXXqyvbmW9KvVZeaXAoDiTBdJVI4ntStblyflwU8P +KAHYcDkP/CuCew59BihYdSHxSeWwPP9VH+LEQnl2aLMmHWfuZcba8oJp5tNYaoJn1pz BV6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kndWz83Xral0dUFOAKp2Vmc6vOTcnvs9YYJQaOTyYnk=; b=lojOiqRUl6v4KiDZD5dpb0VDiHfoAvukVdh8piDpSTdLEN6O28sS1N6f2/2fzc8em5 aMi9OfU/3QZn2UoyNzoSZ6wJcikSgyZG8fgAxsvPIq07HU6Y8jBNgDlzoTOuVhDRe31L hWFEyKJhF/5uTeqim0XLvoOPGgC9XqJ1DIKW4H4h28+nS7l3AJ1dNlVnaeatXFNM8GaF EzpZTWHEQc0Y8p58u6JL0MppVVj4MXYnn1kIAsJ2AhIeXrCDDXHp8T1VUFsRdEpQkI7+ Z9yPTmHmPTuuTX/9r+L2pvfXMZc9fiHUHZ8o1Q432fHXIvSSdjJiyX6h6fbjXjdcUW1G UHCw== X-Gm-Message-State: ANoB5pm1pqSYUhdPPBpCx63OHyIQOK8nuU2s9kSwII6YjQ3Zc8RDUeRO HjcWvBCz501R3GewFevmdYRW0Q== X-Google-Smtp-Source: AA0mqf7ezaup3NdGbhw0Yyfz7OPrbPKKL4Om6RxHB8XBzBJN4qpHopH6igjgvEXoxu+a4RwhtFpnuA== X-Received: by 2002:ac2:508d:0:b0:4a4:72b0:9a2b with SMTP id f13-20020ac2508d000000b004a472b09a2bmr5324334lfm.469.1669020429698; Mon, 21 Nov 2022 00:47:09 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t17-20020a056512209100b0049ebc44994fsm1944613lfr.128.2022.11.21.00.47.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 00:47:09 -0800 (PST) Message-ID: <1d62f95f-0edc-afd4-abb4-37fadc0b6a47@linaro.org> Date: Mon, 21 Nov 2022 09:47:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 09/14] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Content-Language: en-US To: Hal Feng , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Michael Turquette , Philipp Zabel , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20221118010627.70576-1-hal.feng@starfivetech.com> <20221118010627.70576-10-hal.feng@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20221118010627.70576-10-hal.feng@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_004714_113747_5D290F67 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 18/11/2022 02:06, Hal Feng wrote: > From: Emil Renner Berthing > > Add bindings for the system clock and reset generator (SYSCRG) on the > JH7110 RISC-V SoC by StarFive Ltd. > > Signed-off-by: Emil Renner Berthing > Signed-off-by: Hal Feng Binding headers are coming with the file bringing bindings for the device, so you need to squash patches. > --- > .../clock/starfive,jh7110-syscrg.yaml | 80 +++++++++++++++++++ > MAINTAINERS | 2 +- > 2 files changed, 81 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > > diff --git a/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml b/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > new file mode 100644 > index 000000000000..a8cafbc0afe2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/starfive,jh7110-syscrg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 System Clock and Reset Generator > + > +maintainers: > + - Emil Renner Berthing > + > +properties: > + compatible: > + const: starfive,jh7110-syscrg > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Main Oscillator (24 MHz) > + - description: RMII reference clock > + - description: RGMII RX clock > + - description: I2S TX bit clock > + - description: I2S TX left/right clock > + - description: I2S RX bit clock > + - description: I2S RX left/right clock > + - description: TDM > + - description: mclk > + > + clock-names: > + items: > + - const: osc > + - const: gmac1_rmii_refin > + - const: gmac1_rgmii_rxin > + - const: i2stx_bclk_ext > + - const: i2stx_lrck_ext > + - const: i2srx_bclk_ext > + - const: i2srx_lrck_ext > + - const: tdm_ext > + - const: mclk_ext > + > + '#clock-cells': > + const: 1 > + description: > + See for valid indices. Fix filename. > + > + '#reset-cells': > + const: 1 > + description: > + See for valid indices. Fix filename. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - '#clock-cells' > + - '#reset-cells' > + Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv