From: Daniel Pocock <daniel@pocock.pro> To: linux-nfs@vger.kernel.org Subject: [PATCH] (revised) nfs-utils: start-statd script using incompatible file descriptor Date: Sat, 17 Dec 2016 20:12:10 +0100 [thread overview] Message-ID: <1d86b6dd-8d63-c66a-0eca-0333873dfdf0@pocock.pro> (raw) [-- Attachment #1.1: Type: text/plain, Size: 375 bytes --] The current script uses fd 200, doesn't work for every possible shell as reported[1] in Debian bug #848277 We are including a patch for it in the 1.3.4-2 package, it would be good to incorporate this patch upstream too. This patch has been revised to include a brief description and signed-off-by. Regards, Daniel 1. https://bugs.debian.org/848277 [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1.2: 29-start-statd-fd-9.patch --] [-- Type: text/x-patch; name="29-start-statd-fd-9.patch", Size: 772 bytes --] POSIX.1-2008 only specifies that file descriptor numbers from 0 to 9, inclusive, are supported. The number 200 works in the bash shell, but not in dash. This patch changes the file descriptor number from 200 to 9. Reported in Debian bug #848277 Signed-off-by: Daniel Pocock <daniel@pocock.pro> --- diff --git a/utils/statd/start-statd b/utils/statd/start-statd index 2fd6039..82715b4 100755 --- a/utils/statd/start-statd +++ b/utils/statd/start-statd @@ -7,8 +7,8 @@ PATH="/sbin:/usr/sbin:/bin:/usr/bin" # Use flock to serialize the running of this script -exec 200> /var/run/rpc.statd.lock -flock -e 200 +exec 9> /var/run/rpc.statd.lock +flock -e 9 if [ -s /var/run/rpc.statd.pid ] && [ 1`cat /var/run/rpc.statd.pid` -gt 1 ] && [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
reply other threads:[~2016-12-17 19:12 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1d86b6dd-8d63-c66a-0eca-0333873dfdf0@pocock.pro \ --to=daniel@pocock.pro \ --cc=linux-nfs@vger.kernel.org \ --subject='Re: [PATCH] (revised) nfs-utils: start-statd script using incompatible file descriptor' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.