From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19947C77B7A for ; Tue, 30 May 2023 14:54:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C275710E16A; Tue, 30 May 2023 14:54:45 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59A9110E16A for ; Tue, 30 May 2023 14:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685458483; x=1716994483; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=vx9yXn8PkbeHV6JVavlcSOdesBte/P1Ho6OJ0Ajp4rA=; b=HYTxaOD1iY/Xe9Io+vht4WwO/6Kos14puPCDE/cJaah9280lnl8OTESs fbgXUDsm263Br791f5Q3AUj+Sl2sdpDaYwj/VGNcZOkkPRGZ/Z6eqnXGq dgnHh/B/tnPQQCp7ZAA8eX6R6Wrhemb4+wdt8x8fv1GbBPKqyo8z896Gy JmoT51dh1n+mba2RlskqTKglFnz8MR18/teO5gCnPXj6Gwowxu6KlUBB8 LFV6GGFjGio59V7qmtPexujrcHXfgpzIdAC4S4vQQKpvJZ4TQRKhKSsA0 zDEfR1STsFLFuAYZ+XhoMP0Bvd67aqw4TYWb6eTTQJohPYXYlmribQfiL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="334561406" X-IronPort-AV: E=Sophos;i="6.00,204,1681196400"; d="scan'208";a="334561406" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 07:54:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="830779367" X-IronPort-AV: E=Sophos;i="6.00,204,1681196400"; d="scan'208";a="830779367" Received: from bclindho-mobl.ger.corp.intel.com (HELO [10.252.53.6]) ([10.252.53.6]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 07:54:41 -0700 Message-ID: <1d8d1f34-98b1-8a80-eafa-0610e992f514@linux.intel.com> Date: Tue, 30 May 2023 16:54:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Content-Language: en-US To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-xe@lists.freedesktop.org References: <20230526121101.1619278-1-maarten.lankhorst@linux.intel.com> <20230526121101.1619278-3-maarten.lankhorst@linux.intel.com> <0ff025da-9d8d-d7bb-80a1-f7623578e210@linux.intel.com> <678c272b-97dc-f556-4403-96c2f895fa9b@linux.intel.com> <6cd54420-f374-c796-940f-807ddadd6f43@linux.intel.com> From: Maarten Lankhorst In-Reply-To: <6cd54420-f374-c796-940f-807ddadd6f43@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Intel-xe] [PATCH 2/5] drm/xe: Add debugfs files to evict everything. X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 2023-05-30 16:41, Thomas Hellström wrote: > > On 5/29/23 15:35, Maarten Lankhorst wrote: >> Hey, >> >> On 2023-05-26 15:02, Thomas Hellström wrote: >>> On 5/26/23 14:10, Maarten Lankhorst wrote: >>>> Easy for testing, when you just want your BO evicted. >>>> >>>> Signed-off-by: Maarten Lankhorst >>> Do we have some documentation somewhere about what our debugfs entries are doing that needs updating? >> I've not seen any documentation for those specific debugfs entries. >>> Also can we evict stolen memory? >> What is useful to evict? I think all of our users of stolen memory only use it pinned. > > What I meant was, assuming that we have evictable stolen memory, can xe_bo_move() handle it properly, even when accessed as system /ggtt? If not, should we ditch the debugfs entry for stolen for now? Oops indeed. We should ditch stolen, absolutely no reason for it to be moved. Oversight, didn't realise I submtited that part too. ~Maarten