From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076BEC2B9F7 for ; Tue, 25 May 2021 02:34:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D5C76141F for ; Tue, 25 May 2021 02:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D5C76141F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llMtV-0005zT-Ms for qemu-devel@archiver.kernel.org; Mon, 24 May 2021 22:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llMNs-0006Rz-5Z for qemu-devel@nongnu.org; Mon, 24 May 2021 22:01:28 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:36805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llMNo-0000DE-3x for qemu-devel@nongnu.org; Mon, 24 May 2021 22:01:27 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 27so20183362pgy.3 for ; Mon, 24 May 2021 19:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IfqqPPROiGQRv/0IuudxbiCSd/mNyUc/5CraLBXS95k=; b=JSmiN/AD4wllsaelLNwSm+vWq4JD1TYDMzWdEm8W9aVA3uddx2xHH/W4pHVKuk8lxN PO6nTYOmZsY+8QkSsPQYeAIIj3koS3CU/Mwqxpvsrm/Jelf494fpOVziWPbdnKk5+TxD 46+QT0WOCAt6HYR0mndgWKfqTJpbckqA30dqH6ai1YUgeAHWkk3O/wlpguWhgod6coep 8lyX1p4r/h3KBy47MtgPFtSm3reHyN6w4I7ZIF7WNLa/QngJBvrhbDTR7mPjact1xta9 4jGMifT8o1hFbppquRJ8aKzwdVm8wWfSbI5CST7kPbF1vWe6yq2CZjKfnZ4H8bdW7g11 qVwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IfqqPPROiGQRv/0IuudxbiCSd/mNyUc/5CraLBXS95k=; b=b2SJO1uqwI4K4HRyqWQ5Epf0RTzSBAY6HPDJlqwa1tnT4LPifqdL75HKs/PnjsiE4H 0sqIGhjVEFSLjNj2LzveHxpbILNNTbt1a1Abe3MYIQUcy7hDB+2IiEqegk9U62UjGRBC ucydJfrlOQCOyUFcApaW2mxOpGSk9UVzuv3LB6LqDn6yC190Qt12k/ThYoOrsmHyfFi2 i9s4PKzfUj12AeYejzrOSWyasZaE+xaFaADPc7kVjGIcp7QLAHLSangSXjcBiDnse5Gi YXPf2gStCsQdoGpCVnJjJgu+VojaGdwbQZpFCkyMBNEGVhqrnetVwy7r9f2UR1qp1rCi lEVg== X-Gm-Message-State: AOAM533EQ+veNP4jXrJQ+EdircAIuIrLrFVr4ye9kKPn5Jd6955j1sTM 1/uU9UfosTNGqiuRr2OCRnc3Kw== X-Google-Smtp-Source: ABdhPJzKuJstYTDblxz+DG1IdPSxgIpWWti9Zb4PvNX2ffm32vghoVgBd4pWwvk8xLjGJdzQaAPIlQ== X-Received: by 2002:a65:464b:: with SMTP id k11mr16530678pgr.407.1621908082477; Mon, 24 May 2021 19:01:22 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id l62sm11957486pfl.88.2021.05.24.19.01.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 19:01:22 -0700 (PDT) Subject: Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr To: "Bruno Larsen (billionai)" , qemu-devel@nongnu.org References: <20210521201759.85475-1-bruno.larsen@eldorado.org.br> <20210521201759.85475-5-bruno.larsen@eldorado.org.br> From: Richard Henderson Message-ID: <1d9a521f-4f1a-e91b-fe1a-4f0e14cebd6c@linaro.org> Date: Mon, 24 May 2021 19:01:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210521201759.85475-5-bruno.larsen@eldorado.org.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br, lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote: > + uint32_t mask = 1u << bit; > + if (env->fpscr & mask) { > + ppc_store_fpscr(env, env->fpscr & ~mask); Oops, missed this during review but: fpscr & ~(target_ulong)mask; Otherwise we clear high bits of fpscr incorrectly. r~