From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64970C2BA19 for ; Tue, 14 Apr 2020 09:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48F9F206D5 for ; Tue, 14 Apr 2020 09:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437349AbgDNJCJ (ORCPT ); Tue, 14 Apr 2020 05:02:09 -0400 Received: from foss.arm.com ([217.140.110.172]:51338 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437340AbgDNJCG (ORCPT ); Tue, 14 Apr 2020 05:02:06 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D7F21FB; Tue, 14 Apr 2020 02:02:06 -0700 (PDT) Received: from [192.168.1.172] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C9703F6C4; Tue, 14 Apr 2020 02:02:05 -0700 (PDT) Subject: Re: [PATCH v2 0/6] arm64: add the time namespace support To: Andrei Vagin Cc: linux-arm-kernel@lists.infradead.org, LKML , Thomas Gleixner , Dmitry Safonov References: <20200225073731.465270-1-avagin@gmail.com> <1c1ab662-5475-9d8b-038b-8411b060202a@arm.com> From: Vincenzo Frascino Message-ID: <1d9c4c56-af16-e54f-08ca-76c6570b2d53@arm.com> Date: Tue, 14 Apr 2020 10:02:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrei, On 4/11/20 8:33 AM, Andrei Vagin wrote: > On Thu, Apr 9, 2020 at 6:23 AM Vincenzo Frascino > wrote: >> >> Hi Andrei, >> [...] >> Sorry for the delay, I completed this morning the review of your patches and I >> do not have anymore comments on them. Thank you for making the effort and >> bringing the time namespace support to arm64. > > Thank you for the review of these patches. > >> >> I have though a question on something I encountered during the testing of the >> patches: I noticed that all the tests related to CLOCK_BOOTTIME_ALARM fail on >> arm64 (please find the results below the scissors). Is this expected? > > static int alarm_clock_get_timespec(clockid_t which_clock, struct > timespec64 *tp) > { > struct alarm_base *base = &alarm_bases[clock2alarm(which_clock)]; > > if (!alarmtimer_get_rtcdev()) > return -EINVAL; > > It is probably that you get EINVAL from here ^^^. I will send a > separate patch to handle this case in tests properly. > This makes sense :) Please let me know when you post the fix so I can test it again. Are you planning as well to rebase this set? > Thanks, > Andrei > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9390C2BA19 for ; Tue, 14 Apr 2020 09:02:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D5002076A for ; Tue, 14 Apr 2020 09:02:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JPG9P7bJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D5002076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dmPAuhcY4AQ3k/NSQtIlONNUMpLHUg4EbWnuuTi96D4=; b=JPG9P7bJ+aXfy/ B2qG8PBfpXWW1API7D2mn3oiyHV1j/Vo+stATRLokBikN8/dzlp3MxO6shBZf815+fTBFHSV22JFu 2bD9UIkHiWJLG2kEF8z+TfG2j8bOXGRwmiFgvFeIfiLnKPVD+DE2J90q7Bcl8/9xp0RljPLS5cEVC sIilaWSQ6ia8j/gAK82PYHout8sLn1xrDOFe4ExPkgp1jPocFcOwwc6vpUknuwEFjr6TU80bBvLTr 5AB8fM7rb15VKYHeIM6DHiWkf4dRYchxKDryjOGhvQBv0SCNlSMVsFKvxjiufVIlBzBGZaDndHVeb ur9vEeS8OtyNN6r/tZcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOHSO-0004Bb-9h; Tue, 14 Apr 2020 09:02:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOHSL-0004Aq-CW for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 09:02:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D7F21FB; Tue, 14 Apr 2020 02:02:06 -0700 (PDT) Received: from [192.168.1.172] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C9703F6C4; Tue, 14 Apr 2020 02:02:05 -0700 (PDT) Subject: Re: [PATCH v2 0/6] arm64: add the time namespace support To: Andrei Vagin References: <20200225073731.465270-1-avagin@gmail.com> <1c1ab662-5475-9d8b-038b-8411b060202a@arm.com> From: Vincenzo Frascino Message-ID: <1d9c4c56-af16-e54f-08ca-76c6570b2d53@arm.com> Date: Tue, 14 Apr 2020 10:02:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_020209_463774_ECB1E14B X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , LKML , linux-arm-kernel@lists.infradead.org, Dmitry Safonov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrei, On 4/11/20 8:33 AM, Andrei Vagin wrote: > On Thu, Apr 9, 2020 at 6:23 AM Vincenzo Frascino > wrote: >> >> Hi Andrei, >> [...] >> Sorry for the delay, I completed this morning the review of your patches and I >> do not have anymore comments on them. Thank you for making the effort and >> bringing the time namespace support to arm64. > > Thank you for the review of these patches. > >> >> I have though a question on something I encountered during the testing of the >> patches: I noticed that all the tests related to CLOCK_BOOTTIME_ALARM fail on >> arm64 (please find the results below the scissors). Is this expected? > > static int alarm_clock_get_timespec(clockid_t which_clock, struct > timespec64 *tp) > { > struct alarm_base *base = &alarm_bases[clock2alarm(which_clock)]; > > if (!alarmtimer_get_rtcdev()) > return -EINVAL; > > It is probably that you get EINVAL from here ^^^. I will send a > separate patch to handle this case in tests properly. > This makes sense :) Please let me know when you post the fix so I can test it again. Are you planning as well to rebase this set? > Thanks, > Andrei > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel