From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B83CCA480 for ; Wed, 22 Jun 2022 11:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357908AbiFVLyC (ORCPT ); Wed, 22 Jun 2022 07:54:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357257AbiFVLxx (ORCPT ); Wed, 22 Jun 2022 07:53:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2B3C32051; Wed, 22 Jun 2022 04:53:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 737BFB81DDE; Wed, 22 Jun 2022 11:53:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 980ACC34114; Wed, 22 Jun 2022 11:53:48 +0000 (UTC) Message-ID: <1da61f9c-0605-dc9d-63a3-21c18fcb74c7@xs4all.nl> Date: Wed, 22 Jun 2022 13:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v10 0/5] media: atmel: atmel-isc: implement media controller Content-Language: en-US To: Eugen Hristev , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, claudiu.beznea@microchip.com, nicolas.ferre@microchip.com, jacopo@jmondi.org References: <20220503095127.48710-1-eugen.hristev@microchip.com> From: Hans Verkuil In-Reply-To: <20220503095127.48710-1-eugen.hristev@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eugen, On 03/05/2022 11:51, Eugen Hristev wrote: > This series is a split from the series : > [PATCH v9 00/13] media: atmel: atmel-isc: implement media controller > and it includes the media controller part. > previous fixes were sent on a different patch series. > > As discussed on the ML, moving forward with having the media link validate at > start/stop streaming call. > I will test the patch : > [RFC PATCHv2] vb2: add support for (un)prepare_streaming queue ops > afterwards, but that patch requires moving my logic to the new vb2 callbacks. I'm looking at merging this series, but I would like to have the output of 'v4l2-compliance -m /dev/mediaX' to verify that the MC links etc. is all correct. And one more question which may have been answered already in the past: Changing to the MC will break existing applications, doesn't it? Or did I miss something? Regards, Hans > > Full series history: > > Changes in v10: > -> split the series into this first fixes part. > -> moved IO_MC addition from first patch to the second patch on the driver changes > -> edited commit messages > -> DT nodes now disabled by default. > > Changes in v9: > -> kernel robot reported isc_link_validate is not static, changed to static. > > Changes in v8: > -> scaler: modified crop bounds to have the exact source size > > Changes in v7: > -> scaler: modified crop bounds to have maximum isc size > -> format propagation: did small changes as per Jacopo review > > > Changes in v6: > -> worked a bit on scaler, added try crop and other changes as per Jacopo review > -> worked on isc-base enum_fmt , reworked as per Jacopo review > > Changes in v5: > -> removed patch that removed the 'stop' variable as it was still required > -> added two new trivial patches > -> reworked some parts of the scaler and format propagation after discussions with Jacopo > > > Changes in v4: > -> as reviewed by Hans, added new patch to remove the 'stop' variable and reworked > one patch that was using it > -> as reviewed by Jacopo, reworked some parts of the media controller implementation > > > Changes in v3: > - change in bindings, small fixes in csi2dc driver and conversion to mc > for the isc-base. > - removed some MAINTAINERS patches and used patterns in MAINTAINERS > > Changes in v2: > - integrated many changes suggested by Jacopo in the review of the v1 series. > - add a few new patches > > Eugen Hristev (5): > media: atmel: atmel-isc: prepare for media controller support > media: atmel: atmel-isc: implement media controller > ARM: dts: at91: sama7g5: add nodes for video capture > ARM: configs: at91: sama7: add xisc and csi2dc > ARM: multi_v7_defconfig: add atmel video pipeline modules > > arch/arm/boot/dts/sama7g5.dtsi | 51 ++ > arch/arm/configs/multi_v7_defconfig | 3 + > arch/arm/configs/sama7_defconfig | 2 + > drivers/media/platform/atmel/Makefile | 2 +- > drivers/media/platform/atmel/atmel-isc-base.c | 485 +++++++++--------- > .../media/platform/atmel/atmel-isc-scaler.c | 267 ++++++++++ > drivers/media/platform/atmel/atmel-isc.h | 50 +- > .../media/platform/atmel/atmel-sama5d2-isc.c | 34 +- > .../media/platform/atmel/atmel-sama7g5-isc.c | 32 +- > 9 files changed, 685 insertions(+), 241 deletions(-) > create mode 100644 drivers/media/platform/atmel/atmel-isc-scaler.c > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E4EBC43334 for ; Wed, 22 Jun 2022 11:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NFeAlfM7jcNJouejOn/pBowHrkj+LOrnuAOYrZ9Hzqs=; b=YCyMfuaxXYYi+2 SKNXYI5Bg8ElUSXg1xlw71adDTcQ++JPw7nh0GunOJH/1nMkPD6srKT5qFn9Iyf94Ag9QDAugcNB4 Ltgqwai5TYzw7DI3iPN9Os5B/jy7Jntfcwb7pdxKL+LZlmDaXdHxVRmZjQmCQ5xDmCFc5Ty3Extpx sMFoZG4jwa+O5YdKH+I0NP00Miw8UbmekSwd3z297Tx3YY44PLJW/SKOsA5NgCV03AAjk5OXq0Ccx Q5ZxIXZ+VZKFQOT7n8IRvDrmyHQCNFr4+rZE0XrumM2cgr3GBIkrmhAmTUbe50+9+6dYQjrIkHm7u Ph1LcZHHVhreElO/6Dyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3yvl-00ADKN-C6; Wed, 22 Jun 2022 11:53:57 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3yvg-00ADIF-AK for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 11:53:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 556E6B81DDF; Wed, 22 Jun 2022 11:53:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 980ACC34114; Wed, 22 Jun 2022 11:53:48 +0000 (UTC) Message-ID: <1da61f9c-0605-dc9d-63a3-21c18fcb74c7@xs4all.nl> Date: Wed, 22 Jun 2022 13:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v10 0/5] media: atmel: atmel-isc: implement media controller Content-Language: en-US To: Eugen Hristev , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org References: <20220503095127.48710-1-eugen.hristev@microchip.com> From: Hans Verkuil In-Reply-To: <20220503095127.48710-1-eugen.hristev@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_045352_697453_469BB233 X-CRM114-Status: GOOD ( 27.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jacopo@jmondi.org, linux-kernel@vger.kernel.org, claudiu.beznea@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eugen, On 03/05/2022 11:51, Eugen Hristev wrote: > This series is a split from the series : > [PATCH v9 00/13] media: atmel: atmel-isc: implement media controller > and it includes the media controller part. > previous fixes were sent on a different patch series. > > As discussed on the ML, moving forward with having the media link validate at > start/stop streaming call. > I will test the patch : > [RFC PATCHv2] vb2: add support for (un)prepare_streaming queue ops > afterwards, but that patch requires moving my logic to the new vb2 callbacks. I'm looking at merging this series, but I would like to have the output of 'v4l2-compliance -m /dev/mediaX' to verify that the MC links etc. is all correct. And one more question which may have been answered already in the past: Changing to the MC will break existing applications, doesn't it? Or did I miss something? Regards, Hans > > Full series history: > > Changes in v10: > -> split the series into this first fixes part. > -> moved IO_MC addition from first patch to the second patch on the driver changes > -> edited commit messages > -> DT nodes now disabled by default. > > Changes in v9: > -> kernel robot reported isc_link_validate is not static, changed to static. > > Changes in v8: > -> scaler: modified crop bounds to have the exact source size > > Changes in v7: > -> scaler: modified crop bounds to have maximum isc size > -> format propagation: did small changes as per Jacopo review > > > Changes in v6: > -> worked a bit on scaler, added try crop and other changes as per Jacopo review > -> worked on isc-base enum_fmt , reworked as per Jacopo review > > Changes in v5: > -> removed patch that removed the 'stop' variable as it was still required > -> added two new trivial patches > -> reworked some parts of the scaler and format propagation after discussions with Jacopo > > > Changes in v4: > -> as reviewed by Hans, added new patch to remove the 'stop' variable and reworked > one patch that was using it > -> as reviewed by Jacopo, reworked some parts of the media controller implementation > > > Changes in v3: > - change in bindings, small fixes in csi2dc driver and conversion to mc > for the isc-base. > - removed some MAINTAINERS patches and used patterns in MAINTAINERS > > Changes in v2: > - integrated many changes suggested by Jacopo in the review of the v1 series. > - add a few new patches > > Eugen Hristev (5): > media: atmel: atmel-isc: prepare for media controller support > media: atmel: atmel-isc: implement media controller > ARM: dts: at91: sama7g5: add nodes for video capture > ARM: configs: at91: sama7: add xisc and csi2dc > ARM: multi_v7_defconfig: add atmel video pipeline modules > > arch/arm/boot/dts/sama7g5.dtsi | 51 ++ > arch/arm/configs/multi_v7_defconfig | 3 + > arch/arm/configs/sama7_defconfig | 2 + > drivers/media/platform/atmel/Makefile | 2 +- > drivers/media/platform/atmel/atmel-isc-base.c | 485 +++++++++--------- > .../media/platform/atmel/atmel-isc-scaler.c | 267 ++++++++++ > drivers/media/platform/atmel/atmel-isc.h | 50 +- > .../media/platform/atmel/atmel-sama5d2-isc.c | 34 +- > .../media/platform/atmel/atmel-sama7g5-isc.c | 32 +- > 9 files changed, 685 insertions(+), 241 deletions(-) > create mode 100644 drivers/media/platform/atmel/atmel-isc-scaler.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel