From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBBCC10F11 for ; Sat, 13 Apr 2019 07:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FF2320850 for ; Sat, 13 Apr 2019 07:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbfDMH6Q (ORCPT ); Sat, 13 Apr 2019 03:58:16 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:33517 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726207AbfDMH6P (ORCPT ); Sat, 13 Apr 2019 03:58:15 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5533018224D75; Sat, 13 Apr 2019 07:58:14 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: farm08_2a691f63a644d X-Filterd-Recvd-Size: 2143 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sat, 13 Apr 2019 07:58:11 +0000 (UTC) Message-ID: <1dd04eada63b51d768d568c9f09e59f6afbe963b.camel@perches.com> Subject: Re: [PATCH 0/4] ARM: imx legacy: cleanups From: Joe Perches To: Nicholas Mc Guire , Russell King Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mark Brown , Linus Walleij , Tony Lindgren , Mike Rapoport , Janusz Krzysztofik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sat, 13 Apr 2019 00:58:10 -0700 In-Reply-To: <1555139666-948-1-git-send-email-hofrat@osadl.org> References: <1555139666-948-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-04-13 at 09:14 +0200, Nicholas Mc Guire wrote: > While preparing a proposed fix for a missing check on zmalloc a few > other checkpatch warnings poped up - this little set fixes those > warnings. There is one remaining checkpatch warning but that looks > like a false-positive to me: > > ERROR: Use of __initconst requires a separate use of const > #171: FILE: arch/arm/mach-imx/mach-mx27ads.c:171: > +mx27ads_nand_board_info __initconst = { > > The false positive seems due to the definition spanning two lines > anyway looks good to me > > > static const struct mxc_nand_platform_data > mx27ads_nand_board_info __initconst = { > .width = 1, > .hw_ecc = 1, > }; Yeah, it's a false positive. You could use static const __initconst etc... if you really wanted to avoid this but feel free to ignore checkpatch anyway when it's dumb. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6440CC10F11 for ; Sat, 13 Apr 2019 07:58:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 268E8218D2 for ; Sat, 13 Apr 2019 07:58:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hnxgxmqi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 268E8218D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oQhr7up+2UudCrPDO/xqPTK8C74LeOH/3vwwliM0Cj4=; b=hnxgxmqiwWsqUk /yrzUPZJuoDmbNiFrh+kpyFQQQ93KWw1t/CECm1KUBZFCR+MRjiWWJmxWr9KbZ32TYNMlu+JwXoZo QgnaQPJAVTQMEENJly1v5wQwbRrtndfQI2JsrcBcrHNd6bb3lqxqtsZPMJW1VdsUfZgIV7LfRyrq/ mywFTd1D7u/3IsV7CPm2D+DJvktfV4LaOKufxlknjiQpTMrSMMI+aG4Nu4z8sxiYZ05TqbVU/sql4 /fgZrBCKWFHBpFtTaHvyo5EUbp+DnasGlrKbHMn7QybEm7mWbgh/jDpe+AQmQ3+Etqu16MPCmIa7c /3tlcV2gzom2WGo7lwGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFDYN-000156-LQ; Sat, 13 Apr 2019 07:58:23 +0000 Received: from smtprelay0138.hostedemail.com ([216.40.44.138] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFDYL-000145-Eh for linux-arm-kernel@lists.infradead.org; Sat, 13 Apr 2019 07:58:22 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5533018224D75; Sat, 13 Apr 2019 07:58:14 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: farm08_2a691f63a644d X-Filterd-Recvd-Size: 2143 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sat, 13 Apr 2019 07:58:11 +0000 (UTC) Message-ID: <1dd04eada63b51d768d568c9f09e59f6afbe963b.camel@perches.com> Subject: Re: [PATCH 0/4] ARM: imx legacy: cleanups From: Joe Perches To: Nicholas Mc Guire , Russell King Date: Sat, 13 Apr 2019 00:58:10 -0700 In-Reply-To: <1555139666-948-1-git-send-email-hofrat@osadl.org> References: <1555139666-948-1-git-send-email-hofrat@osadl.org> User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190413_005821_551307_376D81FE X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Rapoport , Tony Lindgren , Shawn Guo , Sascha Hauer , Janusz Krzysztofik , linux-kernel@vger.kernel.org, Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2019-04-13 at 09:14 +0200, Nicholas Mc Guire wrote: > While preparing a proposed fix for a missing check on zmalloc a few > other checkpatch warnings poped up - this little set fixes those > warnings. There is one remaining checkpatch warning but that looks > like a false-positive to me: > > ERROR: Use of __initconst requires a separate use of const > #171: FILE: arch/arm/mach-imx/mach-mx27ads.c:171: > +mx27ads_nand_board_info __initconst = { > > The false positive seems due to the definition spanning two lines > anyway looks good to me > > > static const struct mxc_nand_platform_data > mx27ads_nand_board_info __initconst = { > .width = 1, > .hw_ecc = 1, > }; Yeah, it's a false positive. You could use static const __initconst etc... if you really wanted to avoid this but feel free to ignore checkpatch anyway when it's dumb. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel