From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Firago Subject: Re: [PATCH v2 1/3] clk: vc5: Add structure to describe particular chip features Date: Wed, 5 Apr 2017 18:09:09 +0300 Message-ID: <1ddf7610-035a-eb00-caf7-90f9d25f0172@mentor.com> References: <1491392819-698-1-git-send-email-alexey_firago@mentor.com> <1491392819-698-2-git-send-email-alexey_firago@mentor.com> <23dd9324-ee97-633d-129e-6063af757f47@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <23dd9324-ee97-633d-129e-6063af757f47-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut , Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Rob Herring , linux-clk , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Marek, On 05.04.2017 17:20, Marek Vasut wrote: >>>> + >>>> +/* flags to describe chip features */ >>>> +/* chip has built-in oscilator */ >>>> +#define VC5_HAS_INTERNAL_XTAL BIT(0) >>> >>> VC5_HAS_INTERNAL_OSC? >> >> I'm fine with renaming it, but shouldn't it be consistent with the rest >> of the driver (see "internal-xtal", VC5_XTAL*, etc) and IDT datasheet? >> > > Do you have one with internal ring oscillator or with internal xtal ? > The one I had has internal xtal according to the datasheet. > The one I have (5P49V5935) has internal 25MHz crystal according to the datasheet. -- Alexey -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 1/3] clk: vc5: Add structure to describe particular chip features To: Marek Vasut , Geert Uytterhoeven References: <1491392819-698-1-git-send-email-alexey_firago@mentor.com> <1491392819-698-2-git-send-email-alexey_firago@mentor.com> <23dd9324-ee97-633d-129e-6063af757f47@gmail.com> CC: Michael Turquette , Stephen Boyd , Rob Herring , linux-clk , "devicetree@vger.kernel.org" From: Alexey Firago Message-ID: <1ddf7610-035a-eb00-caf7-90f9d25f0172@mentor.com> Date: Wed, 5 Apr 2017 18:09:09 +0300 MIME-Version: 1.0 In-Reply-To: <23dd9324-ee97-633d-129e-6063af757f47@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed List-ID: Hi Marek, On 05.04.2017 17:20, Marek Vasut wrote: >>>> + >>>> +/* flags to describe chip features */ >>>> +/* chip has built-in oscilator */ >>>> +#define VC5_HAS_INTERNAL_XTAL BIT(0) >>> >>> VC5_HAS_INTERNAL_OSC? >> >> I'm fine with renaming it, but shouldn't it be consistent with the rest >> of the driver (see "internal-xtal", VC5_XTAL*, etc) and IDT datasheet? >> > > Do you have one with internal ring oscillator or with internal xtal ? > The one I had has internal xtal according to the datasheet. > The one I have (5P49V5935) has internal 25MHz crystal according to the datasheet. -- Alexey