From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D97EB64DC for ; Wed, 21 Jun 2023 18:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbjFUSVF (ORCPT ); Wed, 21 Jun 2023 14:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbjFUSU7 (ORCPT ); Wed, 21 Jun 2023 14:20:59 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9CCB1BE6; Wed, 21 Jun 2023 11:20:43 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 43677EB7B8; Wed, 21 Jun 2023 11:20:13 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P9NW0B-v-ump; Wed, 21 Jun 2023 11:20:12 -0700 (PDT) Message-ID: <1dec928bee02d46688a7041d64f2d951a44f8a9e.camel@puri.sm> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1687371612; bh=hogFmiQ6zlNCopb6QR0O5U1FyvV79n//bSPz0BhS3Gw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SwYMtcS5iybTRzfxIDZ9jWi4hRPFHNf6znD8CCy3CRVfCL+4y9uH2hnlAnjmTUL4+ zRcjMP3B2wxWGCXyb3Cxey8sy1FcosrO3YDjYqUwSYciu/bVMJJrlwya0D5emag4Wb OyssbFhTL2dvauDZxaV1Rz3sgWcEr++ssXxDkqJgEjcb37w81FvzGgz20xXniIiLjF ATmb94h9EsSTCfm6PvNdopatMxUfWNQOtudi9EtAZLgPrTfJpLO1kHauOMEgS0hA08 V5XrxfW82+pHJGot8B9+0Pgg/Yf3SRpixq8JjS6ubbYTcCH4Xaor8X7a8lEVkDwuWV TfnWhFTM/jWBA== Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts From: Martin Kepplinger To: Ulf Hansson Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 21 Jun 2023 20:20:06 +0200 In-Reply-To: References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> <77baacb930bf2ba1a65cb1515e6795b48d2d4ed5.camel@puri.sm> <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1+deb11u2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, dem 23.09.2022 um 15:55 +0200 schrieb Ulf Hansson: > On Thu, 25 Aug 2022 at 09:06, Martin Kepplinger > wrote: > > > > Am Mittwoch, dem 24.08.2022 um 15:30 +0200 schrieb Ulf Hansson: > > > On Mon, 22 Aug 2022 at 10:38, Martin Kepplinger > > > wrote: > > > > > > > > Am Freitag, dem 19.08.2022 um 16:53 +0200 schrieb Ulf Hansson: > > > > > On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger > > > > > wrote: > > > > > > > > > > > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf > > > > > > Hansson: > > > > > > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > > > > > > wrote: > > > > > > > > > > > > > > > > If for example the power-domains' power-supply node > > > > > > > > (regulator) > > > > > > > > needs > > > > > > > > interrupts to work, the current setup with noirq > > > > > > > > callbacks > > > > > > > > cannot > > > > > > > > work; for example a pmic regulator on i2c, when > > > > > > > > suspending, > > > > > > > > usually > > > > > > > > already > > > > > > > > times out during suspend_noirq: > > > > > > > > > > > > > > > > [   41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > > > > > > > > > > > So fix system suspend and resume for these power- > > > > > > > > domains by > > > > > > > > using > > > > > > > > the > > > > > > > > "outer" suspend/resume callbacks instead. Tested on the > > > > > > > > imx8mq- > > > > > > > > librem5 board, > > > > > > > > but by looking at the dts, this will fix imx8mq-evk and > > > > > > > > possibly > > > > > > > > many other > > > > > > > > boards too. > > > > > > > > > > > > > > > > This is designed so that genpd providers just say "this > > > > > > > > genpd > > > > > > > > needs > > > > > > > > interrupts" (by setting the flag) - without implying an > > > > > > > > implementation. > > > > > > > > > > > > > > > > Initially system suspend problems had been discussed at > > > > > > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > > > > > > which led to discussing the pmic that contains the > > > > > > > > regulators > > > > > > > > which > > > > > > > > serve as power-domain power-supplies: > > > > > > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > > > > > > > > > > > Signed-off-by: Martin Kepplinger > > > > > > > > > > > > > > > > --- > > > > > > > >  drivers/base/power/domain.c | 13 +++++++++++-- > > > > > > > >  include/linux/pm_domain.h   |  5 +++++ > > > > > > > >  2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drivers/base/power/domain.c > > > > > > > > b/drivers/base/power/domain.c > > > > > > > > index 5a2e0232862e..58376752a4de 100644 > > > > > > > > --- a/drivers/base/power/domain.c > > > > > > > > +++ b/drivers/base/power/domain.c > > > > > > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > > > > > > genpd_spin_ops = { > > > > > > > >  #define genpd_is_active_wakeup(genpd)  (genpd->flags & > > > > > > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > > > > > >  #define genpd_is_cpu_domain(genpd)     (genpd->flags & > > > > > > > > GENPD_FLAG_CPU_DOMAIN) > > > > > > > >  #define genpd_is_rpm_always_on(genpd)  (genpd->flags & > > > > > > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > > > > > > +#define genpd_irq_on(genpd)            (genpd->flags & > > > > > > > > GENPD_FLAG_IRQ_ON) > > > > > > > > > > > > > > > >  static inline bool irq_safe_dev_in_sleep_domain(struct > > > > > > > > device > > > > > > > > *dev, > > > > > > > >                 const struct generic_pm_domain *genpd) > > > > > > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct > > > > > > > > generic_pm_domain > > > > > > > > *genpd, > > > > > > > >         genpd->domain.ops.runtime_suspend = > > > > > > > > genpd_runtime_suspend; > > > > > > > >         genpd->domain.ops.runtime_resume = > > > > > > > > genpd_runtime_resume; > > > > > > > >         genpd->domain.ops.prepare = genpd_prepare; > > > > > > > > -       genpd->domain.ops.suspend_noirq = > > > > > > > > genpd_suspend_noirq; > > > > > > > > -       genpd->domain.ops.resume_noirq = > > > > > > > > genpd_resume_noirq; > > > > > > > > + > > > > > > > > +       if (genpd_irq_on(genpd)) { > > > > > > > > +               genpd->domain.ops.suspend = > > > > > > > > genpd_suspend_noirq; > > > > > > > > +               genpd->domain.ops.resume = > > > > > > > > genpd_resume_noirq; > > > > > > > > +       } else { > > > > > > > > +               genpd->domain.ops.suspend_noirq = > > > > > > > > genpd_suspend_noirq; > > > > > > > > +               genpd->domain.ops.resume_noirq = > > > > > > > > genpd_resume_noirq; > > > > > > > > > > > > > > As we discussed previously, I am thinking that it may be > > > > > > > better > > > > > > > to > > > > > > > move to using genpd->domain.ops.suspend_late and > > > > > > > genpd->domain.ops.resume_early instead. > > > > > > > > > > > > Wouldn't that better be a separate patch (on top)? Do you > > > > > > really > > > > > > want > > > > > > me to change the current behaviour (default case) to from > > > > > > noirq > > > > > > to > > > > > > late? Then I'll resend this series with such a patch added. > > > > > > > > > > Sorry, I wasn't clear enough, the default behaviour should > > > > > remain > > > > > as > > > > > is. > > > > > > > > > > What I meant was, when genpd_irq_on() is true, we should use > > > > > the > > > > > genpd->domain.ops.suspend_late and genpd- > > > > > > domain.ops.resume_early. > > > > > > > > Testing that shows that this isn't working. I can provide the > > > > logs > > > > later, but suspend fails and I think it makes sense: > > > > "suspend_late" > > > > is > > > > simply already too late when i2c (or any needed driver) uses > > > > "suspend". > > > > > > Okay, I see. > > > > > > The reason why I suggested moving the callbacks to > > > "suspend_late", > > > was > > > that I was worried that some of the attached devices to genpd > > > could > > > use "suspend_late" themselves. This is the case for some drivers > > > for > > > DMA/clock/gpio/pinctrl-controllers, for example. That said, I am > > > curious to look at the DT files for the platform you are running, > > > would you mind giving me a pointer? > > > > I'm running > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > with these (small) patches on top: > > https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.19.3/librem5 > > Thanks for sharing the information! > > > > > > > > > So, this made me think about this a bit more. In the end, just > > > using > > > different levels (suspend, suspend_late, suspend_noirq) of > > > callbacks > > > are just papering over the real *dependency* problem. > > > > true, it doesn't feel like a stable solution. > > > > > > > > What we need for the genpd provider driver, is to be asked to be > > > suspended under the following conditions: > > > 1. All consumer devices (and child-domains) for its corresponding > > > PM > > > domain have been suspended. > > > 2. All its supplier devices supplies must remain resumed, until > > > the > > > genpd provider has been suspended. > > > > > > Please allow me a few more days to think in more detail about > > > this. > > > > Thanks a lot for thinking about this! > > I have made some more thinking, but it's been a busy period for me, > so > unfortunately I need some additional time (another week). It seems > like I also need to do some prototyping, to convince myself about the > approach. > > So, my apologies for the delay! > > Kind regards > Uffe Hi Ulf and all interested, Has there been any development regarding this bug? - genpd that needs interrupts for power-on/off being run in noirq phases - you remember it? it's been a while :) Anyway I still run these patches and while it's a reasonable workaround IMO, I wanted to check whether you are aware of anything that might solve this. (or maybe it *is* solved and I simply overlooked because my patches still apply?) thanks! martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63A07EB64D7 for ; Wed, 21 Jun 2023 18:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Liiky6h1y5KJ6olEgWdz4oUP3rchYtoDoVy90q2gVlM=; b=k3+76AfN/zcnna W7RD0cNycHsweXhEpCGLY5JH1qxHSiKHR2wVn/UhqqViEwnqMCu+AyzGn4j6mcavBNFXoKmsfb5g1 MEBevZTuyYvlqb7ziUccDVc8vbR6SVRte/5JAtPQXAqZTMeLG0pHgiSjBl0/nfdTF961M9Op1nW4d mTvosOa8IuXfgj1DP2A15geFSpMfNOIHVn5RTYX7QM6I/Orun71ow2vU00rpG1MEP/4qcPRdtZDz8 lNRMvgOYinF5hzX7vzQZbYsiClWNJ8ZVsoeJcvrHeisYzg7hmGSYHEUj6r0GrtZpE7WsEHCCNN67e lOzm+Hlj5qTmxtAAoy9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qC2RJ-00FN01-2C; Wed, 21 Jun 2023 18:20:21 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qC2RG-00FMzK-2B for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2023 18:20:20 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 43677EB7B8; Wed, 21 Jun 2023 11:20:13 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P9NW0B-v-ump; Wed, 21 Jun 2023 11:20:12 -0700 (PDT) Message-ID: <1dec928bee02d46688a7041d64f2d951a44f8a9e.camel@puri.sm> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1687371612; bh=hogFmiQ6zlNCopb6QR0O5U1FyvV79n//bSPz0BhS3Gw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SwYMtcS5iybTRzfxIDZ9jWi4hRPFHNf6znD8CCy3CRVfCL+4y9uH2hnlAnjmTUL4+ zRcjMP3B2wxWGCXyb3Cxey8sy1FcosrO3YDjYqUwSYciu/bVMJJrlwya0D5emag4Wb OyssbFhTL2dvauDZxaV1Rz3sgWcEr++ssXxDkqJgEjcb37w81FvzGgz20xXniIiLjF ATmb94h9EsSTCfm6PvNdopatMxUfWNQOtudi9EtAZLgPrTfJpLO1kHauOMEgS0hA08 V5XrxfW82+pHJGot8B9+0Pgg/Yf3SRpixq8JjS6ubbYTcCH4Xaor8X7a8lEVkDwuWV TfnWhFTM/jWBA== Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts From: Martin Kepplinger To: Ulf Hansson Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 21 Jun 2023 20:20:06 +0200 In-Reply-To: References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> <77baacb930bf2ba1a65cb1515e6795b48d2d4ed5.camel@puri.sm> <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> User-Agent: Evolution 3.38.3-1+deb11u2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_112018_723246_69E9A5EE X-CRM114-Status: GOOD ( 59.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gRnJlaXRhZywgZGVtIDIzLjA5LjIwMjIgdW0gMTU6NTUgKzAyMDAgc2NocmllYiBVbGYgSGFu c3NvbjoKPiBPbiBUaHUsIDI1IEF1ZyAyMDIyIGF0IDA5OjA2LCBNYXJ0aW4gS2VwcGxpbmdlcgo+ IDxtYXJ0aW4ua2VwcGxpbmdlckBwdXJpLnNtPiB3cm90ZToKPiA+IAo+ID4gQW0gTWl0dHdvY2gs IGRlbSAyNC4wOC4yMDIyIHVtIDE1OjMwICswMjAwIHNjaHJpZWIgVWxmIEhhbnNzb246Cj4gPiA+ IE9uIE1vbiwgMjIgQXVnIDIwMjIgYXQgMTA6MzgsIE1hcnRpbiBLZXBwbGluZ2VyCj4gPiA+IDxt YXJ0aW4ua2VwcGxpbmdlckBwdXJpLnNtPiB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiBBbSBGcmVp dGFnLCBkZW0gMTkuMDguMjAyMiB1bSAxNjo1MyArMDIwMCBzY2hyaWViIFVsZiBIYW5zc29uOgo+ ID4gPiA+ID4gT24gRnJpLCAxOSBBdWcgMjAyMiBhdCAxMToxNywgTWFydGluIEtlcHBsaW5nZXIK PiA+ID4gPiA+IDxtYXJ0aW4ua2VwcGxpbmdlckBwdXJpLnNtPiB3cm90ZToKPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+IEFtIERpZW5zdGFnLCBkZW0gMjYuMDcuMjAyMiB1bSAxNzowNyArMDIwMCBz Y2hyaWViIFVsZgo+ID4gPiA+ID4gPiBIYW5zc29uOgo+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgMjYg SnVsIDIwMjIgYXQgMTA6MzMsIE1hcnRpbiBLZXBwbGluZ2VyCj4gPiA+ID4gPiA+ID4gPG1hcnRp bi5rZXBwbGluZ2VyQHB1cmkuc20+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ ID4gPiBJZiBmb3IgZXhhbXBsZSB0aGUgcG93ZXItZG9tYWlucycgcG93ZXItc3VwcGx5IG5vZGUK PiA+ID4gPiA+ID4gPiA+IChyZWd1bGF0b3IpCj4gPiA+ID4gPiA+ID4gPiBuZWVkcwo+ID4gPiA+ ID4gPiA+ID4gaW50ZXJydXB0cyB0byB3b3JrLCB0aGUgY3VycmVudCBzZXR1cCB3aXRoIG5vaXJx Cj4gPiA+ID4gPiA+ID4gPiBjYWxsYmFja3MKPiA+ID4gPiA+ID4gPiA+IGNhbm5vdAo+ID4gPiA+ ID4gPiA+ID4gd29yazsgZm9yIGV4YW1wbGUgYSBwbWljIHJlZ3VsYXRvciBvbiBpMmMsIHdoZW4K PiA+ID4gPiA+ID4gPiA+IHN1c3BlbmRpbmcsCj4gPiA+ID4gPiA+ID4gPiB1c3VhbGx5Cj4gPiA+ ID4gPiA+ID4gPiBhbHJlYWR5Cj4gPiA+ID4gPiA+ID4gPiB0aW1lcyBvdXQgZHVyaW5nIHN1c3Bl bmRfbm9pcnE6Cj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IFvCoMKgIDQxLjAyNDE5 M10gYnVjazQ6IGZhaWxlZCB0byBkaXNhYmxlOiAtRVRJTUVET1VUCj4gPiA+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gPiA+IFNvIGZpeCBzeXN0ZW0gc3VzcGVuZCBhbmQgcmVzdW1lIGZvciB0aGVz ZSBwb3dlci0KPiA+ID4gPiA+ID4gPiA+IGRvbWFpbnMgYnkKPiA+ID4gPiA+ID4gPiA+IHVzaW5n Cj4gPiA+ID4gPiA+ID4gPiB0aGUKPiA+ID4gPiA+ID4gPiA+ICJvdXRlciIgc3VzcGVuZC9yZXN1 bWUgY2FsbGJhY2tzIGluc3RlYWQuIFRlc3RlZCBvbiB0aGUKPiA+ID4gPiA+ID4gPiA+IGlteDht cS0KPiA+ID4gPiA+ID4gPiA+IGxpYnJlbTUgYm9hcmQsCj4gPiA+ID4gPiA+ID4gPiBidXQgYnkg bG9va2luZyBhdCB0aGUgZHRzLCB0aGlzIHdpbGwgZml4IGlteDhtcS1ldmsgYW5kCj4gPiA+ID4g PiA+ID4gPiBwb3NzaWJseQo+ID4gPiA+ID4gPiA+ID4gbWFueSBvdGhlcgo+ID4gPiA+ID4gPiA+ ID4gYm9hcmRzIHRvby4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gVGhpcyBpcyBk ZXNpZ25lZCBzbyB0aGF0IGdlbnBkIHByb3ZpZGVycyBqdXN0IHNheSAidGhpcwo+ID4gPiA+ID4g PiA+ID4gZ2VucGQKPiA+ID4gPiA+ID4gPiA+IG5lZWRzCj4gPiA+ID4gPiA+ID4gPiBpbnRlcnJ1 cHRzIiAoYnkgc2V0dGluZyB0aGUgZmxhZykgLSB3aXRob3V0IGltcGx5aW5nIGFuCj4gPiA+ID4g PiA+ID4gPiBpbXBsZW1lbnRhdGlvbi4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4g SW5pdGlhbGx5IHN5c3RlbSBzdXNwZW5kIHByb2JsZW1zIGhhZCBiZWVuIGRpc2N1c3NlZCBhdAo+ ID4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC8y MDIxMTAwMjAwNTk1NC4xMzY3NjUzLTgtbC5zdGFjaEBwZW5ndXRyb25peC5kZS8KPiA+ID4gPiA+ ID4gPiA+IHdoaWNoIGxlZCB0byBkaXNjdXNzaW5nIHRoZSBwbWljIHRoYXQgY29udGFpbnMgdGhl Cj4gPiA+ID4gPiA+ID4gPiByZWd1bGF0b3JzCj4gPiA+ID4gPiA+ID4gPiB3aGljaAo+ID4gPiA+ ID4gPiA+ID4gc2VydmUgYXMgcG93ZXItZG9tYWluIHBvd2VyLXN1cHBsaWVzOgo+ID4gPiA+ID4g PiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtcG0vNTczMTY2Yjc1ZTUyNDUxNzc4 MjQ3MWMyYjdmOTZlMDNmZDkzZDE3NS5jYW1lbEBwdXJpLnNtL1QvCj4gPiA+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hcnRpbiBLZXBwbGluZ2VyCj4gPiA+ID4g PiA+ID4gPiA8bWFydGluLmtlcHBsaW5nZXJAcHVyaS5zbT4KPiA+ID4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiA+ID4gwqBkcml2ZXJzL2Jhc2UvcG93ZXIvZG9tYWluLmMgfCAxMyArKysrKysr KysrKy0tCj4gPiA+ID4gPiA+ID4gPiDCoGluY2x1ZGUvbGludXgvcG1fZG9tYWluLmjCoMKgIHzC oCA1ICsrKysrCj4gPiA+ID4gPiA+ID4gPiDCoDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvYmFzZS9wb3dlci9kb21haW4uYwo+ID4gPiA+ID4gPiA+ID4gYi9k cml2ZXJzL2Jhc2UvcG93ZXIvZG9tYWluLmMKPiA+ID4gPiA+ID4gPiA+IGluZGV4IDVhMmUwMjMy ODYyZS4uNTgzNzY3NTJhNGRlIDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9i YXNlL3Bvd2VyL2RvbWFpbi5jCj4gPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2Jhc2UvcG93 ZXIvZG9tYWluLmMKPiA+ID4gPiA+ID4gPiA+IEBAIC0xMzAsNiArMTMwLDcgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBnZW5wZF9sb2NrX29wcwo+ID4gPiA+ID4gPiA+ID4gZ2VucGRfc3Bpbl9vcHMg PSB7Cj4gPiA+ID4gPiA+ID4gPiDCoCNkZWZpbmUgZ2VucGRfaXNfYWN0aXZlX3dha2V1cChnZW5w ZCnCoCAoZ2VucGQtPmZsYWdzICYKPiA+ID4gPiA+ID4gPiA+IEdFTlBEX0ZMQUdfQUNUSVZFX1dB S0VVUCkKPiA+ID4gPiA+ID4gPiA+IMKgI2RlZmluZSBnZW5wZF9pc19jcHVfZG9tYWluKGdlbnBk KcKgwqDCoMKgIChnZW5wZC0+ZmxhZ3MgJgo+ID4gPiA+ID4gPiA+ID4gR0VOUERfRkxBR19DUFVf RE9NQUlOKQo+ID4gPiA+ID4gPiA+ID4gwqAjZGVmaW5lIGdlbnBkX2lzX3JwbV9hbHdheXNfb24o Z2VucGQpwqAgKGdlbnBkLT5mbGFncyAmCj4gPiA+ID4gPiA+ID4gPiBHRU5QRF9GTEFHX1JQTV9B TFdBWVNfT04pCj4gPiA+ID4gPiA+ID4gPiArI2RlZmluZSBnZW5wZF9pcnFfb24oZ2VucGQpwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAoZ2VucGQtPmZsYWdzICYKPiA+ID4gPiA+ID4gPiA+IEdFTlBE X0ZMQUdfSVJRX09OKQo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiDCoHN0YXRpYyBp bmxpbmUgYm9vbCBpcnFfc2FmZV9kZXZfaW5fc2xlZXBfZG9tYWluKHN0cnVjdAo+ID4gPiA+ID4g PiA+ID4gZGV2aWNlCj4gPiA+ID4gPiA+ID4gPiAqZGV2LAo+ID4gPiA+ID4gPiA+ID4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IHN0cnVjdCBnZW5lcmljX3BtX2RvbWFpbiAq Z2VucGQpCj4gPiA+ID4gPiA+ID4gPiBAQCAtMjA2NSw4ICsyMDY2LDE1IEBAIGludCBwbV9nZW5w ZF9pbml0KHN0cnVjdAo+ID4gPiA+ID4gPiA+ID4gZ2VuZXJpY19wbV9kb21haW4KPiA+ID4gPiA+ ID4gPiA+ICpnZW5wZCwKPiA+ID4gPiA+ID4gPiA+IMKgwqDCoMKgwqDCoMKgIGdlbnBkLT5kb21h aW4ub3BzLnJ1bnRpbWVfc3VzcGVuZCA9Cj4gPiA+ID4gPiA+ID4gPiBnZW5wZF9ydW50aW1lX3N1 c3BlbmQ7Cj4gPiA+ID4gPiA+ID4gPiDCoMKgwqDCoMKgwqDCoCBnZW5wZC0+ZG9tYWluLm9wcy5y dW50aW1lX3Jlc3VtZSA9Cj4gPiA+ID4gPiA+ID4gPiBnZW5wZF9ydW50aW1lX3Jlc3VtZTsKPiA+ ID4gPiA+ID4gPiA+IMKgwqDCoMKgwqDCoMKgIGdlbnBkLT5kb21haW4ub3BzLnByZXBhcmUgPSBn ZW5wZF9wcmVwYXJlOwo+ID4gPiA+ID4gPiA+ID4gLcKgwqDCoMKgwqDCoCBnZW5wZC0+ZG9tYWlu Lm9wcy5zdXNwZW5kX25vaXJxID0KPiA+ID4gPiA+ID4gPiA+IGdlbnBkX3N1c3BlbmRfbm9pcnE7 Cj4gPiA+ID4gPiA+ID4gPiAtwqDCoMKgwqDCoMKgIGdlbnBkLT5kb21haW4ub3BzLnJlc3VtZV9u b2lycSA9Cj4gPiA+ID4gPiA+ID4gPiBnZW5wZF9yZXN1bWVfbm9pcnE7Cj4gPiA+ID4gPiA+ID4g PiArCj4gPiA+ID4gPiA+ID4gPiArwqDCoMKgwqDCoMKgIGlmIChnZW5wZF9pcnFfb24oZ2VucGQp KSB7Cj4gPiA+ID4gPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZW5wZC0+ ZG9tYWluLm9wcy5zdXNwZW5kID0KPiA+ID4gPiA+ID4gPiA+IGdlbnBkX3N1c3BlbmRfbm9pcnE7 Cj4gPiA+ID4gPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZW5wZC0+ZG9t YWluLm9wcy5yZXN1bWUgPQo+ID4gPiA+ID4gPiA+ID4gZ2VucGRfcmVzdW1lX25vaXJxOwo+ID4g PiA+ID4gPiA+ID4gK8KgwqDCoMKgwqDCoCB9IGVsc2Ugewo+ID4gPiA+ID4gPiA+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2VucGQtPmRvbWFpbi5vcHMuc3VzcGVuZF9ub2lycSA9 Cj4gPiA+ID4gPiA+ID4gPiBnZW5wZF9zdXNwZW5kX25vaXJxOwo+ID4gPiA+ID4gPiA+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2VucGQtPmRvbWFpbi5vcHMucmVzdW1lX25vaXJx ID0KPiA+ID4gPiA+ID4gPiA+IGdlbnBkX3Jlc3VtZV9ub2lycTsKPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiBBcyB3ZSBkaXNjdXNzZWQgcHJldmlvdXNseSwgSSBhbSB0aGlua2luZyB0aGF0 IGl0IG1heSBiZQo+ID4gPiA+ID4gPiA+IGJldHRlcgo+ID4gPiA+ID4gPiA+IHRvCj4gPiA+ID4g PiA+ID4gbW92ZSB0byB1c2luZyBnZW5wZC0+ZG9tYWluLm9wcy5zdXNwZW5kX2xhdGUgYW5kCj4g PiA+ID4gPiA+ID4gZ2VucGQtPmRvbWFpbi5vcHMucmVzdW1lX2Vhcmx5IGluc3RlYWQuCj4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiBXb3VsZG4ndCB0aGF0IGJldHRlciBiZSBhIHNlcGFyYXRlIHBh dGNoIChvbiB0b3ApPyBEbyB5b3UKPiA+ID4gPiA+ID4gcmVhbGx5Cj4gPiA+ID4gPiA+IHdhbnQK PiA+ID4gPiA+ID4gbWUgdG8gY2hhbmdlIHRoZSBjdXJyZW50IGJlaGF2aW91ciAoZGVmYXVsdCBj YXNlKSB0byBmcm9tCj4gPiA+ID4gPiA+IG5vaXJxCj4gPiA+ID4gPiA+IHRvCj4gPiA+ID4gPiA+ IGxhdGU/IFRoZW4gSSdsbCByZXNlbmQgdGhpcyBzZXJpZXMgd2l0aCBzdWNoIGEgcGF0Y2ggYWRk ZWQuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNvcnJ5LCBJIHdhc24ndCBjbGVhciBlbm91Z2gsIHRo ZSBkZWZhdWx0IGJlaGF2aW91ciBzaG91bGQKPiA+ID4gPiA+IHJlbWFpbgo+ID4gPiA+ID4gYXMK PiA+ID4gPiA+IGlzLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBXaGF0IEkgbWVhbnQgd2FzLCB3aGVu IGdlbnBkX2lycV9vbigpIGlzIHRydWUsIHdlIHNob3VsZCB1c2UKPiA+ID4gPiA+IHRoZQo+ID4g PiA+ID4gZ2VucGQtPmRvbWFpbi5vcHMuc3VzcGVuZF9sYXRlIGFuZCBnZW5wZC0KPiA+ID4gPiA+ ID4gZG9tYWluLm9wcy5yZXN1bWVfZWFybHkuCj4gPiA+ID4gCj4gPiA+ID4gVGVzdGluZyB0aGF0 IHNob3dzIHRoYXQgdGhpcyBpc24ndCB3b3JraW5nLiBJIGNhbiBwcm92aWRlIHRoZQo+ID4gPiA+ IGxvZ3MKPiA+ID4gPiBsYXRlciwgYnV0IHN1c3BlbmQgZmFpbHMgYW5kIEkgdGhpbmsgaXQgbWFr ZXMgc2Vuc2U6Cj4gPiA+ID4gInN1c3BlbmRfbGF0ZSIKPiA+ID4gPiBpcwo+ID4gPiA+IHNpbXBs eSBhbHJlYWR5IHRvbyBsYXRlIHdoZW4gaTJjIChvciBhbnkgbmVlZGVkIGRyaXZlcikgdXNlcwo+ ID4gPiA+ICJzdXNwZW5kIi4KPiA+ID4gCj4gPiA+IE9rYXksIEkgc2VlLgo+ID4gPiAKPiA+ID4g VGhlIHJlYXNvbiB3aHkgSSBzdWdnZXN0ZWQgbW92aW5nIHRoZSBjYWxsYmFja3MgdG8KPiA+ID4g InN1c3BlbmRfbGF0ZSIsCj4gPiA+IHdhcwo+ID4gPiB0aGF0IEkgd2FzIHdvcnJpZWQgdGhhdCBz b21lIG9mIHRoZSBhdHRhY2hlZCBkZXZpY2VzIHRvIGdlbnBkCj4gPiA+IGNvdWxkCj4gPiA+IHVz ZSAic3VzcGVuZF9sYXRlIiB0aGVtc2VsdmVzLiBUaGlzIGlzIHRoZSBjYXNlIGZvciBzb21lIGRy aXZlcnMKPiA+ID4gZm9yCj4gPiA+IERNQS9jbG9jay9ncGlvL3BpbmN0cmwtY29udHJvbGxlcnMs IGZvciBleGFtcGxlLiBUaGF0IHNhaWQsIEkgYW0KPiA+ID4gY3VyaW91cyB0byBsb29rIGF0IHRo ZSBEVCBmaWxlcyBmb3IgdGhlIHBsYXRmb3JtIHlvdSBhcmUgcnVubmluZywKPiA+ID4gd291bGQg eW91IG1pbmQgZ2l2aW5nIG1lIGEgcG9pbnRlcj8KPiA+IAo+ID4gSSdtIHJ1bm5pbmcKPiA+IGh0 dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xp bnV4LmdpdC90cmVlL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcS1saWJyZW01 LmR0c2kKPiA+IHdpdGggdGhlc2UgKHNtYWxsKSBwYXRjaGVzIG9uIHRvcDoKPiA+IGh0dHBzOi8v c291cmNlLnB1cmkuc20vbWFydGluLmtlcHBsaW5nZXIvbGludXgtbmV4dC8tL2NvbW1pdHMvNS4x OS4zL2xpYnJlbTUKPiAKPiBUaGFua3MgZm9yIHNoYXJpbmcgdGhlIGluZm9ybWF0aW9uIQo+IAo+ ID4gCj4gPiA+IAo+ID4gPiBTbywgdGhpcyBtYWRlIG1lIHRoaW5rIGFib3V0IHRoaXMgYSBiaXQg bW9yZS4gSW4gdGhlIGVuZCwganVzdAo+ID4gPiB1c2luZwo+ID4gPiBkaWZmZXJlbnQgbGV2ZWxz IChzdXNwZW5kLCBzdXNwZW5kX2xhdGUsIHN1c3BlbmRfbm9pcnEpIG9mCj4gPiA+IGNhbGxiYWNr cwo+ID4gPiBhcmUganVzdCBwYXBlcmluZyBvdmVyIHRoZSByZWFsICpkZXBlbmRlbmN5KiBwcm9i bGVtLgo+ID4gCj4gPiB0cnVlLCBpdCBkb2Vzbid0IGZlZWwgbGlrZSBhIHN0YWJsZSBzb2x1dGlv bi4KPiA+IAo+ID4gPiAKPiA+ID4gV2hhdCB3ZSBuZWVkIGZvciB0aGUgZ2VucGQgcHJvdmlkZXIg ZHJpdmVyLCBpcyB0byBiZSBhc2tlZCB0byBiZQo+ID4gPiBzdXNwZW5kZWQgdW5kZXIgdGhlIGZv bGxvd2luZyBjb25kaXRpb25zOgo+ID4gPiAxLiBBbGwgY29uc3VtZXIgZGV2aWNlcyAoYW5kIGNo aWxkLWRvbWFpbnMpIGZvciBpdHMgY29ycmVzcG9uZGluZwo+ID4gPiBQTQo+ID4gPiBkb21haW4g aGF2ZSBiZWVuIHN1c3BlbmRlZC4KPiA+ID4gMi4gQWxsIGl0cyBzdXBwbGllciBkZXZpY2VzIHN1 cHBsaWVzIG11c3QgcmVtYWluIHJlc3VtZWQsIHVudGlsCj4gPiA+IHRoZQo+ID4gPiBnZW5wZCBw cm92aWRlciBoYXMgYmVlbiBzdXNwZW5kZWQuCj4gPiA+IAo+ID4gPiBQbGVhc2UgYWxsb3cgbWUg YSBmZXcgbW9yZSBkYXlzIHRvIHRoaW5rIGluIG1vcmUgZGV0YWlsIGFib3V0Cj4gPiA+IHRoaXMu Cj4gPiAKPiA+IFRoYW5rcyBhIGxvdCBmb3IgdGhpbmtpbmcgYWJvdXQgdGhpcyEKPiAKPiBJIGhh dmUgbWFkZSBzb21lIG1vcmUgdGhpbmtpbmcsIGJ1dCBpdCdzIGJlZW4gYSBidXN5IHBlcmlvZCBm b3IgbWUsCj4gc28KPiB1bmZvcnR1bmF0ZWx5IEkgbmVlZCBzb21lIGFkZGl0aW9uYWwgdGltZSAo YW5vdGhlciB3ZWVrKS4gSXQgc2VlbXMKPiBsaWtlIEkgYWxzbyBuZWVkIHRvIGRvIHNvbWUgcHJv dG90eXBpbmcsIHRvIGNvbnZpbmNlIG15c2VsZiBhYm91dCB0aGUKPiBhcHByb2FjaC4KPiAKPiBT bywgbXkgYXBvbG9naWVzIGZvciB0aGUgZGVsYXkhCj4gCj4gS2luZCByZWdhcmRzCj4gVWZmZQoK SGkgVWxmIGFuZCBhbGwgaW50ZXJlc3RlZCwKCkhhcyB0aGVyZSBiZWVuIGFueSBkZXZlbG9wbWVu dCByZWdhcmRpbmcgdGhpcyBidWc/IC0gZ2VucGQgdGhhdCBuZWVkcwppbnRlcnJ1cHRzIGZvciBw b3dlci1vbi9vZmYgYmVpbmcgcnVuIGluIG5vaXJxIHBoYXNlcyAtIHlvdSByZW1lbWJlcgppdD8g aXQncyBiZWVuIGEgd2hpbGUgOikKCkFueXdheSBJIHN0aWxsIHJ1biB0aGVzZSBwYXRjaGVzIGFu ZCB3aGlsZSBpdCdzIGEgcmVhc29uYWJsZSB3b3JrYXJvdW5kCklNTywgSSB3YW50ZWQgdG8gY2hl Y2sgd2hldGhlciB5b3UgYXJlIGF3YXJlIG9mIGFueXRoaW5nIHRoYXQgbWlnaHQKc29sdmUgdGhp cy4gKG9yIG1heWJlIGl0ICppcyogc29sdmVkIGFuZCBJIHNpbXBseSBvdmVybG9va2VkIGJlY2F1 c2UgbXkKcGF0Y2hlcyBzdGlsbCBhcHBseT8pCgp0aGFua3MhCgogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbWFydGluCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK