From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 1/3] x86: relax GDT check in arch_set_info_guest()
Date: Fri, 3 Jan 2020 11:24:26 +0100 [thread overview]
Message-ID: <1deeaa10-6c55-091c-316a-26549f292cae@suse.com> (raw)
In-Reply-To: <a6b26f13-d242-8d51-da89-4c565fda1e33@citrix.com>
On 27.12.2019 16:09, Andrew Cooper wrote:
> On 20/12/2019 13:49, Jan Beulich wrote:
>> It is wrong for us to check frames beyond the guest specified limit
>> (in the native case, other than in the compat one).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Just like the restriction on sharing L2's, no guest is ever going to be
> able to not zero all of this to operate on older hypervisors.
>
> I agree that it is not ideal that this got into the ABI to begin with,
> but as I said before, all you are doing is complicating
> arch_set_info_guest() for a relaxation which no guest can use.
As asked before - would you mind clarifying where I'm complicating
things? I think I'm rather simplifying matters, by
- pulling out a calculation, storing the result into a now common
(between native and compat cases) local variable,
- as a result making native and compat cases behave consistently,
eliminating the need for reader to (try to) figure out why there
is a difference in behavior.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-03 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 13:48 [Xen-devel] [PATCH v2 0/3] x86: XSA-298 follow-up Jan Beulich
2019-12-20 13:49 ` [Xen-devel] [PATCH v2 1/3] x86: relax GDT check in arch_set_info_guest() Jan Beulich
2019-12-27 15:09 ` Andrew Cooper
2020-01-03 10:24 ` Jan Beulich [this message]
2020-05-19 8:42 ` Roger Pau Monné
2020-05-19 9:36 ` Jan Beulich
2019-12-20 13:50 ` [Xen-devel] [PATCH v2 2/3] x86: relax LDT " Jan Beulich
2019-12-27 15:26 ` Andrew Cooper
2020-01-03 10:31 ` Jan Beulich
2020-05-19 9:02 ` Roger Pau Monné
2020-05-19 9:12 ` Jan Beulich
2020-05-19 9:18 ` Roger Pau Monné
2019-12-20 13:50 ` [Xen-devel] [PATCH v2 3/3] x86/PV: polish pv_set_gdt() Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1deeaa10-6c55-091c-316a-26549f292cae@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.