From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema
Date: Fri, 30 Sep 2022 22:19:05 +0200 [thread overview]
Message-ID: <1dfd2858-cc30-5cc0-0b2a-209a8bf8bace@linaro.org> (raw)
In-Reply-To: <2b1a536f-fd84-831a-8b0a-9c0cce5e6421@somainline.org>
On 30/09/2022 22:13, Konrad Dybcio wrote:
>
>
> On 30.09.2022 22:05, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> The sdm854.dtsi file defined several pin configuration nodes which are
> 845
>
>> customized by the boards. Therefore keep a additional "default-pins"
>> node inside so the boards can add more of configuration nodes. Such
>> additional configuration nodes always need 'function' property now
>> (required by DT schema).
> Would it not make more sense to drop this and keep the properties in the
> root node while at it?
>
> Konrad
Not possible, because the boards set different bias/config for the pins:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi?h=v6.0-rc7#n2988
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-mtp.dts?h=v6.0-rc7#n729
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-30 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 20:05 [PATCH 0/2] pinctrl/arm64: qcom: convert sdm845 bindings to DT schema Krzysztof Kozlowski
2022-09-30 20:05 ` [PATCH 1/2] arm64: dts: qcom: sdm845: align TLMM pin configuration with " Krzysztof Kozlowski
2022-09-30 20:13 ` Konrad Dybcio
2022-09-30 20:19 ` Krzysztof Kozlowski [this message]
2022-09-30 20:19 ` Konrad Dybcio
2022-10-03 16:14 ` Doug Anderson
2022-10-03 17:45 ` Krzysztof Kozlowski
2022-10-03 22:59 ` Doug Anderson
2022-10-04 8:40 ` Krzysztof Kozlowski
2022-10-04 14:55 ` Doug Anderson
2022-10-05 8:18 ` Krzysztof Kozlowski
2022-09-30 20:05 ` [PATCH 2/2] dt-bindings: pinctrl: qcom,sdm845: convert to dtschema Krzysztof Kozlowski
2022-09-30 22:05 ` Rob Herring
2022-10-01 9:08 ` Krzysztof Kozlowski
2022-10-03 17:10 ` Rob Herring
2022-10-03 17:11 ` Rob Herring
2022-10-17 22:42 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfd2858-cc30-5cc0-0b2a-209a8bf8bace@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.