From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C50CC0650F for ; Mon, 5 Aug 2019 13:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E0782067D for ; Mon, 5 Aug 2019 13:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730205AbfHENOS (ORCPT ); Mon, 5 Aug 2019 09:14:18 -0400 Received: from foss.arm.com ([217.140.110.172]:48486 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729469AbfHENON (ORCPT ); Mon, 5 Aug 2019 09:14:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B021D337; Mon, 5 Aug 2019 06:14:11 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA2003F706; Mon, 5 Aug 2019 06:14:09 -0700 (PDT) Subject: Re: [PATCH 3/9] KVM: arm64: Implement PV_FEATURES call To: Marc Zyngier Cc: kvm@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Catalin Marinas , Suzuki K Pouloze , linux-doc@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry References: <20190802145017.42543-1-steven.price@arm.com> <20190802145017.42543-4-steven.price@arm.com> <20190803122124.7700f700@why> From: Steven Price Message-ID: <1e0a03b4-1fb6-cbe2-fb7a-8ed39341a187@arm.com> Date: Mon, 5 Aug 2019 14:14:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190803122124.7700f700@why> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2019 12:21, Marc Zyngier wrote: > On Fri, 2 Aug 2019 15:50:11 +0100 > Steven Price wrote: > >> This provides a mechanism for querying which paravirtualized features >> are available in this hypervisor. >> >> Also add the header file which defines the ABI for the paravirtualized >> clock features we're about to add. >> >> Signed-off-by: Steven Price >> --- >> arch/arm64/include/asm/pvclock-abi.h | 20 ++++++++++++++++++++ >> include/linux/arm-smccc.h | 14 ++++++++++++++ >> virt/kvm/arm/hypercalls.c | 9 +++++++++ >> 3 files changed, 43 insertions(+) >> create mode 100644 arch/arm64/include/asm/pvclock-abi.h >> >> diff --git a/arch/arm64/include/asm/pvclock-abi.h b/arch/arm64/include/asm/pvclock-abi.h >> new file mode 100644 >> index 000000000000..1f7cdc102691 >> --- /dev/null >> +++ b/arch/arm64/include/asm/pvclock-abi.h >> @@ -0,0 +1,20 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* Copyright (C) 2019 Arm Ltd. */ >> + >> +#ifndef __ASM_PVCLOCK_ABI_H >> +#define __ASM_PVCLOCK_ABI_H >> + >> +/* The below structures and constants are defined in ARM DEN0057A */ >> + >> +struct pvclock_vcpu_stolen_time_info { >> + __le32 revision; >> + __le32 attributes; >> + __le64 stolen_time; >> + /* Structure must be 64 byte aligned, pad to that size */ >> + u8 padding[48]; >> +} __packed; >> + >> +#define PV_VM_TIME_NOT_SUPPORTED -1 > > Isn't the intent for this to be the same value as > SMCCC_RET_NOT_SUPPORTED? Yes it is, I guess there's not much point defining it again. >> +#define PV_VM_TIME_INVALID_PARAMETERS -2 > > It overlaps with SMCCC_RET_NOT_REQUIRED. Is that a problem? Should we > consider a spec change for this? Actually INVALID_PARAMETERS is only for Live Physical Time, since we're not implementing it here, this can go as well. Thanks, Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC6A3C0650F for ; Mon, 5 Aug 2019 13:14:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 81FD02173B for ; Mon, 5 Aug 2019 13:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81FD02173B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0260E4A4FB; Mon, 5 Aug 2019 09:14:16 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dBLS0Ji1-Eqt; Mon, 5 Aug 2019 09:14:14 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D15444A51F; Mon, 5 Aug 2019 09:14:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9C4974A4FB for ; Mon, 5 Aug 2019 09:14:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VXEOgBD+z6d8 for ; Mon, 5 Aug 2019 09:14:12 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A8584A4BE for ; Mon, 5 Aug 2019 09:14:12 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B021D337; Mon, 5 Aug 2019 06:14:11 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA2003F706; Mon, 5 Aug 2019 06:14:09 -0700 (PDT) Subject: Re: [PATCH 3/9] KVM: arm64: Implement PV_FEATURES call To: Marc Zyngier References: <20190802145017.42543-1-steven.price@arm.com> <20190802145017.42543-4-steven.price@arm.com> <20190803122124.7700f700@why> From: Steven Price Message-ID: <1e0a03b4-1fb6-cbe2-fb7a-8ed39341a187@arm.com> Date: Mon, 5 Aug 2019 14:14:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190803122124.7700f700@why> Content-Language: en-GB Cc: kvm@vger.kernel.org, Catalin Marinas , linux-doc@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Paolo Bonzini , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 03/08/2019 12:21, Marc Zyngier wrote: > On Fri, 2 Aug 2019 15:50:11 +0100 > Steven Price wrote: > >> This provides a mechanism for querying which paravirtualized features >> are available in this hypervisor. >> >> Also add the header file which defines the ABI for the paravirtualized >> clock features we're about to add. >> >> Signed-off-by: Steven Price >> --- >> arch/arm64/include/asm/pvclock-abi.h | 20 ++++++++++++++++++++ >> include/linux/arm-smccc.h | 14 ++++++++++++++ >> virt/kvm/arm/hypercalls.c | 9 +++++++++ >> 3 files changed, 43 insertions(+) >> create mode 100644 arch/arm64/include/asm/pvclock-abi.h >> >> diff --git a/arch/arm64/include/asm/pvclock-abi.h b/arch/arm64/include/asm/pvclock-abi.h >> new file mode 100644 >> index 000000000000..1f7cdc102691 >> --- /dev/null >> +++ b/arch/arm64/include/asm/pvclock-abi.h >> @@ -0,0 +1,20 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* Copyright (C) 2019 Arm Ltd. */ >> + >> +#ifndef __ASM_PVCLOCK_ABI_H >> +#define __ASM_PVCLOCK_ABI_H >> + >> +/* The below structures and constants are defined in ARM DEN0057A */ >> + >> +struct pvclock_vcpu_stolen_time_info { >> + __le32 revision; >> + __le32 attributes; >> + __le64 stolen_time; >> + /* Structure must be 64 byte aligned, pad to that size */ >> + u8 padding[48]; >> +} __packed; >> + >> +#define PV_VM_TIME_NOT_SUPPORTED -1 > > Isn't the intent for this to be the same value as > SMCCC_RET_NOT_SUPPORTED? Yes it is, I guess there's not much point defining it again. >> +#define PV_VM_TIME_INVALID_PARAMETERS -2 > > It overlaps with SMCCC_RET_NOT_REQUIRED. Is that a problem? Should we > consider a spec change for this? Actually INVALID_PARAMETERS is only for Live Physical Time, since we're not implementing it here, this can go as well. Thanks, Steve _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886D1C433FF for ; Mon, 5 Aug 2019 13:14:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E2AE2067D for ; Mon, 5 Aug 2019 13:14:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gm1R7GBG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E2AE2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FWAuVoxbLzswniB+Yx/m3MilxPaszQTuB/qFumyfb6Q=; b=gm1R7GBGInilLM ExWnEWRRbDZGnS5LLrKOJbIT8ps+okqIXr9fw2vo1LvedIZRmdyeJBICOV49ZQSogXfYgq0jJKgxp ipOkxa85pbEpH+77kTbn8ydike1voZlR1UHZLBBpnfb0BRkWCNYRCQYYafT3PHKPs3k8PNBMHCa7o 62oB/2Fa5hAiiq/CTI5c+t1wd3L7dRF9cEUSzcaG4hIhSH7/J9e1kCG7ZKggXs72eI6uODPHP71RP oFbK9IYrh1bjRRVuiGnEO7H5vpnJDPsT7aJh/BMuPNL1hSrFcZUhBsQGX3pHOjMCJebXqyH3BT906 h8LYFsIvPoGLNLUVzrRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hucoZ-0005x7-Bd; Mon, 05 Aug 2019 13:14:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hucoW-0005wm-4G for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 13:14:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B021D337; Mon, 5 Aug 2019 06:14:11 -0700 (PDT) Received: from [10.1.196.133] (e112269-lin.cambridge.arm.com [10.1.196.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA2003F706; Mon, 5 Aug 2019 06:14:09 -0700 (PDT) Subject: Re: [PATCH 3/9] KVM: arm64: Implement PV_FEATURES call To: Marc Zyngier References: <20190802145017.42543-1-steven.price@arm.com> <20190802145017.42543-4-steven.price@arm.com> <20190803122124.7700f700@why> From: Steven Price Message-ID: <1e0a03b4-1fb6-cbe2-fb7a-8ed39341a187@arm.com> Date: Mon, 5 Aug 2019 14:14:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190803122124.7700f700@why> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_061412_216327_0DD59695 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org, Suzuki K Pouloze , Catalin Marinas , linux-doc@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, James Morse , Julien Thierry , Paolo Bonzini , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/08/2019 12:21, Marc Zyngier wrote: > On Fri, 2 Aug 2019 15:50:11 +0100 > Steven Price wrote: > >> This provides a mechanism for querying which paravirtualized features >> are available in this hypervisor. >> >> Also add the header file which defines the ABI for the paravirtualized >> clock features we're about to add. >> >> Signed-off-by: Steven Price >> --- >> arch/arm64/include/asm/pvclock-abi.h | 20 ++++++++++++++++++++ >> include/linux/arm-smccc.h | 14 ++++++++++++++ >> virt/kvm/arm/hypercalls.c | 9 +++++++++ >> 3 files changed, 43 insertions(+) >> create mode 100644 arch/arm64/include/asm/pvclock-abi.h >> >> diff --git a/arch/arm64/include/asm/pvclock-abi.h b/arch/arm64/include/asm/pvclock-abi.h >> new file mode 100644 >> index 000000000000..1f7cdc102691 >> --- /dev/null >> +++ b/arch/arm64/include/asm/pvclock-abi.h >> @@ -0,0 +1,20 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* Copyright (C) 2019 Arm Ltd. */ >> + >> +#ifndef __ASM_PVCLOCK_ABI_H >> +#define __ASM_PVCLOCK_ABI_H >> + >> +/* The below structures and constants are defined in ARM DEN0057A */ >> + >> +struct pvclock_vcpu_stolen_time_info { >> + __le32 revision; >> + __le32 attributes; >> + __le64 stolen_time; >> + /* Structure must be 64 byte aligned, pad to that size */ >> + u8 padding[48]; >> +} __packed; >> + >> +#define PV_VM_TIME_NOT_SUPPORTED -1 > > Isn't the intent for this to be the same value as > SMCCC_RET_NOT_SUPPORTED? Yes it is, I guess there's not much point defining it again. >> +#define PV_VM_TIME_INVALID_PARAMETERS -2 > > It overlaps with SMCCC_RET_NOT_REQUIRED. Is that a problem? Should we > consider a spec change for this? Actually INVALID_PARAMETERS is only for Live Physical Time, since we're not implementing it here, this can go as well. Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel