From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C00C433EF for ; Mon, 4 Oct 2021 01:07:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98F3760FC4 for ; Mon, 4 Oct 2021 01:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbhJDBJM (ORCPT ); Sun, 3 Oct 2021 21:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhJDBJL (ORCPT ); Sun, 3 Oct 2021 21:09:11 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B24C0613EC for ; Sun, 3 Oct 2021 18:07:22 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id y5so10005527pll.3 for ; Sun, 03 Oct 2021 18:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=pStQdMrL6ZFdXlJGha4PGljRtDULz8i5+uPOyRWf8rU=; b=kAMJB1dPHfIu0grrWDbrhbolngM0JPtqVX6W4LQ0dtNlTNzO4A4V4jJfu3GO//KpI/ zoCckKf+f5s6de3QFu2N7/YZY8bZhxxvwZ/cVyDsFquSDFcoOsCt9tkpgk8jwGmfEcWR OKK/uu0L1RIcNvw+Ro/RFp06yHEtZkrhJNa8FM/BDB59V45gHSKiejNo357eRnDtDSy/ b76AdDM/tjRm2HBiefXqqGCizbuXhYPpOwxVNjkVSaN+zzokQ1GhYkxAEiqJ/E/NxsxO cqUaV5bA/NdeHMtleODM3D57VAurRyugnfdK9q0qM1J2IakdMLzcGTbSIMufvfOtYCZ7 ycdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=pStQdMrL6ZFdXlJGha4PGljRtDULz8i5+uPOyRWf8rU=; b=40xX8BXhlvck83Bhui72R/92xyQ9aefxlP+lJrTetZ3FuyJZCmBIjEhciZPwXIqfat oFVCJmMHtAD4w9P0gdh9KfthaLR1W8gqxASjSNdFMjpZT34tib/ye/uaUGFGo/9ZXI4A hy9+y87CjCtK+WzmwLQlV9Y455CHyRHSo/VBondhGkWljgteKmEfdpo4MfanqbnoSrCT fMtvx21VjduKbYA7qFjn0SkLustLL3BgoepwUFMzPUqWP2ZQ1asDDo2SQ0qTJuKznvcv JtIFSPfAiEOoPXR+Zb5TCSrzXP5xXLZZfRsHfns4Z2kq5vontaK3/kSJhM/4ZXaJodH2 OAqA== X-Gm-Message-State: AOAM532xA7TA9s1EiUAj8bUxmr3JyHuihAg5loAOVxc3rnUDd0kRRnGu jvQBNocXclDGbpNhXMJIPo8CRQ== X-Google-Smtp-Source: ABdhPJw+OUZxiTir+uXz7ip5A94n6l2wmdN8lZupAMuxEoGz73pp9OWHAtT4OzzvlWLfGbA3B+EWQQ== X-Received: by 2002:a17:902:7e48:b0:13d:a58a:e9ce with SMTP id a8-20020a1709027e4800b0013da58ae9cemr20330094pln.21.1633309642214; Sun, 03 Oct 2021 18:07:22 -0700 (PDT) Received: from [2620:15c:17:3:4faa:17e6:3602:9e7d] ([2620:15c:17:3:4faa:17e6:3602:9e7d]) by smtp.gmail.com with ESMTPSA id p24sm2314787pjz.32.2021.10.03.18.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 18:07:21 -0700 (PDT) Date: Sun, 3 Oct 2021 18:07:20 -0700 (PDT) From: David Rientjes To: Rustam Kovhaev cc: Vlastimil Babka , Dave Chinner , djwong@kernel.org, linux-xfs@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, Al Viro , dvyukov@google.com Subject: Re: [PATCH] xfs: use kmem_cache_free() for kmem_cache objects In-Reply-To: Message-ID: <1e0df91-556e-cee5-76f7-285d28fe31@google.com> References: <20210929212347.1139666-1-rkovhaev@gmail.com> <20210930044202.GP2361455@dread.disaster.area> <17f537b3-e2eb-5d0a-1465-20f3d3c960e2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Sep 2021, Rustam Kovhaev wrote: > > >> I think it's fair if something like XFS (not meant for tiny systems AFAIK?) > > >> excludes SLOB (meant for tiny systems). Clearly nobody tried to use these > > >> two together last 5 years anyway. > > > > > > +1 for adding Kconfig option, it seems like some things are not meant to > > > be together. > > > > But if we patch SLOB, we won't need it. > > OK, so we consider XFS on SLOB a supported configuration that might be > used and should be tested. > I'll look into maybe adding a config with CONFIG_SLOB and CONFIG_XFS_FS > to syzbot. > > It seems that we need to patch SLOB anyway, because any other code can > hit the very same issue. > It's probably best to introduce both (SLOB fix and Kconfig change for XFS), at least in the interim because the combo of XFS and SLOB could be broken in other ways. If syzbot doesn't complain with a patched kernel to allow SLOB to be used with XFS, then we could potentially allow them to be used together. (I'm not sure that this freeing issue is the *only* thing that is broken, nor that we have sufficient information to make that determination right now..) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7B1C433EF for ; Mon, 4 Oct 2021 01:07:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39A5860FC4 for ; Mon, 4 Oct 2021 01:07:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39A5860FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4A6AB6B006C; Sun, 3 Oct 2021 21:07:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 455216B0071; Sun, 3 Oct 2021 21:07:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 343AA900002; Sun, 3 Oct 2021 21:07:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 254266B006C for ; Sun, 3 Oct 2021 21:07:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E0E331803032F for ; Mon, 4 Oct 2021 01:07:23 +0000 (UTC) X-FDA: 78656966766.30.AF48152 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 9274CD03848E for ; Mon, 4 Oct 2021 01:07:23 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id l6so9984468plh.9 for ; Sun, 03 Oct 2021 18:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=pStQdMrL6ZFdXlJGha4PGljRtDULz8i5+uPOyRWf8rU=; b=kAMJB1dPHfIu0grrWDbrhbolngM0JPtqVX6W4LQ0dtNlTNzO4A4V4jJfu3GO//KpI/ zoCckKf+f5s6de3QFu2N7/YZY8bZhxxvwZ/cVyDsFquSDFcoOsCt9tkpgk8jwGmfEcWR OKK/uu0L1RIcNvw+Ro/RFp06yHEtZkrhJNa8FM/BDB59V45gHSKiejNo357eRnDtDSy/ b76AdDM/tjRm2HBiefXqqGCizbuXhYPpOwxVNjkVSaN+zzokQ1GhYkxAEiqJ/E/NxsxO cqUaV5bA/NdeHMtleODM3D57VAurRyugnfdK9q0qM1J2IakdMLzcGTbSIMufvfOtYCZ7 ycdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=pStQdMrL6ZFdXlJGha4PGljRtDULz8i5+uPOyRWf8rU=; b=RPikCv8zc1CHXrF6AIEChU3BVsbbeVhn630iqXy8X2oTLaUBohpMkObzlEmJvCx4rC BV/QsGP6qw+eGbuw7rp8aKdx46ZCcpbmSPSosXeZMvFLOyR/G13PXckaSOdKc4gk9D7j mQxGJTRIe0/sa1fm2lPGfvoEyd/56+bmWu761eVW8ylS8V6/LhWcOzLliEpx/IugGC6H sAZ8dDnEyry495J4p2zUNcAlxkZIfsxWMuP6a/YAthPpXXuzG4t/tqKjtK1Pmq7Ux5tX 7swbjlCCt6Q9K+m8HwRufLTvL27OMz9ffTOLAwlXYq1guzS83lLbvmtIzT88Wipv0OCK dgbg== X-Gm-Message-State: AOAM532iq1Z/klZH2vieDlhAqhfhwClEcCglLy9NGutZs9JQEEok6hlF aH50yIMpW+RZY/t+N7EwfSkpiA== X-Google-Smtp-Source: ABdhPJw+OUZxiTir+uXz7ip5A94n6l2wmdN8lZupAMuxEoGz73pp9OWHAtT4OzzvlWLfGbA3B+EWQQ== X-Received: by 2002:a17:902:7e48:b0:13d:a58a:e9ce with SMTP id a8-20020a1709027e4800b0013da58ae9cemr20330094pln.21.1633309642214; Sun, 03 Oct 2021 18:07:22 -0700 (PDT) Received: from [2620:15c:17:3:4faa:17e6:3602:9e7d] ([2620:15c:17:3:4faa:17e6:3602:9e7d]) by smtp.gmail.com with ESMTPSA id p24sm2314787pjz.32.2021.10.03.18.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 18:07:21 -0700 (PDT) Date: Sun, 3 Oct 2021 18:07:20 -0700 (PDT) From: David Rientjes To: Rustam Kovhaev cc: Vlastimil Babka , Dave Chinner , djwong@kernel.org, linux-xfs@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, Al Viro , dvyukov@google.com Subject: Re: [PATCH] xfs: use kmem_cache_free() for kmem_cache objects In-Reply-To: Message-ID: <1e0df91-556e-cee5-76f7-285d28fe31@google.com> References: <20210929212347.1139666-1-rkovhaev@gmail.com> <20210930044202.GP2361455@dread.disaster.area> <17f537b3-e2eb-5d0a-1465-20f3d3c960e2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9274CD03848E X-Stat-Signature: ty4fh3jozukrhznfim7jz1gqex44xnzh Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kAMJB1dP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=rientjes@google.com X-HE-Tag: 1633309643-994317 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 30 Sep 2021, Rustam Kovhaev wrote: > > >> I think it's fair if something like XFS (not meant for tiny systems AFAIK?) > > >> excludes SLOB (meant for tiny systems). Clearly nobody tried to use these > > >> two together last 5 years anyway. > > > > > > +1 for adding Kconfig option, it seems like some things are not meant to > > > be together. > > > > But if we patch SLOB, we won't need it. > > OK, so we consider XFS on SLOB a supported configuration that might be > used and should be tested. > I'll look into maybe adding a config with CONFIG_SLOB and CONFIG_XFS_FS > to syzbot. > > It seems that we need to patch SLOB anyway, because any other code can > hit the very same issue. > It's probably best to introduce both (SLOB fix and Kconfig change for XFS), at least in the interim because the combo of XFS and SLOB could be broken in other ways. If syzbot doesn't complain with a patched kernel to allow SLOB to be used with XFS, then we could potentially allow them to be used together. (I'm not sure that this freeing issue is the *only* thing that is broken, nor that we have sufficient information to make that determination right now..)