From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF20C433B4 for ; Mon, 3 May 2021 20:14:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7DB961159 for ; Mon, 3 May 2021 20:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7DB961159 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldexy-0006Xs-Lc for qemu-devel@archiver.kernel.org; Mon, 03 May 2021 16:14:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lderp-0002XQ-QI; Mon, 03 May 2021 16:08:33 -0400 Received: from [201.28.113.2] (port=34860 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lderm-00037I-Sl; Mon, 03 May 2021 16:08:33 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Mon, 3 May 2021 17:08:28 -0300 Received: from [127.0.0.1] (unknown [10.10.71.235]) by power9a (Postfix) with ESMTPS id 5640680134C; Mon, 3 May 2021 17:08:28 -0300 (-03) Subject: Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static To: Richard Henderson , qemu-devel@nongnu.org References: <20210430193533.82136-1-bruno.larsen@eldorado.org.br> <20210430193533.82136-5-bruno.larsen@eldorado.org.br> <79cda095-9ba0-0ec6-c89d-77e2d6dbf312@linaro.org> <923b7fd2-122a-316b-adbe-fb9a2655ab61@linaro.org> From: Bruno Piazera Larsen Message-ID: <1e284704-e46a-8af3-7dee-670e274c99c4@eldorado.org.br> Date: Mon, 3 May 2021 17:08:28 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <923b7fd2-122a-316b-adbe-fb9a2655ab61@linaro.org> Content-Type: multipart/alternative; boundary="------------1A0BA943646C86CE71E46815" Content-Language: en-US X-OriginalArrivalTime: 03 May 2021 20:08:28.0714 (UTC) FILETIME=[152AB8A0:01D74058] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=bruno.larsen@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br, lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------1A0BA943646C86CE71E46815 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 03/05/2021 12:25, Richard Henderson wrote: > On 5/3/21 4:28 AM, Bruno Piazera Larsen wrote: >>> Note for future cleanup: Make spr_tcg.c be standalone as well. Just >>> need to move a few declarations to a translate.h. >> it's not that easy, unfortunately. The readers and writers use a lot >> of global variables declared in translate.c, so we'd need to create >> getters and setters, or some better solution, before doing that. > > No need for getters, and certainly not for setters (all of the globals > are write-once at startup).  Just move the declarations into a shared > translate.h.  That's what we've done for target/arm/. Ah, I can take a look later, but this would be pretty low priority compared to what is being requested of us right now. And that's if we separate it like that anyway > > > r~ -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer --------------1A0BA943646C86CE71E46815 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 03/05/2021 12:25, Richard Henderson wrote:
On 5/3/21 4:28 AM, Bruno Piazera Larsen wrote:
Note for future cleanup: Make spr_tcg.c be standalone as well. Just need to move a few declarations to a translate.h.
it's not that easy, unfortunately. The readers and writers use a lot of global variables declared in translate.c, so we'd need to create getters and setters, or some better solution, before doing that.

No need for getters, and certainly not for setters (all of the globals are write-once at startup).  Just move the declarations into a shared translate.h.  That's what we've done for target/arm/.
Ah, I can take a look later, but this would be pretty low priority compared to what is being requested of us right now. And that's if we separate it like that anyway


r~
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer
--------------1A0BA943646C86CE71E46815--