All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Spinler <mspinler@linux.ibm.com>
To: "Duke Du (杜祥嘉)" <Duke.Du@quantatw.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Cc: "Eddie Lu (陸宇岡)" <Eddie.Lu@quantatw.com>,
	"Fran Hsu (徐誌謙)" <Fran.Hsu@quantatw.com>,
	"George Hung (洪忠敬)" <George.Hung@quantatw.com>
Subject: Re: Sensor value is not accurate which is generated by phosphor-hwmon
Date: Wed, 8 Jul 2020 13:37:39 -0500	[thread overview]
Message-ID: <1e29f5ac-8c97-3329-aeed-bf7c79eda7af@linux.ibm.com> (raw)
In-Reply-To: <07cbefdd-1768-91f2-37af-0918627b1f5b@linux.ibm.com>



On 7/7/2020 12:48 PM, Matt Spinler wrote:
>
>
> On 7/6/2020 9:15 PM, Duke Du (杜祥嘉) wrote:
>>
>> Hi All,
>>
>>   I found sensor value type is changed to double in
>>
>> xyz/openbmc_project/Sensor/Value.interface.yaml,
>>
>> after this change, the sensor value on the interface
>>
>> xyz.openbmc_project.Sensor.Value which is generated by
>>
>> phosphor-hwmon is not accurate, for example, 0.99 volts
>>
>> would be record 0 volts on the interface. Do I miss some
>>
>> configuration for phosphor-hwmon ?
>>
>
> Looks like that is indeed a problem.  I haven't looked closely yet,
> but I wonder if how the code is attempting to support Sensor.Value
> as both an int64 and a double at the same time has an issue.
>
> Maybe now would be a good time to just support the double version.
> I can take a look.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-hwmon/+/34481

>
>> Sensor value type is changed to double, which commit is :
>>
>> 4ec6587fa908fe9df41cc0962ab6ff6446fbd54f
>> https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f 
>>
>>
>> Thanks.
>>
>> Duke Du
>>
>

  reply	other threads:[~2020-07-08 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  2:15 Sensor value is not accurate which is generated by phosphor-hwmon Duke Du (杜祥嘉)
2020-07-07 17:48 ` Matt Spinler
2020-07-08 18:37   ` Matt Spinler [this message]
2020-07-09  1:35     ` Duke Du (杜祥嘉)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e29f5ac-8c97-3329-aeed-bf7c79eda7af@linux.ibm.com \
    --to=mspinler@linux.ibm.com \
    --cc=Duke.Du@quantatw.com \
    --cc=Eddie.Lu@quantatw.com \
    --cc=Fran.Hsu@quantatw.com \
    --cc=George.Hung@quantatw.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.