From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E41C50701 for ; Fri, 13 Dec 2019 20:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06DB624769 for ; Fri, 13 Dec 2019 20:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfLMNtH (ORCPT ); Fri, 13 Dec 2019 08:49:07 -0500 Received: from mail.sysgo.com ([176.9.12.79]:58406 "EHLO mail.sysgo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbfLMNtH (ORCPT ); Fri, 13 Dec 2019 08:49:07 -0500 Subject: Re: [PATCH] tty/serial: atmel: fix out of range clock divider handling To: Richard Genoud , gregkh@linuxfoundation.org, jslaby@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Cc: linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191211162954.8393-1-david.engraf@sysgo.com> <822ac68e-4dde-21e8-caf9-a219b910d49e@gmail.com> From: David Engraf Message-ID: <1e2e3f63-84db-4b38-1bf1-85916116e0a2@sysgo.com> Date: Fri, 13 Dec 2019 14:49:03 +0100 MIME-Version: 1.0 In-Reply-To: <822ac68e-4dde-21e8-caf9-a219b910d49e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13.12.19 at 10:57, Richard Genoud wrote: > Hi, > > Le 11/12/2019 à 17:29, David Engraf a écrit : >> Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode >> register was already written thus the clock selection is ignored. >> >> Fix by writing the mode register after calculating the baudrate. >> >> Signed-off-by: David Engraf > > It seems that this bug was introduced by: > commit 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support") > > Could you add the "Fixes:" header ? Sure. > Ludovic, could you check if this was your intent at the time ? > >> --- >> drivers/tty/serial/atmel_serial.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c >> index a8dc8af83f39..9983e2fabbac 100644 >> --- a/drivers/tty/serial/atmel_serial.c >> +++ b/drivers/tty/serial/atmel_serial.c >> @@ -2270,9 +2270,6 @@ static void atmel_set_termios(struct uart_port *port, struct ktermios *termios, >> mode |= ATMEL_US_USMODE_NORMAL; >> } >> > I think it's better to mo move the "Set baud rate" block here (cf bellow) > >> - /* set the mode, clock divisor, parity, stop bits and data size */ >> - atmel_uart_writel(port, ATMEL_US_MR, mode); >> - >> /* >> * when switching the mode, set the RTS line state according to the >> * new mode, otherwise keep the former state >> @@ -2315,6 +2312,9 @@ static void atmel_set_termios(struct uart_port *port, struct ktermios *termios, >> } >> quot = cd | fp << ATMEL_US_FP_OFFSET; >> >> + /* set the mode, clock divisor, parity, stop bits and data size */ >> + atmel_uart_writel(port, ATMEL_US_MR, mode); >> + > I think your patch is good, but I'll be happier if instead of moving > those 2 lines here, the whole "Set the baud rate" block was moved before > "atmel_uart_writel(port, ATMEL_US_MR, mode);" > > That's because at line 2291 the ATMEL_US_CR register is set with > ATMEL_US_RTSDIS or ATMEL_US_RTSEN. > And those 2 values have a different effect depending on US_MR.USART_MODE > > Quoting from the relase manual: > RTSEN: > 1: Drives RTS pin to 1 if US_MR.USART_MODE field = 2, else drives RTS > pin to 0 if US_MR.USART_MODE field = 0. > > RTSDIS: > 1: Drives RTS pin to 0 if US_MR.USART_MODE field = 2, else drives RTS > pin to 1 if US_MR.USART_MODE field = 0. > > So, I think it's better to set the mode register before setting the > control register. I fully agree, the RTS pin configuration depends on USART_MODE. I will make a new version of the patch. Thanks - David > >> if (!(port->iso7816.flags & SER_ISO7816_ENABLED)) >> atmel_uart_writel(port, ATMEL_US_BRGR, quot); >> atmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_RSTSTA | ATMEL_US_RSTRX); >> > > Thanks ! > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383DDC2D0C9 for ; Fri, 13 Dec 2019 22:29:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E29022527 for ; Fri, 13 Dec 2019 22:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JiXRTsFT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E29022527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sysgo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vgKiOZET6Hn5IejyabNPChi3JrGbc0Y7IJaKq4LTI7U=; b=JiXRTsFTtfFDfj2ZknCVsoaVG 54B1g5ZQmhdUx5KBJN7Mozrk4yEW87aZFLdmCi4gyyD4ov8Ss255839c1cUXe1Bb0U4ex9XL6DpqR AMg+FzQOdk3DRlnSdWitvr492mmWWJb3jsXzrsBOLRLL8gtNLGbZ75akPoZy68dTGCQhza3MADXTc ZW8c6Mm6JikMEqg4BoMKRINysg9Rk4Ixq8kh8wXs4rj7KnZ+WSqvdu6asDb3N3ju/+zDhSyt3Ubqy vEhTuqEXibcLrbds7A8y/Uzl0g/0Ui9gUsgAgZZlhg7o9aarqZ7ebm1XxfLEnnHTULQ3IuxBUaHZO bcvyLYbVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iflK9-0006YC-Lp; Fri, 13 Dec 2019 13:49:41 +0000 Received: from mail.sysgo.com ([176.9.12.79]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iflK6-0006Xp-Hd for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 13:49:40 +0000 Subject: Re: [PATCH] tty/serial: atmel: fix out of range clock divider handling To: Richard Genoud , gregkh@linuxfoundation.org, jslaby@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com References: <20191211162954.8393-1-david.engraf@sysgo.com> <822ac68e-4dde-21e8-caf9-a219b910d49e@gmail.com> From: David Engraf Message-ID: <1e2e3f63-84db-4b38-1bf1-85916116e0a2@sysgo.com> Date: Fri, 13 Dec 2019 14:49:03 +0100 MIME-Version: 1.0 In-Reply-To: <822ac68e-4dde-21e8-caf9-a219b910d49e@gmail.com> Content-Language: de-DE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_054938_734515_48F0EAE7 X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiAxMy4xMi4xOSBhdCAxMDo1NywgUmljaGFyZCBHZW5vdWQgd3JvdGU6Cj4gSGksCj4g Cj4gTGUgMTEvMTIvMjAxOSDDoCAxNzoyOSwgRGF2aWQgRW5ncmFmIGEgw6ljcml0wqA6Cj4+IFVz ZSBNQ0tfRElWOCB3aGVuIHRoZSBjbG9jayBkaXZpZGVyIGlzID4gNjU1MzUuIFVuZm9ydHVuYXRl bHkgdGhlIG1vZGUKPj4gcmVnaXN0ZXIgd2FzIGFscmVhZHkgd3JpdHRlbiB0aHVzIHRoZSBjbG9j ayBzZWxlY3Rpb24gaXMgaWdub3JlZC4KPj4KPj4gRml4IGJ5IHdyaXRpbmcgdGhlIG1vZGUgcmVn aXN0ZXIgYWZ0ZXIgY2FsY3VsYXRpbmcgdGhlIGJhdWRyYXRlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBEYXZpZCBFbmdyYWYgPGRhdmlkLmVuZ3JhZkBzeXNnby5jb20+Cj4gCj4gSXQgc2VlbXMgdGhh dCB0aGlzIGJ1ZyB3YXMgaW50cm9kdWNlZCBieToKPiBjb21taXQgNWJmNTYzNWFjMTcwICgidHR5 L3NlcmlhbDogYXRtZWw6IGFkZCBmcmFjdGlvbmFsIGJhdWQgcmF0ZSBzdXBwb3J0IikKPiAKPiBD b3VsZCB5b3UgYWRkIHRoZSAiRml4ZXM6IiBoZWFkZXIgPwoKU3VyZS4KCj4gTHVkb3ZpYywgY291 bGQgeW91IGNoZWNrIGlmIHRoaXMgd2FzIHlvdXIgaW50ZW50IGF0IHRoZSB0aW1lID8KPiAKPj4g LS0tCj4+ICAgZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jIHwgNiArKystLS0KPj4g ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jIGIvZHJpdmVycy90 dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jCj4+IGluZGV4IGE4ZGM4YWY4M2YzOS4uOTk4M2UyZmFi YmFjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3R0eS9zZXJpYWwvYXRtZWxfc2VyaWFsLmMKPj4g KysrIGIvZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jCj4+IEBAIC0yMjcwLDkgKzIy NzAsNiBAQCBzdGF0aWMgdm9pZCBhdG1lbF9zZXRfdGVybWlvcyhzdHJ1Y3QgdWFydF9wb3J0ICpw b3J0LCBzdHJ1Y3Qga3Rlcm1pb3MgKnRlcm1pb3MsCj4+ICAgCQltb2RlIHw9IEFUTUVMX1VTX1VT TU9ERV9OT1JNQUw7Cj4+ICAgCX0KPj4gICAKPiBJIHRoaW5rIGl0J3MgYmV0dGVyIHRvIG1vIG1v dmUgdGhlICJTZXQgYmF1ZCByYXRlIiBibG9jayBoZXJlIChjZiBiZWxsb3cpCj4gCj4+IC0JLyog c2V0IHRoZSBtb2RlLCBjbG9jayBkaXZpc29yLCBwYXJpdHksIHN0b3AgYml0cyBhbmQgZGF0YSBz aXplICovCj4+IC0JYXRtZWxfdWFydF93cml0ZWwocG9ydCwgQVRNRUxfVVNfTVIsIG1vZGUpOwo+ PiAtCj4+ICAgCS8qCj4+ICAgCSAqIHdoZW4gc3dpdGNoaW5nIHRoZSBtb2RlLCBzZXQgdGhlIFJU UyBsaW5lIHN0YXRlIGFjY29yZGluZyB0byB0aGUKPj4gICAJICogbmV3IG1vZGUsIG90aGVyd2lz ZSBrZWVwIHRoZSBmb3JtZXIgc3RhdGUKPj4gQEAgLTIzMTUsNiArMjMxMiw5IEBAIHN0YXRpYyB2 b2lkIGF0bWVsX3NldF90ZXJtaW9zKHN0cnVjdCB1YXJ0X3BvcnQgKnBvcnQsIHN0cnVjdCBrdGVy bWlvcyAqdGVybWlvcywKPj4gICAJfQo+PiAgIAlxdW90ID0gY2QgfCBmcCA8PCBBVE1FTF9VU19G UF9PRkZTRVQ7Cj4+ICAgCj4+ICsJLyogc2V0IHRoZSBtb2RlLCBjbG9jayBkaXZpc29yLCBwYXJp dHksIHN0b3AgYml0cyBhbmQgZGF0YSBzaXplICovCj4+ICsJYXRtZWxfdWFydF93cml0ZWwocG9y dCwgQVRNRUxfVVNfTVIsIG1vZGUpOwo+PiArCj4gSSB0aGluayB5b3VyIHBhdGNoIGlzIGdvb2Qs IGJ1dCBJJ2xsIGJlIGhhcHBpZXIgaWYgaW5zdGVhZCBvZiBtb3ZpbmcKPiB0aG9zZSAyIGxpbmVz IGhlcmUsIHRoZSB3aG9sZSAiU2V0IHRoZSBiYXVkIHJhdGUiIGJsb2NrIHdhcyBtb3ZlZCBiZWZv cmUKPiAiYXRtZWxfdWFydF93cml0ZWwocG9ydCwgQVRNRUxfVVNfTVIsIG1vZGUpOyIKPiAKPiBU aGF0J3MgYmVjYXVzZSBhdCBsaW5lIDIyOTEgdGhlIEFUTUVMX1VTX0NSIHJlZ2lzdGVyIGlzIHNl dCB3aXRoCj4gQVRNRUxfVVNfUlRTRElTIG9yIEFUTUVMX1VTX1JUU0VOLgo+IEFuZCB0aG9zZSAy IHZhbHVlcyBoYXZlIGEgZGlmZmVyZW50IGVmZmVjdCBkZXBlbmRpbmcgb24gVVNfTVIuVVNBUlRf TU9ERQo+IAo+IFF1b3RpbmcgZnJvbSB0aGUgcmVsYXNlIG1hbnVhbDoKPiBSVFNFTjoKPiAxOiBE cml2ZXMgUlRTIHBpbiB0byAxIGlmIFVTX01SLlVTQVJUX01PREUgZmllbGQgPSAyLCBlbHNlIGRy aXZlcyBSVFMKPiBwaW4gdG8gMCBpZiBVU19NUi5VU0FSVF9NT0RFIGZpZWxkID0gMC4KPiAKPiBS VFNESVM6Cj4gMTogRHJpdmVzIFJUUyBwaW4gdG8gMCBpZiBVU19NUi5VU0FSVF9NT0RFIGZpZWxk ID0gMiwgZWxzZSBkcml2ZXMgUlRTCj4gcGluIHRvIDEgaWYgVVNfTVIuVVNBUlRfTU9ERSBmaWVs ZCA9IDAuCj4gCj4gU28sIEkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gc2V0IHRoZSBtb2RlIHJlZ2lz dGVyIGJlZm9yZSBzZXR0aW5nIHRoZQo+IGNvbnRyb2wgcmVnaXN0ZXIuCgpJIGZ1bGx5IGFncmVl LCB0aGUgUlRTIHBpbiBjb25maWd1cmF0aW9uIGRlcGVuZHMgb24gVVNBUlRfTU9ERS4gSSB3aWxs IAptYWtlIGEgbmV3IHZlcnNpb24gb2YgdGhlIHBhdGNoLgoKVGhhbmtzCi0gRGF2aWQKCgo+IAo+ PiAgIAlpZiAoIShwb3J0LT5pc283ODE2LmZsYWdzICYgU0VSX0lTTzc4MTZfRU5BQkxFRCkpCj4+ ICAgCQlhdG1lbF91YXJ0X3dyaXRlbChwb3J0LCBBVE1FTF9VU19CUkdSLCBxdW90KTsKPj4gICAJ YXRtZWxfdWFydF93cml0ZWwocG9ydCwgQVRNRUxfVVNfQ1IsIEFUTUVMX1VTX1JTVFNUQSB8IEFU TUVMX1VTX1JTVFJYKTsKPj4KPiAKPiBUaGFua3MgIQo+IAoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK