From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] event: Prevent bitbake from executing event handler for wrong multiconfig target
Date: Fri, 05 Feb 2021 12:17:57 +0000 [thread overview]
Message-ID: <1e3bfe4059efd60bf6ee4b31c1b81355f6657586.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210204221422.16042-1-tomasz.dziendzielski@gmail.com>
On Thu, 2021-02-04 at 23:14 +0100, Tomasz Dziendzielski wrote:
> When multiconfig is used bitbake might try to run events that don't
> exist for specific mc target. In cooker.py we pass
> `self.databuilder.mcdata[mc]` data that contains names of events'
> handlers per mc target, but fire_class_handlers uses global _handlers
> variable that is created during parsing of all the targets.
>
> This leads to a problem where bitbake runs event handler that don't
> exist for a target or even overrides them - if multiple targets use
> event handler with the same name but different code then only one
> version will be executed for all targets.
>
> See [YOCTO #13071] for detailed bug information.
>
> I added a mc target name as a prefix to event handler name so there
> won't be two different handlers with the same name.
This looks like it solves a few issues, thanks!
I'll include it in the next test runs and see where we go from there
but it looks right.
Cheers,
Richard
next prev parent reply other threads:[~2021-02-05 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 22:14 [PATCH] event: Prevent bitbake from executing event handler for wrong multiconfig target Tomasz Dziendzielski
2021-02-05 12:17 ` Richard Purdie [this message]
2021-02-05 14:26 ` [bitbake-devel] " Tomasz Dziendzielski
2021-02-05 14:42 ` Richard Purdie
2021-02-05 15:13 ` Tomasz Dziendzielski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3bfe4059efd60bf6ee4b31c1b81355f6657586.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=tomasz.dziendzielski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.