All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lukas Bulwahn" <Lukas.Bulwahn@bmw.de>
To: <mab@mab-labs.com>
Cc: <skhan@linuxfoundation.org>, <linux-safety@lists.elisa.tech>
Subject: Re: [linux-safety] [PATCH] coccinelle: misc: Check for hard-coded constants
Date: Thu, 13 Aug 2020 15:16:14 +0000	[thread overview]
Message-ID: <1e3cf82b34e2413bb0b438ef1adfa04b@smucm07j.europe.bmw.corp> (raw)

To your questions, here is my opinion...

1. Is the header format in the semantic patch acceptable (i.e. referencing the CWE that this particular semantic patch aims to address)?

Actually, I think we should that for the existing rules as well.

I was thinking of the following format:

# Addresses: CWE-414 ("Missing Lock Check")

or

# Contributes-to: Missing Lock Check [CWE-414]

I think it is good discussion to have with Julia Lawall, Dan Carpenter, Luc Van Oostenryck, Joe Perches, etc. to see how they would want to maintain such information within their tools.


2. Should we create a separate directory for ELISA within coccinelle?

No, we do not structure according to the contributor, then the kernel architecture would be "linus directory", "andrew directory", "shuah directory", etc.

I would suggest that we could roughly structure according the existing structure for coccinelle and the CWE structure.


Lukas

P.S.: We need to set groups.io not to generate HTML emails on responses etc. when we want to engage with the kernel community. Let us check if we get that set up.
 

             reply	other threads:[~2020-08-13 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 15:16 Lukas Bulwahn [this message]
2020-08-13 15:23 ` [linux-safety] [PATCH] coccinelle: misc: Check for hard-coded constants Mohammed Billoo
2020-08-13 15:33   ` Lukas Bulwahn
2020-08-13 15:41     ` Sudip Mukherjee
2020-08-13 17:02       ` Shuah Khan
     [not found]       ` <162AE2925F9D984B.16363@lists.elisa.tech>
2020-08-13 19:43         ` Shuah Khan
  -- strict thread matches above, loose matches on Subject: below --
2020-08-13 15:45 Lukas Bulwahn
2020-08-12 23:43 Mohammed Billoo
2020-08-13 14:39 ` [linux-safety] " Shuah Khan
2020-08-13 14:41   ` Mohammed Billoo
     [not found]   ` <162ADAEB16525C4A.3117@lists.elisa.tech>
2020-08-13 14:45     ` Mohammed Billoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e3cf82b34e2413bb0b438ef1adfa04b@smucm07j.europe.bmw.corp \
    --to=lukas.bulwahn@bmw.de \
    --cc=linux-safety@lists.elisa.tech \
    --cc=mab@mab-labs.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.