From: Akira Yokosawa <akiyks@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: perfbook@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: [PATCH] advsync: Fix store-buffering sequence table
Date: Wed, 5 Jul 2017 00:23:09 +0900 [thread overview]
Message-ID: <1e3fe2af-cce3-7327-488d-fb27ec7d9fc8@gmail.com> (raw)
From 2845eb208a6e63493997de47293a47ef774a9d49 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Tue, 4 Jul 2017 23:18:30 +0900
Subject: [PATCH] advsync: Fix store-buffering sequence table
Row 6 of the table added in commit 2d5bf8d25a71 ("advsync: Add
memory-barriered store-buffering example") needs some context
adjustment.
Also tweak horizontal spacing of wide tables for one-column layout.
Also add a few words to the footnote giving definition of
__atomic_thread_fence().
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
advsync/memorybarriers.tex | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
index 4ae3ca8..f26a7c5 100644
--- a/advsync/memorybarriers.tex
+++ b/advsync/memorybarriers.tex
@@ -174,7 +174,7 @@ Figure~\ref{fig:advsync:Memory Misordering: Store-Buffering Litmus Test}.
\begin{table*}
\small
-\centering
+\centering\OneColumnHSpace{-.1in}
\begin{tabular}{r||l|l|l||l|l|l}
& \multicolumn{3}{c||}{CPU 0} & \multicolumn{3}{c}{CPU 1} \\
\cline{2-7}
@@ -318,6 +318,8 @@ ordering and memory barriers work, read on!
The first stop is
Figure~\ref{fig:advsync:Memory Ordering: Store-Buffering Litmus Test},
which has \co{__atomic_thread_fence()} directives\footnote{
+ One of GCC's atomic intrinsics briefly introduced in
+ Section~\ref{sec:toolsoftrade:Atomic Operations (C11)}.
Similar to the Linux kernel's \co{smp_mb()} full memory barrier.}
placed between
the store and load in both \co{P0()} and \co{P1()}, but is otherwise
@@ -339,7 +341,7 @@ Figure~\ref{fig:advsync:Memory Misordering: Store-Buffering Litmus Test}.
\begin{table*}
\small
-\centering
+\centering\OneColumnHSpace{-0.75in}
\begin{tabular}{r||l|l|l||l|l|l}
& \multicolumn{3}{c||}{CPU 0} & \multicolumn{3}{c}{CPU 1} \\
\cline{2-7}
@@ -362,8 +364,8 @@ Figure~\ref{fig:advsync:Memory Misordering: Store-Buffering Litmus Test}.
5 & (Finish store) & & \tco{x0==2} &
(Finish store) & & \tco{x1==2} \\
\hline
- 6 & \tco{r2 = *x1;} (2) & \tco{x0==2} & \tco{x1==0} &
- \tco{r2 = *x0;} (2) & \tco{x1==2} & \tco{x0==0} \\
+ 6 & \tco{r2 = *x1;} (2) & & \tco{x1==2} &
+ \tco{r2 = *x0;} (2) & & \tco{x0==2} \\
\end{tabular}
\caption{Memory Ordering: Store-Buffering Sequence of Events}
\label{tab:advsync:Memory Ordering: Store-Buffering Sequence of Events}
--
2.7.4
next reply other threads:[~2017-07-04 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:23 Akira Yokosawa [this message]
2017-07-04 22:21 ` [PATCH] advsync: Fix store-buffering sequence table Paul E. McKenney
2017-07-05 14:22 ` Akira Yokosawa
2017-07-05 15:40 ` Paul E. McKenney
2017-07-05 15:50 ` Paul E. McKenney
2017-07-05 17:32 ` Paul E. McKenney
2017-07-05 22:15 ` Akira Yokosawa
2017-07-05 22:32 ` Paul E. McKenney
2017-07-05 22:40 ` Akira Yokosawa
2017-07-06 0:46 ` Paul E. McKenney
2017-07-06 1:07 ` Akira Yokosawa
2017-07-06 12:09 ` Akira Yokosawa
2017-07-06 18:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3fe2af-cce3-7327-488d-fb27ec7d9fc8@gmail.com \
--to=akiyks@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.