From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E5BEC77B76 for ; Fri, 21 Apr 2023 19:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:Cc:To:Subject: Message-ID:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xu690kIYWS4khnW76QnVSggggfoMfrHrBkoc1kmaoCU=; b=higkWDAfXiR5so RsNZzIJ56BvN6BSAsHmQXdc3RdYx1BjB9bwsKXKqDP06M3/pi6ek0k9FQTOAqbverR/znswwFFi/T gIt3MChg/GPVUTG2D0Co5GgoxV9CohNezI/+gQdUzEoEVhQfulKSwzs3kRVbRmFJP7pNdui2eD5hM K4UlVz1Z+8Ml457LHXlvS0KYcpViiGuuqMwq95cs6CtH4EVMsFjmohpEdHbZ6jxUI+m4aS85SD5k9 7NCQl/LsQTUSxAVSEou6ZV6+rJzgBLXtHx6YgcEo8yizqix4nKwuEVrZVjqtxNq4DH4h7zVmA4WrV 1B4aYXOXbMWwWC/S7qOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppw77-00BhYe-1a; Fri, 21 Apr 2023 19:08:09 +0000 Received: from out-45.mta0.migadu.com ([91.218.175.45]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppw74-00BhWC-1d for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 19:08:08 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682104075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKlUKQKgLrB7w8fshbu0E+uDKbiprMpICwAXatrxAkY=; b=dWr+W3dX4SIW2sYPHhH4eeHKe+Cwcb4NRKUxnWQIUtSCaM9cKaIiCJpZQtjt/0fy6sE8NC lC7RUXKzc8I25wiPz98Az23nk4XEZOVTGU53GCA9aj635tXwOtCdqoMlzqZHADFuLyoVC1 CR5oo7gk+8vkJzQlgDExSKmkCTG3cYc= Date: Fri, 21 Apr 2023 19:07:53 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Konstantin Ryabitsev" Message-ID: <1e4386d3a24bbf4c70880fef2af74928@linux.dev> Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props To: "Rob Herring" , "Florian Fainelli" Cc: "Jim Quinlan" , "Krzysztof Kozlowski" , linux-pci@vger.kernel.org, "Nicolas Saenz Julienne" , "Bjorn Helgaas" , "Lorenzo Pieralisi" , "Cyril Brulebois" , "Phil Elwell" , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, "Lorenzo Pieralisi" , "=?utf-8?B?S3J6eXN6dG9mIFdpbGN6ecWEc2tp?=" , "Krzysztof Kozlowski" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list" In-Reply-To: <20230418183536.GA2087834-robh@kernel.org> References: <20230418183536.GA2087834-robh@kernel.org> <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> <20230412153723.GA2473030-robh@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_120806_983131_C2A7CFC6 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org April 18, 2023 2:35 PM, "Rob Herring" wrote: >> Some trees like the networking >> tree do merge commits of patch sets where the cover letter is used as part >> of the merge commit message. Other maintainers don't, and some want the >> change log after the '---' and some do not. > > I'm not aware of anyone except for DRM wanting the changelog in the > final commits, but that's really a different issue. I don't think anyone wants changelogs in actual final commits, they usually go under "---" in patch submissions. > I'm pretty sure no one will complain about a changelog in the patches. I > guess you just have to duplicate it if you think it should be in both. > b4 could be taught to do that I suppose. IMO, the cover letter should > have a higher level changelog than the individual patches. b4 doesn't really need to manage per-patch changelogs -- they should just go under "---" in the commit. When you send the series either via "b4 send" or via git-send-email, the changelogs will be properly included in the message, but they won't make it into the tree after the maintainer runs "git am", because git will drop anything under the first "---" in the commit message. The cover letter changelog is supposed to be higher level than individual patch changelogs, so I don't think it makes sense for b4 to collect them from individual patches. -K _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74E8C77B76 for ; Fri, 21 Apr 2023 19:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233264AbjDUTQX (ORCPT ); Fri, 21 Apr 2023 15:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjDUTQU (ORCPT ); Fri, 21 Apr 2023 15:16:20 -0400 X-Greylist: delayed 499 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 21 Apr 2023 12:16:19 PDT Received: from out-15.mta0.migadu.com (out-15.mta0.migadu.com [91.218.175.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F6FF10D0 for ; Fri, 21 Apr 2023 12:16:19 -0700 (PDT) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682104075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKlUKQKgLrB7w8fshbu0E+uDKbiprMpICwAXatrxAkY=; b=dWr+W3dX4SIW2sYPHhH4eeHKe+Cwcb4NRKUxnWQIUtSCaM9cKaIiCJpZQtjt/0fy6sE8NC lC7RUXKzc8I25wiPz98Az23nk4XEZOVTGU53GCA9aj635tXwOtCdqoMlzqZHADFuLyoVC1 CR5oo7gk+8vkJzQlgDExSKmkCTG3cYc= Date: Fri, 21 Apr 2023 19:07:53 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Konstantin Ryabitsev" Message-ID: <1e4386d3a24bbf4c70880fef2af74928@linux.dev> Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props To: "Rob Herring" , "Florian Fainelli" Cc: "Jim Quinlan" , "Krzysztof Kozlowski" , linux-pci@vger.kernel.org, "Nicolas Saenz Julienne" , "Bjorn Helgaas" , "Lorenzo Pieralisi" , "Cyril Brulebois" , "Phil Elwell" , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, "Lorenzo Pieralisi" , "=?utf-8?B?S3J6eXN6dG9mIFdpbGN6ecWEc2tp?=" , "Krzysztof Kozlowski" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list" In-Reply-To: <20230418183536.GA2087834-robh@kernel.org> References: <20230418183536.GA2087834-robh@kernel.org> <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> <20230412153723.GA2473030-robh@kernel.org> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org April 18, 2023 2:35 PM, "Rob Herring" wrote:=0A>> Some = trees like the networking=0A>> tree do merge commits of patch sets where = the cover letter is used as part=0A>> of the merge commit message. Other = maintainers don't, and some want the=0A>> change log after the '---' and = some do not.=0A> =0A> I'm not aware of anyone except for DRM wanting the = changelog in the=0A> final commits, but that's really a different issue.= =0A=0AI don't think anyone wants changelogs in actual final commits, they= usually go under "---" in patch submissions.=0A=0A> I'm pretty sure no o= ne will complain about a changelog in the patches. I=0A> guess you just h= ave to duplicate it if you think it should be in both.=0A> b4 could be ta= ught to do that I suppose. IMO, the cover letter should=0A> have a higher= level changelog than the individual patches.=0A=0Ab4 doesn't really need= to manage per-patch changelogs -- they should just go under "---" in the= commit. When you send the series either via "b4 send" or via git-send-em= ail, the changelogs will be properly included in the message, but they wo= n't make it into the tree after the maintainer runs "git am", because git= will drop anything under the first "---" in the commit message.=0A=0AThe= cover letter changelog is supposed to be higher level than individual pa= tch changelogs, so I don't think it makes sense for b4 to collect them fr= om individual patches.=0A=0A-K