From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA95DC433E0 for ; Tue, 23 Feb 2021 15:15:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47CFE64E22 for ; Tue, 23 Feb 2021 15:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47CFE64E22 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.88823.167152 (Exim 4.92) (envelope-from ) id 1lEZPD-0007hv-5X; Tue, 23 Feb 2021 15:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 88823.167152; Tue, 23 Feb 2021 15:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEZPD-0007ho-2d; Tue, 23 Feb 2021 15:15:19 +0000 Received: by outflank-mailman (input) for mailman id 88823; Tue, 23 Feb 2021 15:15:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEZPB-0007hi-No for xen-devel@lists.xenproject.org; Tue, 23 Feb 2021 15:15:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7010f2bb-2de3-4491-a5bb-116fb016ab13; Tue, 23 Feb 2021 15:15:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7F685AC1D; Tue, 23 Feb 2021 15:15:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7010f2bb-2de3-4491-a5bb-116fb016ab13 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614093315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t2UA1j/RmVE55nOLziUQOk9xwYCY+H9PjhIvbvQ/JsU=; b=TIw0EvIylOOPOOpLu6ZwHp6IHezYq14ATWkdcs9FxQugQFGBrDfbiWqCA1otCoKnzpMcmE IV1vF2SKsuQ5o90MdI13KEwyxLdTMK0lkij7JmSIBu1fkQGQ/fjWV2BMHJBFGFe3WpfVU/ Jir9yIeHsfk/TlVshmm2P7Xwj6Fumuw= Subject: Re: [PATCH v2 6/8] x86: rename copy_{from,to}_user() to copy_{from,to}_guest_pv() To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson References: <5104a32f-e2a1-06a5-a637-9702e4562b81@suse.com> From: Jan Beulich Message-ID: <1e4d803c-ab4f-b7f4-c8e7-e7ea450c7921@suse.com> Date: Tue, 23 Feb 2021 16:15:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.02.2021 12:04, Roger Pau Monné wrote: > On Wed, Feb 17, 2021 at 09:22:32AM +0100, Jan Beulich wrote: >> Bring them (back) in line with __copy_{from,to}_guest_pv(). Since it >> falls in the same group, also convert clear_user(). Instead of adjusting >> __raw_clear_guest(), drop it - it's unused and would require a non- >> checking __clear_guest_pv() which we don't have. >> >> Add previously missing __user at some call sites and in the function >> declarations. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Roger Pau Monné Thanks. >> --- a/xen/arch/x86/usercopy.c >> +++ b/xen/arch/x86/usercopy.c >> @@ -109,19 +109,17 @@ unsigned int copy_from_guest_ll(void *to >> #if GUARD(1) + 0 >> >> /** >> - * copy_to_user: - Copy a block of data into user space. >> - * @to: Destination address, in user space. >> - * @from: Source address, in kernel space. >> + * copy_to_guest_pv: - Copy a block of data into guest space. > > I would expand to 'PV guest' here and below, FAOD. Can do, albeit in the header (in particular also in the two patches that have gone in already) we also say just "guest". But since this is a different file, I can make the change without introducing too much of an inconsistency. Jan