From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42477C433DF for ; Thu, 27 Aug 2020 06:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F8C22177B for ; Thu, 27 Aug 2020 06:27:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="sYG/O8pK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbgH0G1L (ORCPT ); Thu, 27 Aug 2020 02:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgH0G1K (ORCPT ); Thu, 27 Aug 2020 02:27:10 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE0DDC061260; Wed, 26 Aug 2020 23:27:09 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4BcXnj6RYlz9sRK; Thu, 27 Aug 2020 16:27:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1598509627; bh=0jnmw3HItILjj9al39tdUW1/oczaOCF9us3o3EFIRyE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=sYG/O8pKqds8ULQ32y2auj0Zciks1xfx3dVbQeRTF7cjRTkoSIt1zXXstER+ujk6a TmlvFvJLcUp/AthOhwI63LKUOZ7Z4c9KjCqCAzx5EXXjYisZrCbCxLm7opDRwyydol jz3awI+osTZzEzcDSO34es+ULJ3tNylQXHZBH9i6zGKh+BjVvUCrqZxezP1y7FlObA 6AZgRQXoGoRuiMRQefnnknFjYKV/KcPi41Y9DlyxBesT0YV6t8h+LCtnPVp+85eAP9 l5w1VZSJTKATH3C9+ZZxG5Rnkcd7aFHJpob7FekhwGO1F6uIFthS0arUnbhvWECEkU p+vJp0SSpEf7w== Message-ID: <1e56af7945b93a22e31ba6d81da82cbdb1b237b6.camel@ozlabs.org> Subject: Re: [PATCH] ARM: aspeed: g5: Do not set sirq polarity From: Jeremy Kerr To: Joel Stanley , Oskar Senft Cc: linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 27 Aug 2020 14:27:02 +0800 In-Reply-To: <20200812112400.2406734-1-joel@jms.id.au> References: <20200812112400.2406734-1-joel@jms.id.au> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joel, > A feature was added to the aspeed vuart driver to configure the vuart > interrupt (sirq) polarity according to the LPC/eSPI strapping register. > > Systems that depend on a active low behaviour (sirq_polarity set to 0) > such as OpenPower boxes also use LPC, so this relationship does not > hold. > > The property was added for a Tyan S7106 system which is not supported > in the kernel tree. Should this or other systems wish to use this > feature of the driver they should add it to the machine specific device > tree. > > Fixes: c791fc76bc72 ("arm: dts: aspeed: Add vuart aspeed,sirq-polarity-sense...") > Cc: stable@vger.kernel.org > Signed-off-by: Joel Stanley LGTM. I've tested this on the s2600st, which is strapped for eSPI. All good there too, as expected. Tested-by: Jeremy Kerr and/or: Reviewed-by: Jeremy Kerr Cheers, Jeremy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD24DC433DF for ; Thu, 27 Aug 2020 06:29:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E8162177B for ; Thu, 27 Aug 2020 06:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TYCVQetd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="sYG/O8pK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E8162177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yqK0v2HqTbm9etJjHlFHOJRDOfKZvyBhrYbDFrYP3qE=; b=TYCVQetdYhQpgI9VumqHdlJTa ZEosSqftwjK/xYUMVqzfHjgPj+Qk07PmAKiSUcI5RoYsD7gcTGqcyOEuT8vMAR2Ooro+DQTUcp+Zo OdvsjEF4zNY849OV1KlpEvCU+tVyHAk5LkulODx7Zcl02waK1+h16n/TGp9ej9oUuhTQd47yaegg3 o8rc4k/pVYZ/+5TGhz2lVUmmJFzp4KsBdC6czEDlDZ5BUPehJvuzDP2nKA2mZPJMXTC7CVTE6yMyI LafeK3sbuo+tCdyA0si231DdhngjCQC2AFVFeRIWqQgxSGy4vtfuTNp5JWc0yAp0yz5Dm3D/6N2CH VcEe57/xA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBBNd-0006Rt-HW; Thu, 27 Aug 2020 06:27:25 +0000 Received: from ozlabs.org ([2401:3900:2:1::2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBBNa-0006RA-VK for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 06:27:24 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4BcXnj6RYlz9sRK; Thu, 27 Aug 2020 16:27:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1598509627; bh=0jnmw3HItILjj9al39tdUW1/oczaOCF9us3o3EFIRyE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=sYG/O8pKqds8ULQ32y2auj0Zciks1xfx3dVbQeRTF7cjRTkoSIt1zXXstER+ujk6a TmlvFvJLcUp/AthOhwI63LKUOZ7Z4c9KjCqCAzx5EXXjYisZrCbCxLm7opDRwyydol jz3awI+osTZzEzcDSO34es+ULJ3tNylQXHZBH9i6zGKh+BjVvUCrqZxezP1y7FlObA 6AZgRQXoGoRuiMRQefnnknFjYKV/KcPi41Y9DlyxBesT0YV6t8h+LCtnPVp+85eAP9 l5w1VZSJTKATH3C9+ZZxG5Rnkcd7aFHJpob7FekhwGO1F6uIFthS0arUnbhvWECEkU p+vJp0SSpEf7w== Message-ID: <1e56af7945b93a22e31ba6d81da82cbdb1b237b6.camel@ozlabs.org> Subject: Re: [PATCH] ARM: aspeed: g5: Do not set sirq polarity From: Jeremy Kerr To: Joel Stanley , Oskar Senft Date: Thu, 27 Aug 2020 14:27:02 +0800 In-Reply-To: <20200812112400.2406734-1-joel@jms.id.au> References: <20200812112400.2406734-1-joel@jms.id.au> User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_022723_388457_20CB9290 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joel, > A feature was added to the aspeed vuart driver to configure the vuart > interrupt (sirq) polarity according to the LPC/eSPI strapping register. > > Systems that depend on a active low behaviour (sirq_polarity set to 0) > such as OpenPower boxes also use LPC, so this relationship does not > hold. > > The property was added for a Tyan S7106 system which is not supported > in the kernel tree. Should this or other systems wish to use this > feature of the driver they should add it to the machine specific device > tree. > > Fixes: c791fc76bc72 ("arm: dts: aspeed: Add vuart aspeed,sirq-polarity-sense...") > Cc: stable@vger.kernel.org > Signed-off-by: Joel Stanley LGTM. I've tested this on the s2600st, which is strapped for eSPI. All good there too, as expected. Tested-by: Jeremy Kerr and/or: Reviewed-by: Jeremy Kerr Cheers, Jeremy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel