From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anton Nefedov <anton.nefedov@virtuozzo.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"Denis V . Lunev" <den@openvz.org>
Subject: Re: [PATCH v4 07/30] qcow2: Document the Extended L2 Entries feature
Date: Tue, 14 Apr 2020 13:23:11 -0500 [thread overview]
Message-ID: <1e6c2a1c-e2b5-609a-72fc-144de466345b@redhat.com> (raw)
In-Reply-To: <w51ftd6rkys.fsf@maestria.local.igalia.com>
On 4/14/20 1:16 PM, Alberto Garcia wrote:
> On Thu 09 Apr 2020 05:12:16 PM CEST, Eric Blake <eblake@redhat.com> wrote:
>> Hmm - raw external files are incompatible with backing files.
>
> Pre-existing, but I just realized that we are not checking that in
> qcow2_do_open(), only on _create().
>
> I suppose that if we find such an image we should either
>
> a) Show an error message and abort.
> b) Clear the 'raw data file' bit and proceed as if it was unset.
I would favor a). Such an image was (hopefully) created externally, and
not by qemu; therefore refusing to open it will call attention to the
image (and it's creation process) being broken, rather than risking
silent corruption of whatever the external process thought it was
accomplishing by creating an image like that.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-14 18:24 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 18:15 [PATCH v4 00/30] Add subcluster allocation to qcow2 Alberto Garcia
2020-03-17 18:15 ` [PATCH v4 01/30] qcow2: Make Qcow2AioTask store the full host offset Alberto Garcia
2020-03-18 11:23 ` Eric Blake
2020-04-08 10:23 ` Max Reitz
2020-04-09 6:49 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:15 ` [PATCH v4 02/30] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset() Alberto Garcia
2020-03-18 12:08 ` Eric Blake
2020-04-08 10:51 ` Max Reitz
2020-04-08 17:29 ` Alberto Garcia
2020-04-09 7:57 ` Vladimir Sementsov-Ogievskiy
2020-04-09 14:35 ` Alberto Garcia
2020-04-09 7:50 ` Vladimir Sementsov-Ogievskiy
2020-04-09 14:45 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 03/30] qcow2: Add calculate_l2_meta() Alberto Garcia
2020-04-09 8:30 ` Vladimir Sementsov-Ogievskiy
2020-04-09 15:12 ` Alberto Garcia
2020-04-09 18:47 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 04/30] qcow2: Split cluster_needs_cow() out of count_cow_clusters() Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 05/30] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied() Alberto Garcia
2020-04-09 10:59 ` Vladimir Sementsov-Ogievskiy
2020-04-09 16:08 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 06/30] qcow2: Add get_l2_entry() and set_l2_entry() Alberto Garcia
2020-04-10 8:48 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 07/30] qcow2: Document the Extended L2 Entries feature Alberto Garcia
2020-04-08 11:09 ` Max Reitz
2020-04-09 15:12 ` Eric Blake
2020-04-10 9:29 ` Vladimir Sementsov-Ogievskiy
2020-04-14 14:50 ` Alberto Garcia
2020-04-14 16:19 ` Vladimir Sementsov-Ogievskiy
2020-04-14 16:30 ` Alberto Garcia
2020-04-14 18:06 ` Vladimir Sementsov-Ogievskiy
2020-04-14 18:13 ` Alberto Garcia
2020-04-15 19:11 ` Alberto Garcia
2020-04-15 21:13 ` Eric Blake
2020-04-10 12:01 ` Alberto Garcia
2020-04-14 18:16 ` Alberto Garcia
2020-04-14 18:23 ` Eric Blake [this message]
2020-04-14 18:25 ` Eric Blake
2020-03-17 18:16 ` [PATCH v4 08/30] qcow2: Add dummy has_subclusters() function Alberto Garcia
2020-04-10 9:11 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 09/30] qcow2: Add subcluster-related fields to BDRVQcow2State Alberto Garcia
2020-04-08 11:12 ` Max Reitz
2020-04-10 9:45 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 10/30] qcow2: Add offset_to_sc_index() Alberto Garcia
2020-04-13 11:02 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 11/30] qcow2: Add l2_entry_size() Alberto Garcia
2020-04-14 9:44 ` Vladimir Sementsov-Ogievskiy
2020-04-14 12:20 ` Alberto Garcia
2020-04-14 12:29 ` Vladimir Sementsov-Ogievskiy
2020-04-14 12:33 ` Alberto Garcia
2020-04-14 12:39 ` Vladimir Sementsov-Ogievskiy
2020-04-14 16:01 ` Eric Blake
2020-04-14 16:16 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 12/30] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap() Alberto Garcia
2020-04-14 9:49 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type() Alberto Garcia
2020-04-08 11:23 ` Max Reitz
2020-04-08 17:46 ` Alberto Garcia
2020-04-09 8:22 ` Max Reitz
2020-04-14 11:10 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 14/30] qcow2: Add cluster type parameter to qcow2_get_host_offset() Alberto Garcia
2020-04-08 12:15 ` Max Reitz
2020-04-14 12:30 ` Vladimir Sementsov-Ogievskiy
2020-04-14 12:38 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 15/30] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_* Alberto Garcia
2020-04-08 12:42 ` Max Reitz
2020-04-15 7:10 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 16/30] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC Alberto Garcia
2020-04-15 7:28 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 17/30] qcow2: Add subcluster support to calculate_l2_meta() Alberto Garcia
2020-04-15 8:39 ` Vladimir Sementsov-Ogievskiy
2020-04-16 20:01 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 18/30] qcow2: Add subcluster support to qcow2_get_host_offset() Alberto Garcia
2020-04-08 12:49 ` Max Reitz
2020-04-08 17:35 ` Alberto Garcia
2020-04-22 8:07 ` Vladimir Sementsov-Ogievskiy
2020-04-22 11:54 ` Alberto Garcia
2020-04-22 12:18 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 19/30] qcow2: Add subcluster support to zero_in_l2_slice() Alberto Garcia
2020-04-22 11:06 ` Vladimir Sementsov-Ogievskiy
2020-04-22 12:53 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice() Alberto Garcia
2020-04-09 10:05 ` Max Reitz
2020-04-10 12:47 ` Alberto Garcia
2020-04-14 10:13 ` Max Reitz
2020-04-22 11:35 ` Vladimir Sementsov-Ogievskiy
2020-04-22 17:42 ` Alberto Garcia
2020-04-22 18:09 ` Vladimir Sementsov-Ogievskiy
2020-04-23 14:18 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 21/30] qcow2: Add subcluster support to check_refcounts_l2() Alberto Garcia
2020-04-22 12:06 ` Vladimir Sementsov-Ogievskiy
2020-04-23 15:45 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 22/30] qcow2: Fix offset calculation in handle_dependencies() Alberto Garcia
2020-04-22 12:38 ` Vladimir Sementsov-Ogievskiy
2020-04-23 15:50 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 23/30] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2() Alberto Garcia
2020-04-24 19:39 ` Eric Blake
2020-04-27 13:17 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 24/30] qcow2: Clear the L2 bitmap when allocating a compressed cluster Alberto Garcia
2020-04-24 17:02 ` Alberto Garcia
2020-04-24 17:11 ` Eric Blake
2020-04-24 17:21 ` Alberto Garcia
2020-04-24 17:44 ` Eric Blake
2020-04-24 17:56 ` Alberto Garcia
2020-04-24 18:25 ` Vladimir Sementsov-Ogievskiy
2020-04-24 18:37 ` Alberto Garcia
2020-04-24 18:47 ` Eric Blake
2020-04-27 7:49 ` Max Reitz
2020-04-27 18:12 ` Alberto Garcia
2020-04-24 18:15 ` Vladimir Sementsov-Ogievskiy
2020-04-24 18:41 ` Alberto Garcia
2020-04-25 6:38 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 25/30] qcow2: Add subcluster support to handle_alloc_space() Alberto Garcia
2020-04-27 11:54 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 26/30] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only Alberto Garcia
2020-04-27 11:59 ` Vladimir Sementsov-Ogievskiy
2020-03-17 18:16 ` [PATCH v4 27/30] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters Alberto Garcia
2020-04-09 10:27 ` Max Reitz
2020-04-10 16:42 ` Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 28/30] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit Alberto Garcia
2020-04-09 14:49 ` Eric Blake
2020-03-17 18:16 ` [PATCH v4 29/30] qcow2: Add subcluster support to qcow2_measure() Alberto Garcia
2020-03-17 18:16 ` [PATCH v4 30/30] iotests: Add tests for qcow2 images with extended L2 entries Alberto Garcia
2020-04-09 12:22 ` Max Reitz
2020-04-13 17:16 ` Alberto Garcia
2020-04-14 10:14 ` Max Reitz
2020-04-21 5:06 ` [PATCH v4 00/30] Add subcluster allocation to qcow2 Derek Su
2020-04-21 10:35 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e6c2a1c-e2b5-609a-72fc-144de466345b@redhat.com \
--to=eblake@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.