From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23314C433E0 for ; Thu, 4 Feb 2021 12:08:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C06E364F48 for ; Thu, 4 Feb 2021 12:08:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C06E364F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EAF46E9F5; Thu, 4 Feb 2021 12:08:20 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0D126E9F5 for ; Thu, 4 Feb 2021 12:08:19 +0000 (UTC) IronPort-SDR: zOnrWRvnN24BqQ6AkmV5KMn4w4yICRcMxVFZFSFDnUqKdkbgI0oUb7pSlBR5Bysslct0ccKAAp YOORjwPQk2Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="177720718" X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="177720718" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 04:08:18 -0800 IronPort-SDR: 8HgN3mu443IPcpkj+zQW9KpgR3/gM3LQLCjLB8uBCxGb2qoH0eEO6KixCRIIAnUbkRBRqeEZ6R BYizplFD+LoA== X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="393132807" Received: from acanalx-mobl.ger.corp.intel.com (HELO [10.249.32.114]) ([10.249.32.114]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 04:08:17 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210201085715.27435-1-chris@chris-wilson.co.uk> <20210201085715.27435-20-chris@chris-wilson.co.uk> <45740fad-297d-03e7-7de4-3a171376c0c2@linux.intel.com> <161243750979.1383.2504816924204435385@build.alporthouse.com> <161243981120.4856.4115126682547775710@build.alporthouse.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1e6d0ce0-5325-72a6-ec79-fc667d60126f@linux.intel.com> Date: Thu, 4 Feb 2021 12:08:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <161243981120.4856.4115126682547775710@build.alporthouse.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 20/57] drm/i915: Wrap access to intel_engine.active X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 04/02/2021 11:56, Chris Wilson wrote: > Quoting Chris Wilson (2021-02-04 11:18:29) >> Quoting Tvrtko Ursulin (2021-02-04 11:07:07) >>> >>> >>> On 01/02/2021 08:56, Chris Wilson wrote: >>>> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>>> index b56e321ef003..280d84c4e4b7 100644 >>>> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>>> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>>> @@ -293,6 +293,7 @@ static int virtual_prio(const struct intel_engine_execlists *el) >>>> static bool need_preempt(const struct intel_engine_cs *engine, >>>> const struct i915_request *rq) >>>> { >>>> + const struct i915_sched *se = &engine->active; >>> >>> There's only two instances in this patch which do not use >>> intel_engine_get_scheduler. Intended? >> >> They were the ones I earmarked for being replaced by the scheduler >> object being passed down. Having down that I can do the replacement here >> and remove the conflicts with the final result later. > > The catch here was the const. We can't make the getter take a const* > at this point, so I left it as &engine->active to not have to remove the > constness. It's fine, I'm mostly interested in the goodness of the end result. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx