From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3958C47096 for ; Thu, 3 Jun 2021 08:47:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72206611C9 for ; Thu, 3 Jun 2021 08:47:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72206611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13C8C6F450; Thu, 3 Jun 2021 08:47:22 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92F486F450 for ; Thu, 3 Jun 2021 08:47:19 +0000 (UTC) IronPort-SDR: htmAHbh5OzB3Re4HzlvaYQN/TGwrhBWW5yCmH6So9sWh646NGqCy3czt3Crb/9Y12Tqz2f+G5n a32P2FBOJdXg== X-IronPort-AV: E=McAfee;i="6200,9189,10003"; a="289629287" X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="289629287" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 01:47:09 -0700 IronPort-SDR: NsdVrmkwqAZALIAoo0KC4kmZPZRFqS5og8XKjzS8IVlmvkSpB3THT0oxefYaWjM5nkFJ07iAni 8bR3zKK8sH5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="400399187" Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by orsmga006.jf.intel.com with ESMTP; 03 Jun 2021 01:47:09 -0700 Received: from bgsmsx602.gar.corp.intel.com (10.109.78.81) by irsmsx601.ger.corp.intel.com (163.33.146.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 3 Jun 2021 09:47:07 +0100 Received: from bgsmsx602.gar.corp.intel.com ([10.109.78.81]) by BGSMSX602.gar.corp.intel.com ([10.109.78.81]) with mapi id 15.01.2242.008; Thu, 3 Jun 2021 14:17:05 +0530 From: "Kulkarni, Vandita" To: "Saarinen, Jani" , "intel-gfx@lists.freedesktop.org" Thread-Topic: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable Thread-Index: AQHXWEerkFFEh6R0kUCekRWWk2uIg6sBidmAgABuaXA= Date: Thu, 3 Jun 2021 08:47:05 +0000 Message-ID: <1e70025aa4e04a5396721ad4e7609340@intel.com> References: <20210603065356.15435-1-vandita.kulkarni@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.223.10.1] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Saarinen, Jani > Sent: Thursday, June 3, 2021 1:07 PM > To: Kulkarni, Vandita ; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: RE: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in > DSC disable > = > Hi, > > -----Original Message----- > > From: Intel-gfx On Behalf Of > > Vandita Kulkarni > > Sent: torstai 3. kes=E4kuuta 2021 9.54 > > To: intel-gfx@lists.freedesktop.org > > Cc: Nikula, Jani > > Subject: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in > > DSC disable > > > > There can be a chance that pre os has enabled DSC and driver's compute > > config would not need dsc to be enabled, in such case if we check on > > compute config's compression state to disable, we might end up in state > mismatch. > = > I assume this fixes real gitlab issue too? Okay, will add the tag = Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3537 Thanks, Vandita > = > > > > Signed-off-by: Vandita Kulkarni > > --- > > drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c > > b/drivers/gpu/drm/i915/display/intel_vdsc.c > > index 19cd9531c115..b05a96011d93 100644 > > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c > > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c > > @@ -1161,10 +1161,6 @@ void intel_dsc_disable(const struct > > intel_crtc_state > > *old_crtc_state) > > struct intel_crtc *crtc =3D to_intel_crtc(old_crtc_state->uapi.crtc); > > struct drm_i915_private *dev_priv =3D to_i915(crtc->base.dev); > > > > - if (!(old_crtc_state->dsc.compression_enable && > > - old_crtc_state->bigjoiner)) > > - return; > > - > > intel_de_write(dev_priv, dss_ctl1_reg(old_crtc_state), 0); > > intel_de_write(dev_priv, dss_ctl2_reg(old_crtc_state), 0); } > > -- > > 2.21.0.5.gaeb582a > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx