From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpAdU-0006Zt-02 for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpAdK-0005TD-Cx for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57130) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpAdK-0005SM-6r for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 066B38765D for ; Tue, 5 Sep 2017 09:59:01 +0000 (UTC) References: <20170901180340.30009-1-eblake@redhat.com> <20170901180340.30009-3-eblake@redhat.com> <09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com> <874lshzd2l.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: <1e7502ef-2798-54b1-b3dc-dec9d6fee6c0@redhat.com> Date: Tue, 5 Sep 2017 11:58:56 +0200 MIME-Version: 1.0 In-Reply-To: <874lshzd2l.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Eric Blake , qemu-devel@nongnu.org, pbonzini@redhat.com, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= On 05.09.2017 11:53, Markus Armbruster wrote: > Thomas Huth writes: >=20 >> On 01.09.2017 20:03, Eric Blake wrote: >>> It doesn't matter if things are unsorted, but finding stuff in a list >>> is easier when it is sorted. (Sorted under LC_ALL=3DC rules, rather = than >>> en_US.UTF-8). >>> >>> Signed-off-by: Eric Blake >>> --- >>> tests/.gitignore | 30 +++++++++++++++--------------- >>> 1 file changed, 15 insertions(+), 15 deletions(-) >> >> Reviewed-by: Thomas Huth >> >> BTW, did you note the patch "build-sys: generate tests/.gitignore" fro= m >> Marc-Andr=C3=A9 ? Maybe the list can be generated automatically, too..= . >> >>> diff --git a/tests/.gitignore b/tests/.gitignore >>> index 64ecd6683b..8d35a58751 100644 >>> --- a/tests/.gitignore >>> +++ b/tests/.gitignore >>> @@ -1,25 +1,27 @@ >>> +*-test >> >> ... but looking at this wildcard, I wonder if we just named most of ou= r >> tests in a bad way. If we name the files something-test instead of >> test-something, we maybe do not need the automatic generation from >> Marc-Andr=C3=A9 (which is kind of ugly because it writes to the source >> directory - and this should not happen when doing out of tree builds). >> >> So what do you think about renaming our tests, so that the above >> wildcard applies instead? >=20 > Apropos naming tests: there's an (unspoken) convention to name unit > tests check-FOO or test-FOO and tests using libqtest FOO-test, but it's > not really honored anymore, probably because people creating tests > didn't know about it. Maybe it would help to have an entry for libqtest in MAINTAINERS with a wildcard for tests/*-test.c ? Then we would have at least some kind of documentation for this... (BTW: Any volunteers here for such a maintainer job? ;-)) Thomas