From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"nikolay@nvidia.com" <nikolay@nvidia.com>
Subject: Re: [PATCH net-next v2 0/2] net: dsa: b53: Configure VLANs while not filtering
Date: Wed, 23 Sep 2020 14:39:13 -0700 [thread overview]
Message-ID: <1e7bffdf-cb4d-5a31-aef7-4595ba3a8b64@gmail.com> (raw)
In-Reply-To: <20200923213055.t7hqzuar2nivatzz@skbuf>
On 9/23/20 2:30 PM, Vladimir Oltean wrote:
> On Wed, Sep 23, 2020 at 11:51:48PM +0300, Vladimir Oltean wrote:
>> On Wed, Sep 23, 2020 at 01:49:54PM -0700, Florian Fainelli wrote:
>>> On 9/23/20 1:45 PM, Florian Fainelli wrote:
>>>
>>> David, Jakub, there is an unnecessary header inclusion in
>>> net/dsa/tag_brcm.c in the second patch and the description at the end of
>>> the commit was not updated, let me send a v3 right away.
>>> --
>>> Florian
>>
>> Wait a few minutes, I don't think anybody has had a chance to look at it..
>
> So I studied a little bit the situation with the MAC header pointer in
> the second patch, especially since there are 2 call paths, but it's ok,
> since at that point the skb->data points to its final position already,
> then the MAC header is naturally 14 bytes behind.
> I've been testing with the ocelot driver which resets the MAC header
> manually, that explains why I missed that. Anyway, if there are no other
> comments I think you can resend.
Yes, I was looking at tag_ocelot.c as well for a reference. At some
point I was considering adding a version that let the tagging driver
specifying the struct vlan_ethhdr reference directly since the tagging
driver knows, but using skb_set_mac_header() works equally well in a
more portable way even.
Thanks, v3 on its way with your A-b tag.
--
Florian
prev parent reply other threads:[~2020-09-23 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 20:45 [PATCH net-next v2 0/2] net: dsa: b53: Configure VLANs while not filtering Florian Fainelli
2020-09-23 20:45 ` [PATCH net-next v2 1/2] net: dsa: untag the bridge pvid from rx skbs Florian Fainelli
2020-09-23 20:45 ` [PATCH net-next v2 2/2] net: dsa: b53: Configure VLANs while not filtering Florian Fainelli
2020-09-23 21:23 ` Vladimir Oltean
2020-09-23 20:49 ` [PATCH net-next v2 0/2] " Florian Fainelli
2020-09-23 20:51 ` Vladimir Oltean
2020-09-23 21:30 ` Vladimir Oltean
2020-09-23 21:39 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e7bffdf-cb4d-5a31-aef7-4595ba3a8b64@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.