All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "David S . Miller" <davem@davemloft.net>
Cc: Andreas Larsson <andreas@gaisler.com>,
	sparclinux@vger.kernel.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sparc: Unbreak the build
Date: Thu, 29 Sep 2022 10:32:41 -0700	[thread overview]
Message-ID: <1e7f849c-a951-d1bf-7ee8-b4c9088b5141@acm.org> (raw)
In-Reply-To: <22d99fab-bfa2-5001-8ef1-a4900056f0c4@gaisler.com>

On 9/9/22 08:28, Andreas Larsson wrote:
> On 2022-08-30 22:58, Bart Van Assche wrote:
>> Fix the following build errors:
>>
>> arch/sparc/mm/srmmu.c: In function ‘smp_flush_page_for_dma’:
>> arch/sparc/mm/srmmu.c:1639:13: error: cast between incompatible function types from ‘void (*)(long unsigned int)’ to ‘void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)’ [-Werror=cast-function-type]
>>   1639 |         xc1((smpfunc_t) local_ops->page_for_dma, page);
>>        |             ^
>> arch/sparc/mm/srmmu.c: In function ‘smp_flush_cache_mm’:
>> arch/sparc/mm/srmmu.c:1662:29: error: cast between incompatible function types from ‘void (*)(struct mm_struct *)’ to ‘void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)’ [-Werror=cast-function-type]
>>   1662 |                         xc1((smpfunc_t) local_ops->cache_mm, (unsigned long) mm);
>>        |
>> [ ... ]
>>
>> Compile-tested only.
>>
>> Fixes: 552a23a0e5d0 ("Makefile: Enable -Wcast-function-type")
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> 
> Tested-by: Andreas Larsson <andreas@gaisler.com>

Hi Dave,

Did I send this patch to the right maintainer? I sent this patch to you
because I found the following in the MAINTAINERS file:

SPARC + UltraSPARC (sparc/sparc64)
M:      "David S. Miller" <davem@davemloft.net>
L:      sparclinux@vger.kernel.org
S:      Maintained
Q:      http://patchwork.ozlabs.org/project/sparclinux/list/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc.git
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git
F:      arch/sparc/
F:      drivers/sbus/

In case this patch wouldn't be in your inbox anymore, it is available here:
https://lore.kernel.org/all/20220830205854.1918026-1-bvanassche@acm.org/

Thanks,

Bart.



  reply	other threads:[~2022-09-29 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 20:58 [PATCH] sparc: Unbreak the build Bart Van Assche
2022-09-09 15:28 ` Andreas Larsson
2022-09-29 17:32   ` Bart Van Assche [this message]
2022-09-30  2:20 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e7f849c-a951-d1bf-7ee8-b4c9088b5141@acm.org \
    --to=bvanassche@acm.org \
    --cc=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=keescook@chromium.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.