All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
	stefan@datenfreihafen.org, torvalds@linuxfoundation.org
Subject: Re: [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars
Date: Tue, 03 May 2022 10:31:22 +0300	[thread overview]
Message-ID: <1e81c3d8046c4dba4fdd0732ff63107d2558e6d2.camel@linux.intel.com> (raw)
In-Reply-To: <20220428030534.3220410-2-aahringo@redhat.com>

On Wed, 2022-04-27 at 23:05 -0400, Alexander Aring wrote:
> The keyword const makes no sense for scalar types inside the
> lowpan_nhc
> structure. Most compilers will ignore it so we remove the keyword
> from
> the scalar types.
> 
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>  net/6lowpan/nhc.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
> index 67951c40734b..2ac7da388c4d 100644
> --- a/net/6lowpan/nhc.h
> +++ b/net/6lowpan/nhc.h
> @@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
>  struct lowpan_nhc {
>         struct rb_node  node;
>         const char      *name;
> -       const u8        nexthdr;
> -       const size_t    nexthdrlen;
> +       u8              nexthdr;
> +       size_t          nexthdrlen;
>         u8              *id;
>         u8              *idmask;
> -       const size_t    idlen;
> +       size_t          idlen;
>  
>         void            (*idsetup)(struct lowpan_nhc *nhc);
>         int             (*uncompress)(struct sk_buff *skb, size_t
> needed);


Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>


Cheers,
Jukka


  parent reply	other threads:[~2022-05-03  7:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  3:05 [PATCH bluetooth-next 0/3] net: 6lowpan: simplify lookup by nhc id Alexander Aring
2022-04-28  3:05 ` [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars Alexander Aring
2022-04-28  3:47   ` net: 6lowpan: simplify lookup by nhc id bluez.test.bot
2022-05-02 19:36   ` [PATCH bluetooth-next 1/3] net: 6lowpan: remove const from scalars Stefan Schmidt
2022-05-03  7:31   ` Jukka Rissanen [this message]
2022-04-28  3:05 ` [PATCH bluetooth-next 2/3] net: 6lowpan: use array for find nhc id Alexander Aring
2022-05-02 19:37   ` Stefan Schmidt
2022-05-03  7:32   ` Jukka Rissanen
2022-04-28  3:05 ` [PATCH bluetooth-next 3/3] net: 6lowpan: constify lowpan_nhc structures Alexander Aring
2022-05-02 19:37   ` Stefan Schmidt
2022-05-03  7:32   ` Jukka Rissanen
2022-06-01 20:28 ` [PATCH bluetooth-next 0/3] net: 6lowpan: simplify lookup by nhc id Stefan Schmidt
2022-06-01 21:48   ` Luiz Augusto von Dentz
2022-06-01 21:56     ` Stefan Schmidt
2022-06-01 21:58       ` Luiz Augusto von Dentz
2022-06-02 15:27         ` Marcel Holtmann
2022-06-02 17:38           ` Stefan Schmidt
2022-06-02 17:41 ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e81c3d8046c4dba4fdd0732ff63107d2558e6d2.camel@linux.intel.com \
    --to=jukka.rissanen@linux.intel.com \
    --cc=aahringo@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.