All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libgeos: use specific bug instead of BR2_nios2 to disable package
Date: Mon, 26 Apr 2021 21:51:30 +0200	[thread overview]
Message-ID: <1e867adb-5f08-de1e-f187-cc04a2f28d12@mind.be> (raw)
In-Reply-To: <20210317163459.1916948-2-giulio.benetti@benettiengineering.com>



On 17/03/2021 17:34, Giulio Benetti wrote:
> Let's use the _BUG_ form for disabling this package instead of BR2_nios2
> architecture as we already use it for other packages.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Applied to master, thanks. I made the following changes:

     - put 27597 after 21464 instead of before it;
     - propagate dependency to postgis;
     - mention the bugs in the comments.

postgis didn't exist yet at the time so that's no surpise... The rest is nitpicking.


 Regards,
 Arnout

> ---
>  package/libgeos/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
> index bbcafe7740..8759d2011e 100644
> --- a/package/libgeos/Config.in
> +++ b/package/libgeos/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBGEOS
>  	bool "libgeos"
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
> -	depends on !BR2_nios2
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>  	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>  	help
>  	  GEOS (Geometry Engine - Open Source) is a C++ port of the
> @@ -14,5 +14,6 @@ config BR2_PACKAGE_LIBGEOS
>  	  https://trac.osgeo.org/geos
>  
>  comment "libgeos needs a toolchain w/ C++, wchar"
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> -	depends on !BR2_nios2 || !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> +		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 || \
> +		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
> 

  reply	other threads:[~2021-04-26 19:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 17:52 [Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464 Giulio Benetti
2021-03-14 22:32 ` Thomas Petazzoni
2021-03-17 16:34   ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Giulio Benetti
2021-03-17 16:34     ` [Buildroot] [PATCH 2/2] package/libgeos: use specific bug instead of BR2_nios2 to disable package Giulio Benetti
2021-04-26 19:51       ` Arnout Vandecappelle [this message]
2021-04-26 21:14         ` Peter Korsgaard
2021-04-26 19:50     ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Arnout Vandecappelle
2021-04-26 21:14       ` Peter Korsgaard
2021-03-21 19:34 ` [Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e867adb-5f08-de1e-f187-cc04a2f28d12@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.