From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751056AbcISOW6 (ORCPT ); Mon, 19 Sep 2016 10:22:58 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:35368 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755443AbcISOWe (ORCPT ); Mon, 19 Sep 2016 10:22:34 -0400 Subject: Re: linux-next: build failure after merge of the block tree To: Stephen Rothwell References: <20160919161834.08302d33@canb.auug.org.au> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig From: Jens Axboe Message-ID: <1e8697fe-a8e5-a5b6-25db-c4676d36efdf@kernel.dk> Date: Mon, 19 Sep 2016 08:22:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160919161834.08302d33@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2016 12:18 AM, Stephen Rothwell wrote: > Hi Jens, > > After merging the block tree, today's linux-next build (powerpc > allnoconfig) failed like this: > > In file included from block/blk-mq-pci.c:13:0: > include/linux/blk-mq.h:57:18: error: field 'kobj' has incomplete type > struct kobject kobj; > ^ > include/linux/blk-mq.h:121:2: error: unknown type name 'softirq_done_fn' > softirq_done_fn *complete; > ^ > include/linux/blk-mq.h: In function 'blk_mq_rq_from_pdu': > include/linux/blk-mq.h:253:22: error: invalid application of 'sizeof' to incomplete type 'struct request' > return pdu - sizeof(struct request); > ^ > include/linux/blk-mq.h: In function 'blk_mq_rq_to_pdu': > include/linux/blk-mq.h:257:2: error: invalid use of undefined type 'struct request' > return rq + 1; > ^ > > Caused by commit > > 973c4e372c8f ("blk-mq: provide a default queue mapping for PCI device") > > include/linux/blk-mq.h does not include all the headers files that it > depends on, and building block/blk-mq-pci.c should depend on CONFIG_BLOCK. > > I applied this fix patch (the block/blk-mq-pci.c may not be becessary): Added, thanks Stephen. -- Jens Axboe