From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F95BC433E0 for ; Thu, 28 Jan 2021 08:19:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 052FC64DDB for ; Thu, 28 Jan 2021 08:19:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 052FC64DDB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.76786.138662 (Exim 4.92) (envelope-from ) id 1l52Wn-0006I2-Up; Thu, 28 Jan 2021 08:19:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 76786.138662; Thu, 28 Jan 2021 08:19:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l52Wn-0006Hv-Qx; Thu, 28 Jan 2021 08:19:45 +0000 Received: by outflank-mailman (input) for mailman id 76786; Thu, 28 Jan 2021 08:19:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l52Wm-0006Hq-Ey for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 08:19:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9103fa1b-b3a6-40a8-aa70-633eba947429; Thu, 28 Jan 2021 08:19:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6003EAEDD; Thu, 28 Jan 2021 08:19:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9103fa1b-b3a6-40a8-aa70-633eba947429 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611821982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXZXZQj3k+rInBtzXPh8TFlU/zNFtpXxR/sUxa5byA4=; b=c1DjcFcpsUf0WssLm7Ptl3qQaxvaefsxyGrQohnW2afTVs7q3Gxeamrz7PM67A9fYauiMJ 2/CeM4KhhPI19fdei6TcZOJwO1/QaY8j4tp1f2F3E7BVIBhZaygnrW/f5mBX9XtI4if3tr v2j/w0zgpBDtjtbUoPL5FwKY8HqsCzs= Subject: Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common To: Oleksandr Cc: Oleksandr Tyshchenko , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Jun Nakajima , Kevin Tian , Tim Deegan , Julien Grall , xen-devel@lists.xenproject.org References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-5-git-send-email-olekstysh@gmail.com> <01b122dd-37c9-d429-b060-adea9e7cae8b@suse.com> From: Jan Beulich Message-ID: <1eb1247b-f455-65c8-b91c-3e8bc05186a1@suse.com> Date: Thu, 28 Jan 2021 09:06:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 27.01.2021 21:14, Oleksandr wrote: > On 27.01.21 18:58, Jan Beulich wrote: >> On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -92,6 +92,7 @@ config PV_LINEAR_PT >>> >>> config HVM >>> def_bool !PV_SHIM_EXCLUSIVE >>> + select IOREQ_SERVER >>> prompt "HVM support" >>> ---help--- >> ... the addition moved below the prompt line (could probably >> be taken care of while committing, if no other need for a v6 >> arises). > > V6 is planned anyway, so will do, but ... > > >> >> (Personally I think this should be >> >> config HVM >> bool "HVM support" >> default !PV_SHIM_EXCLUSIVE > > ... def_bool is changed to default by intention or this is a typo? No, it's not a typo. "def_bool" is just a shorthand for "bool" and "default", which is useful when there's no prompt, but gets abused (in my view at least) in a number of other cases. But as said ... >> anyway, but that's nothing you need to care about.) ... here. >>> --- /dev/null >>> +++ b/xen/include/asm-x86/ioreq.h >>> @@ -0,0 +1,37 @@ >>> +/* >>> + * ioreq.h: Hardware virtual machine assist interface definitions. >>> + * >>> + * This is a wrapper which purpose is to not include arch HVM specific header >>> + * from the common code. >>> + * >>> + * Copyright (c) 2016 Citrix Systems Inc. >>> + * >>> + * This program is free software; you can redistribute it and/or modify it >>> + * under the terms and conditions of the GNU General Public License, >>> + * version 2, as published by the Free Software Foundation. >>> + * >>> + * This program is distributed in the hope it will be useful, but WITHOUT >>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>> + * more details. >>> + * >>> + * You should have received a copy of the GNU General Public License along with >>> + * this program; If not, see . >>> + */ >>> + >>> +#ifndef __ASM_X86_IOREQ_H__ >>> +#define __ASM_X86_IOREQ_H__ >>> + >>> +#include >>> + >>> +#endif /* __ASM_X86_IOREQ_H__ */ >> Not necessarily for taking care of right away, I think in the >> longer run this wants wrapping by #ifdef CONFIG_HVM, such that >> in !HVM builds the dependency on the "chained" header goes >> away (reducing the amount of rebuilding in incremental builds). > > I don't mind wrapping it right away. Well, if that doesn't break the !HVM build, I'd of course appreciate it. I'd expect fallout, though. Jan