From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B52CFC77B73 for ; Sun, 4 Jun 2023 11:59:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5mN5-0004F0-9s; Sun, 04 Jun 2023 07:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mMz-0004D7-7W for qemu-devel@nongnu.org; Sun, 04 Jun 2023 07:58:02 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mMx-00086r-Kn for qemu-devel@nongnu.org; Sun, 04 Jun 2023 07:58:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Reply-To: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+Yogv6SWJDS+fDTpCYXBeQsQj+lVQlGO0RL85aK/gmg=; b=ZMb2ka9XSFruur54pKQ1INcbi6 Q5mzNbBaBXLYkS6l9xIrmtt9imX/9BOWiY7IzaOdLwxNe+Oexoi+P5n81xQFgUYWGw0kqcOV4inY2 4hX3vBJ1VjQBQ+Z812fhxEGCTmPdQM9xxI2us1nwlLcZduAypBeemBzDuB2y3TO84vdU=; Message-ID: <1eb6fdf8-c691-3608-e98c-0f95e5b3a5c0@rev.ng> Date: Sun, 4 Jun 2023 13:57:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v3 27/48] tcg: Move TLB_FLAGS_MASK check out of get_alignment_bits Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20230531040330.8950-1-richard.henderson@linaro.org> <20230531040330.8950-28-richard.henderson@linaro.org> Organization: rev.ng In-Reply-To: <20230531040330.8950-28-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: anjo@rev.ng X-ACL-Warn: , Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/31/23 06:03, Richard Henderson wrote: > The replacement isn't ideal, as the raw count of bits > is not easily synced with exec/cpu-all.h, but it does > remove from tcg.h the target dependency on TARGET_PAGE_BITS_MIN > which is built into TLB_FLAGS_MASK. > > Signed-off-by: Richard Henderson > --- > include/exec/cpu-all.h | 3 +++ > include/tcg/tcg.h | 4 ---- > tcg/tcg-op-ldst.c | 18 ++++++++++++++++-- > 3 files changed, 19 insertions(+), 6 deletions(-) Reviewed-by: Anton Johansson