From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21344C433ED for ; Thu, 22 Apr 2021 05:20:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C734D60241 for ; Thu, 22 Apr 2021 05:20:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C734D60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZRl5-0004dV-Sx for qemu-devel@archiver.kernel.org; Thu, 22 Apr 2021 01:20:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZRjR-00039l-Fx for qemu-devel@nongnu.org; Thu, 22 Apr 2021 01:18:29 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:33410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZRjO-0000aO-Aj for qemu-devel@nongnu.org; Thu, 22 Apr 2021 01:18:29 -0400 Received: by mail-pj1-x1035.google.com with SMTP id kb13-20020a17090ae7cdb02901503d67f0beso2121423pjb.0 for ; Wed, 21 Apr 2021 22:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aIUBvsOjX628UahTexFBv1fZMUdBiMYMLfP6LjIZTlc=; b=DgwJaFmr2IeXCbBVHEXQAz8BFTeKDULh5K92uFmfjj+SCoiGnjEPZoaxPaEZPVegxg AYiISMPhX6Z0IIP53X7JpRrDwUrekIeomP5LKNKmOrXHUwQn6HNt17+/pR8CNDxRXRnF fVgWoFuXXIavZb7GOMmEjfzmpknWc6EvE10HOQCp7B0UKD5A5MoQ9OwKBIuP3HAuOsuA RSJzZT0H/J4c26keVy648f/mt4cmGuoNNP7/HGsbSY91v/bjqLsEz1NiErtm8LKCaZhp jp1gg3n0zop79+tXlH5SEW/uXWP0pNsRVxg/l507ElLlgeNo7uqby5OOL35GnJy3GRSd xIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aIUBvsOjX628UahTexFBv1fZMUdBiMYMLfP6LjIZTlc=; b=m9j41OpVkbY7+MAQ4TqAR2inX5aoi/euJkM5qbD//4HunxhimASFgicoiqQ85LVGZw SbDv2ZyBE+L5mCmtYCJQKOnrUpUR26yINi4ZobT2q1Qr9XFUT5+PUYMr06IP3oXHCBgF g7b6TMIZwno9dIDPZ+S3vzC8BFMltdX5dFNXTY2uB3IST9zaY9lW6emLaf6sv9ofxF3W 47QqbL5LRdShYQN79B9BA7amKE5XSJm5mZfEMJyvoJueSFuG804oNz368+JhnhDH5dEE ydF/obvS4OPitFJgzy00ULT67f0Q5CIgLCjoqM/MU2EzEnDa+nNhOmT020cp7Tv0mf/c ei7A== X-Gm-Message-State: AOAM532onTA8EALkUkqhTx6NUWy9ltX0Gl+5+i99qAbM2iFBnRd/heIY Ux4liOu2Xh5b/qEb+txV3G6vbQ2rbKFanA== X-Google-Smtp-Source: ABdhPJztW93cXflo/BQyFgInXbtXoz9Xv32prdkBKIqKi2faQAxPiFHhOfbD6yoW+faWCQqQbGWOfg== X-Received: by 2002:a17:90a:bd8c:: with SMTP id z12mr2029328pjr.83.1619068704670; Wed, 21 Apr 2021 22:18:24 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id 23sm941915pgo.53.2021.04.21.22.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 22:18:24 -0700 (PDT) Subject: Re: [PATCH] tcg/ppc: Fix building with Clang To: Peter Maydell , Brad Smith References: From: Richard Henderson Message-ID: <1ebc5a66-2763-1379-24e0-774739f2edbe@linaro.org> Date: Wed, 21 Apr 2021 22:18:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/21/21 2:03 AM, Peter Maydell wrote: >> +/* Clang does not define _CALL_* */ >> +#if defined(__clang__) && defined(__ELF__) && !defined(_CALL_SYSV) >> +#define _CALL_SYSV 1 >> +#endif > > This is trying to identify the calling convention used by the OS. > That's not purely compiler specific (ie it is not the case that > all ELF output from clang is definitely using the calling convention > that _CALL_SYSV implies), so settign it purely based on "this is clang > producing ELF files" doesn't seem right. We can get pretty close though. There are three ppc32 calling conventions: AIX, DARWIN, SYSV. The _CALL_ELF symbol is a 64-bit thing, and AIX itself doesn't use ELF. > I guess if clang doesn't reliably tell us the calling convention > maybe we should scrap the use of _CALL_SYSV and _CALL_ELF and > use the host OS defines to guess the calling convention ? No, I'd rely on _CALL_* first, and only fall back to something else if they're not present. I'm thinking something like #if !defined(_CALL_SYSV) && \ !defined(_CALL_DARWIN) && \ !defined(_CALL_AIX) && \ !defined(_CALL_ELF) # if defined(__APPLE__) # define _CALL_DARWIN # elif defined(__ELF__) && TCG_TARGET_REG_BITS == 32 # define _CALL_SYSV # else # error "Unknown ABI" # endif #endif r~