From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8711DC433EF for ; Thu, 27 Jan 2022 11:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239693AbiA0LLf (ORCPT ); Thu, 27 Jan 2022 06:11:35 -0500 Received: from foss.arm.com ([217.140.110.172]:54800 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiA0LLe (ORCPT ); Thu, 27 Jan 2022 06:11:34 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48EDA1FB; Thu, 27 Jan 2022 03:11:34 -0800 (PST) Received: from [10.57.39.22] (unknown [10.57.39.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9526B3F7D8; Thu, 27 Jan 2022 03:11:31 -0800 (PST) Message-ID: <1ec258b8-c6dd-aa0f-8583-2d7667314be9@arm.com> Date: Thu, 27 Jan 2022 11:11:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Andrew Kilroy Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics To: Andi Kleen , John Garry , Ian Rogers Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org References: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com> <20211214184240.24215-1-andrew.kilroy@arm.com> <20211214184240.24215-2-andrew.kilroy@arm.com> <5a2e29c1-2c7e-1b55-9192-62060309aeca@arm.com> <12e0deef-08db-445f-4958-bcd5c3e10367@linux.intel.com> Content-Language: en-US In-Reply-To: <12e0deef-08db-445f-4958-bcd5c3e10367@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andi, On 21/12/2021 14:03, Andi Kleen wrote: > > On 12/20/2021 9:21 AM, Andrew Kilroy wrote: >> >> On 15/12/2021 10:52, John Garry wrote: >>> Hi Andrew, >>> >>>>>   const struct pmu_event *metricgroup__find_metric(const char *metric, >>>>>                                                   const struct >>>>> pmu_events_map *map); >>>>>   int metricgroup__parse_groups_test(struct evlist *evlist, >>>>> diff --git a/tools/perf/util/topdown.c b/tools/perf/util/topdown.c >>>>> index 1081b20f9891..57c0c5f2c6bd 100644 >>>>> --- a/tools/perf/util/topdown.c >>>>> +++ b/tools/perf/util/topdown.c >>>>> @@ -56,3 +56,9 @@ __weak bool arch_topdown_sample_read(struct evsel >>>>> *leader __maybe_unused) >>>>>   { >>>>>          return false; >>>>>   } >>>>> + >>>>> +__weak bool arch_topdown_use_json_metrics(void) >>>>> +{ >>> >>> AFAICS, only x86 supports topdown today and that is because they have >>> special kernel topdown events exposed for the kernel CPU PMU driver. >>> So other architectures - not only arm - would need rely on >>> metricgroups for topdown support. So let's make this generic for all >>> archs. >>> >>>> I like this extension! I've ranted in the past about weak symbols >>>> breaking with archives due to lazy loading [1]. In this case >>>> tools/perf/arch/arm64/util/topdown.c has no other symbols within it >>>> and so the weak symbol has an extra chance of being linked >>>> incorrectly. We could add a new command line of --topdown-json to >>>> avoid this, but there seems little difference in doing this over just >>>> doing '-M TopDownL1'. >>> >>> >>>> Is it possible to use the json metric approach >>>> for when the CPU version fails? >>> >>> I think that's a good idea. >>> >> >> >> While looking into using the json metrics approach as a fallback to >> the original, I noticed  there are two json metricgroups 'TopdownL1' >> and 'TopDownL1' (note the case difference) on x86. Not sure if the >> case difference is intentional. >> >> On skylake, 'TopdownL1' contains the four json metrics Retiring, >> Bad_Speculation, Frontend_Bound, and Backend_Bound.  'TopDownL1' has >> 'SLOTS', 'CoreIPC', 'CoreIPC_SMT', 'Instructions'.  I think its a >> similar situation on other x86 chips. > > > There's also SMT metrics. > > > We don't want to include CoreIPC etc. by default because it would cause > multiplexing in common situations. > >> >> The search for those metrics by metricgroup name is case insensitive, >> so it's picking up all 8 metrics when using the lookup string >> 'TopDownL1'.  So the extra 'SLOTS', 'CoreIPC', 'CoreIPC_SMT', >> 'Instructions' metrics would be printed as well. >> >> Not sure what the significance of the case difference might be. >> >> Should we use a different string than 'TopDownL1' as the metric group >> name to search for? > > > We should probably fix the case (or just make the match case insensitive) > > Can we just keep x86 at using the kernel metrics? On Skylake and earlier > it needs different formulas and other options depending whether SMT is > on or off, so it's not straight forward to express it as json directly. > I posted a v2 of these patches which keeps x86 only using the kernel metrics. https://lore.kernel.org/linux-perf-users/20220111150749.13365-1-andrew.kilroy@arm.com/ Would be good to get your feedback, Thanks Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82CBDC433EF for ; Thu, 27 Jan 2022 11:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XPCkBzbMcIq8YlY5zoIbKgCH7xw6hs9WFa2Xqekkhng=; b=VfdqnbXbUua8MD yIaB9bdGJR5KIqCxfkBD84qNQ7++bwRQAAOAIjZkdGoA4SUquDff0nDb1HtebbQlVanUM6kUzCvPU 277lSnVklmiXP61fGSVy5thavDSm4ByVU0/hNmKTCd5TKst4FPcVVmRYtOH8TVovkOQDQnNAEjPO7 VXS4gbmsMs9QGgKfUPxjB5tNDH/waYr3+AE6qK1KH99LrV3YyC/20cIBTPNtfGskH4IvohYx9kZOm QtppjSPi0TQzIPQOK+QTprfpfe93I2XCiHi7vNJjQmJLOS5+7DQ1KHudT155NXM+MqNN/rF9QlkPV du25ycJGqGEwXEJ4HuGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD2gs-00FL4e-8G; Thu, 27 Jan 2022 11:11:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD2gk-00FL25-Lo for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 11:11:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48EDA1FB; Thu, 27 Jan 2022 03:11:34 -0800 (PST) Received: from [10.57.39.22] (unknown [10.57.39.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9526B3F7D8; Thu, 27 Jan 2022 03:11:31 -0800 (PST) Message-ID: <1ec258b8-c6dd-aa0f-8583-2d7667314be9@arm.com> Date: Thu, 27 Jan 2022 11:11:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Andrew Kilroy Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics To: Andi Kleen , John Garry , Ian Rogers Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org References: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com> <20211214184240.24215-1-andrew.kilroy@arm.com> <20211214184240.24215-2-andrew.kilroy@arm.com> <5a2e29c1-2c7e-1b55-9192-62060309aeca@arm.com> <12e0deef-08db-445f-4958-bcd5c3e10367@linux.intel.com> Content-Language: en-US In-Reply-To: <12e0deef-08db-445f-4958-bcd5c3e10367@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_031138_834980_AB24977A X-CRM114-Status: GOOD ( 23.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5kaSwKCgpPbiAyMS8xMi8yMDIxIDE0OjAzLCBBbmRpIEtsZWVuIHdyb3RlOgo+IAo+IE9u IDEyLzIwLzIwMjEgOToyMSBBTSwgQW5kcmV3IEtpbHJveSB3cm90ZToKPj4KPj4gT24gMTUvMTIv MjAyMSAxMDo1MiwgSm9obiBHYXJyeSB3cm90ZToKPj4+IEhpIEFuZHJldywKPj4+Cj4+Pj4+IMKg IGNvbnN0IHN0cnVjdCBwbXVfZXZlbnQgKm1ldHJpY2dyb3VwX19maW5kX21ldHJpYyhjb25zdCBj aGFyICptZXRyaWMsCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGNvbnN0IHN0cnVjdCAKPj4+Pj4gcG11X2V2ZW50c19tYXAgKm1hcCk7Cj4+Pj4+IMKgIGlu dCBtZXRyaWNncm91cF9fcGFyc2VfZ3JvdXBzX3Rlc3Qoc3RydWN0IGV2bGlzdCAqZXZsaXN0LAo+ Pj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvcGVyZi91dGlsL3RvcGRvd24uYyBiL3Rvb2xzL3BlcmYv dXRpbC90b3Bkb3duLmMKPj4+Pj4gaW5kZXggMTA4MWIyMGY5ODkxLi41N2MwYzVmMmM2YmQgMTAw NjQ0Cj4+Pj4+IC0tLSBhL3Rvb2xzL3BlcmYvdXRpbC90b3Bkb3duLmMKPj4+Pj4gKysrIGIvdG9v bHMvcGVyZi91dGlsL3RvcGRvd24uYwo+Pj4+PiBAQCAtNTYsMyArNTYsOSBAQCBfX3dlYWsgYm9v bCBhcmNoX3RvcGRvd25fc2FtcGxlX3JlYWQoc3RydWN0IGV2c2VsIAo+Pj4+PiAqbGVhZGVyIF9f bWF5YmVfdW51c2VkKQo+Pj4+PiDCoCB7Cj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZh bHNlOwo+Pj4+PiDCoCB9Cj4+Pj4+ICsKPj4+Pj4gK19fd2VhayBib29sIGFyY2hfdG9wZG93bl91 c2VfanNvbl9tZXRyaWNzKHZvaWQpCj4+Pj4+ICt7Cj4+Pgo+Pj4gQUZBSUNTLCBvbmx5IHg4NiBz dXBwb3J0cyB0b3Bkb3duIHRvZGF5IGFuZCB0aGF0IGlzIGJlY2F1c2UgdGhleSBoYXZlIAo+Pj4g c3BlY2lhbCBrZXJuZWwgdG9wZG93biBldmVudHMgZXhwb3NlZCBmb3IgdGhlIGtlcm5lbCBDUFUg UE1VIGRyaXZlci4gCj4+PiBTbyBvdGhlciBhcmNoaXRlY3R1cmVzIC0gbm90IG9ubHkgYXJtIC0g d291bGQgbmVlZCByZWx5IG9uIAo+Pj4gbWV0cmljZ3JvdXBzIGZvciB0b3Bkb3duIHN1cHBvcnQu IFNvIGxldCdzIG1ha2UgdGhpcyBnZW5lcmljIGZvciBhbGwgCj4+PiBhcmNocy4KPj4+Cj4+Pj4g SSBsaWtlIHRoaXMgZXh0ZW5zaW9uISBJJ3ZlIHJhbnRlZCBpbiB0aGUgcGFzdCBhYm91dCB3ZWFr IHN5bWJvbHMKPj4+PiBicmVha2luZyB3aXRoIGFyY2hpdmVzIGR1ZSB0byBsYXp5IGxvYWRpbmcg WzFdLiBJbiB0aGlzIGNhc2UKPj4+PiB0b29scy9wZXJmL2FyY2gvYXJtNjQvdXRpbC90b3Bkb3du LmMgaGFzIG5vIG90aGVyIHN5bWJvbHMgd2l0aGluIGl0Cj4+Pj4gYW5kIHNvIHRoZSB3ZWFrIHN5 bWJvbCBoYXMgYW4gZXh0cmEgY2hhbmNlIG9mIGJlaW5nIGxpbmtlZAo+Pj4+IGluY29ycmVjdGx5 LiBXZSBjb3VsZCBhZGQgYSBuZXcgY29tbWFuZCBsaW5lIG9mIC0tdG9wZG93bi1qc29uIHRvCj4+ Pj4gYXZvaWQgdGhpcywgYnV0IHRoZXJlIHNlZW1zIGxpdHRsZSBkaWZmZXJlbmNlIGluIGRvaW5n IHRoaXMgb3ZlciBqdXN0Cj4+Pj4gZG9pbmcgJy1NIFRvcERvd25MMScuCj4+Pgo+Pj4KPj4+PiBJ cyBpdCBwb3NzaWJsZSB0byB1c2UgdGhlIGpzb24gbWV0cmljIGFwcHJvYWNoCj4+Pj4gZm9yIHdo ZW4gdGhlIENQVSB2ZXJzaW9uIGZhaWxzPwo+Pj4KPj4+IEkgdGhpbmsgdGhhdCdzIGEgZ29vZCBp ZGVhLgo+Pj4KPj4KPj4KPj4gV2hpbGUgbG9va2luZyBpbnRvIHVzaW5nIHRoZSBqc29uIG1ldHJp Y3MgYXBwcm9hY2ggYXMgYSBmYWxsYmFjayB0byAKPj4gdGhlIG9yaWdpbmFsLCBJIG5vdGljZWTC oCB0aGVyZSBhcmUgdHdvIGpzb24gbWV0cmljZ3JvdXBzICdUb3Bkb3duTDEnIAo+PiBhbmQgJ1Rv cERvd25MMScgKG5vdGUgdGhlIGNhc2UgZGlmZmVyZW5jZSkgb24geDg2LiBOb3Qgc3VyZSBpZiB0 aGUgCj4+IGNhc2UgZGlmZmVyZW5jZSBpcyBpbnRlbnRpb25hbC4KPj4KPj4gT24gc2t5bGFrZSwg J1RvcGRvd25MMScgY29udGFpbnMgdGhlIGZvdXIganNvbiBtZXRyaWNzIFJldGlyaW5nLCAKPj4g QmFkX1NwZWN1bGF0aW9uLCBGcm9udGVuZF9Cb3VuZCwgYW5kIEJhY2tlbmRfQm91bmQuwqAgJ1Rv cERvd25MMScgaGFzIAo+PiAnU0xPVFMnLCAnQ29yZUlQQycsICdDb3JlSVBDX1NNVCcsICdJbnN0 cnVjdGlvbnMnLsKgIEkgdGhpbmsgaXRzIGEgCj4+IHNpbWlsYXIgc2l0dWF0aW9uIG9uIG90aGVy IHg4NiBjaGlwcy4KPiAKPiAKPiBUaGVyZSdzIGFsc28gU01UIG1ldHJpY3MuCj4gCj4gCj4gV2Ug ZG9uJ3Qgd2FudCB0byBpbmNsdWRlIENvcmVJUEMgZXRjLiBieSBkZWZhdWx0IGJlY2F1c2UgaXQg d291bGQgY2F1c2UgCj4gbXVsdGlwbGV4aW5nIGluIGNvbW1vbiBzaXR1YXRpb25zLgo+IAo+Pgo+ PiBUaGUgc2VhcmNoIGZvciB0aG9zZSBtZXRyaWNzIGJ5IG1ldHJpY2dyb3VwIG5hbWUgaXMgY2Fz ZSBpbnNlbnNpdGl2ZSwgCj4+IHNvIGl0J3MgcGlja2luZyB1cCBhbGwgOCBtZXRyaWNzIHdoZW4g dXNpbmcgdGhlIGxvb2t1cCBzdHJpbmcgCj4+ICdUb3BEb3duTDEnLiDCoFNvIHRoZSBleHRyYSAn U0xPVFMnLCAnQ29yZUlQQycsICdDb3JlSVBDX1NNVCcsIAo+PiAnSW5zdHJ1Y3Rpb25zJyBtZXRy aWNzIHdvdWxkIGJlIHByaW50ZWQgYXMgd2VsbC4KPj4KPj4gTm90IHN1cmUgd2hhdCB0aGUgc2ln bmlmaWNhbmNlIG9mIHRoZSBjYXNlIGRpZmZlcmVuY2UgbWlnaHQgYmUuCj4+Cj4+IFNob3VsZCB3 ZSB1c2UgYSBkaWZmZXJlbnQgc3RyaW5nIHRoYW4gJ1RvcERvd25MMScgYXMgdGhlIG1ldHJpYyBn cm91cCAKPj4gbmFtZSB0byBzZWFyY2ggZm9yPwo+IAo+IAo+IFdlIHNob3VsZCBwcm9iYWJseSBm aXggdGhlIGNhc2UgKG9yIGp1c3QgbWFrZSB0aGUgbWF0Y2ggY2FzZSBpbnNlbnNpdGl2ZSkKPiAK PiBDYW4gd2UganVzdCBrZWVwIHg4NiBhdCB1c2luZyB0aGUga2VybmVsIG1ldHJpY3M/IE9uIFNr eWxha2UgYW5kIGVhcmxpZXIgCj4gaXQgbmVlZHMgZGlmZmVyZW50IGZvcm11bGFzIGFuZCBvdGhl ciBvcHRpb25zIGRlcGVuZGluZyB3aGV0aGVyIFNNVCBpcyAKPiBvbiBvciBvZmYsIHNvIGl0J3Mg bm90IHN0cmFpZ2h0IGZvcndhcmQgdG8gZXhwcmVzcyBpdCBhcyBqc29uIGRpcmVjdGx5Lgo+IAoK SSBwb3N0ZWQgYSB2MiBvZiB0aGVzZSBwYXRjaGVzIHdoaWNoIGtlZXBzIHg4NiBvbmx5IHVzaW5n IHRoZSBrZXJuZWwgCm1ldHJpY3MuCgogCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXBl cmYtdXNlcnMvMjAyMjAxMTExNTA3NDkuMTMzNjUtMS1hbmRyZXcua2lscm95QGFybS5jb20vCgpX b3VsZCBiZSBnb29kIHRvIGdldCB5b3VyIGZlZWRiYWNrLAoKVGhhbmtzCkFuZHJldwoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK