From: Dario Faggioli <dfaggioli@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <JGross@suse.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] xen: credit2: document that min_rqd is valid and ok to use
Date: Wed, 22 Jul 2020 15:40:10 +0000 [thread overview]
Message-ID: <1ec2e50b96263f6d4f4fd0d8de66c236b35c3101.camel@suse.com> (raw)
In-Reply-To: <158524252335.30595.3422322089286433323.stgit@Palanthas>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Thu, 2020-03-26 at 18:08 +0100, Dario Faggioli wrote:
> Code is a bit involved, and it is not easy to tell that min_rqd,
> inside
> csched2_res_pick() is actually pointing to a runqueue, when it is
> dereferenced.
>
> Add a comment and an ASSERT() for that.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
>
Ping.
Actually, for George, this is more a:
<<Hey, it seems I forgot to Cc you when I sent this. Apologies for
that!>> :-)
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-22 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 17:08 [Xen-devel] [PATCH] xen: credit2: document that min_rqd is valid and ok to use Dario Faggioli
2020-07-22 15:40 ` Dario Faggioli [this message]
2020-10-26 10:43 ` George Dunlap
2020-10-26 17:44 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec2e50b96263f6d4f4fd0d8de66c236b35c3101.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.