From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH v3 19/19] libmultipath: Fixup updating paths Date: Tue, 02 Oct 2018 00:30:51 +0200 Message-ID: <1ec6d9dbdab329d9125ee380790933b7dfab804a.camel@suse.com> References: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> <1537571127-10143-20-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1537571127-10143-20-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski , device-mapper development List-Id: dm-devel.ids T24gRnJpLCAyMDE4LTA5LTIxIGF0IDE4OjA1IC0wNTAwLCBCZW5qYW1pbiBNYXJ6aW5za2kgd3Jv dGU6Cj4gQ29tbWl0IDU4MmM1NmNjIGJyb2tlIHNvbWUgY29kZSBwYXRocyBpbiB1ZXZfdXBkYXRl X3BhdGguIEZpcnN0LCBpdAo+IGNoYW5nZWQgdGhlIGhhbmRsaW5nIG9mIHBhdGhzIHRoYXQgd2Vy ZSBub3QgZnVsbHkgaW5pdGlhbGl6ZWQuCj4gdWV2X3VwZGF0ZV9wYXRoIHdhcyBzaW1wbHkgc2V0 dGluZyB0aGUgd3dpZHMgZm9yIGFsbCBvZiB0aGVzZSBwYXRocy4KPiBJbnN0ZWFkLCBpdCBzaG91 bGQgaWdub3JlIHRoZSBvbmVzIHRoYXQgaGFkIG5vdCByZXF1ZXN0ZWQgYSBuZXcKPiB1ZXZlbnQu Cj4gVGhlc2UgcGF0aHMgYXJlIGxpa2VseSBkb3duLCBhbmQgYXJlIGFscmVhZHkgZ2V0dGluZyBo YW5kbGVkIGJ5Cj4gY2hlY2tfcGF0aCwgYWZ0ZXIgaXQgdmVyaWZpZXMgdGhhdCB0aGV5IGhhdmUg YmVjb21lIGFjdGl2ZS4gQWxzbywKPiBzZXR0aW5nIHRoZSB3d2lkIGRvZXNuJ3QgdXBkYXRlIGFs bCBvZiB0aGUgb3RoZXIgaW5mb3JtYXRpb24gdGhhdAo+IG1heSBoYXZlIGJlZW4gbWlzc2VkIHdo ZW4gdGhlIHBhdGggd2FzIGluaXRpYWxseSBhZGRlZC4KPiAKPiBBbHNvLCBpdCB3YXNuJ3QgcG9z c2libGUgZm9yIHBwLT53d2lkX2NoYW5nZWQgdG8gdHJhbnNpdGlvbiBiYWNrIHRvCj4gemVybywg dW5sZXNzIHRoZSBwYXRoJ3Mgd3dpZCB3YXMgZW1wdHksIGluIHdoaWNoIGNhc2UgdGhlcmUgd2Fz IG5vCj4gcmVhc29uIHRvIHdvcnJ5IGFib3V0IHRoZSB3d2lkIGNoYW5nZSBpbiB0aGUgZmlyc3Qg cGxhY2UsIHNpbmNlIHRoZQo+IHBhdGgKPiBoYWRuJ3QgYmVlbiBmdWxseSBpbml0aWFsaXplZCB5 ZXQuIFNvLCBldmVuIGlmIGEgcGF0aCdzIHd3aWQgY2hhbmdlZAo+IGFuZAo+IHRoZW4gY2hhbmdl ZCBiYWNrIHRvIHRoZSBvcmlnaW5hbCB2YWx1ZSwgdGhlIHBhdGggc3RpbGwgY291bGQgbm90IGJl Cj4gdXNlZC4KPiAKPiBUaGlzIHBhdGNoIGZpeGVzIHRoZXNlIGlzc3VlcywgYW5kIGFsc28gbW92 ZXMgdGhlIGNoZWNrIGZvciBwYXRocwo+IHRoYXQKPiBoYXZlIHJlcXVlc3RlZCBhIG5ldyB1ZXZl bnQgdXAgaW4gdGhlIGZ1bmN0aW9ucy4gVGhlc2UgcGF0aHMgd2lsbCBnZXQKPiBmdWxseSByZWlu aXRpYWxpemVkIGFueXdheSwgc28gdGhlcmUgaXMgbm8gcmVhc29uIHRvIGRvIGFsbCB0aGUgb3Ro ZXIKPiB3b3JrIGZpcnN0Lgo+IAo+IEZpeGVzOiA1ODJjNTZjYyAoImxpYm11bHRpcGF0aDogdWV2 X3VwZGF0ZV9wYXRoOiBhbHdheXMgd2FybiBpZiBXV0lECj4gY2hhbmdlZCIpCj4gCj4gU2lnbmVk LW9mZi1ieTogQmVuamFtaW4gTWFyemluc2tpIDxibWFyemluc0ByZWRoYXQuY29tPgoKVGhhbmtz IGZvciBmaXhpbmcgdGhpcy4gTG9va2luZyBhdCB0aGUgY2xlYW5lZC11cCBsb2dpYyBhZnRlciB0 aGlzCnBhdGNoLCBJIGJlbGlldmUgdGhhdCB3ZSBzaG91bGQgaGFyZC1jb2RlICJkaXNhYmxlX2No YW5nZWRfd3dpZHMiIHRvIDEuCkl0J3MgY3JhenkgdG8gcmVhbGl6ZSB0aGF0IGEgcGF0aCBXV0lE IGhhcyBjaGFuZ2VkIGFuZCBzaW1wbHkgZ28gb24gYXMKaWYgbm90aGluZyBoYWQgaGFwcGVuZWQu IFdlIHNob3VsZG4ndCBhbGxvdyB0aGlzIGNvbmZpZ3VyYXRpb24gYW55Cm1vcmUuCgpSZXZpZXdl ZC1ieTogTWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+Cgo+IC0tLQo+ICBtdWx0aXBhdGhk L21haW4uYyB8IDI0ICsrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL211bHRp cGF0aGQvbWFpbi5jIGIvbXVsdGlwYXRoZC9tYWluLmMKPiBpbmRleCA2MWNhNDU1Li5kNmQxMjJh IDEwMDY0NAo+IC0tLSBhL211bHRpcGF0aGQvbWFpbi5jCj4gKysrIGIvbXVsdGlwYXRoZC9tYWlu LmMKPiBAQCAtMTIwNyw2ICsxMjA3LDE1IEBAIHVldl91cGRhdGVfcGF0aCAoc3RydWN0IHVldmVu dCAqdWV2LCBzdHJ1Y3QKPiB2ZWN0b3JzICogdmVjcykKPiAgCQlzdHJ1Y3QgbXVsdGlwYXRoICpt cHAgPSBwcC0+bXBwOwo+ICAJCWNoYXIgd3dpZFtXV0lEX1NJWkVdOwo+ICAKPiArCQlpZiAocHAt PmluaXRpYWxpemVkID09IElOSVRfUkVRVUVTVEVEX1VERVYpIHsKPiArCQkJbmVlZHNfcmVpbml0 ID0gMTsKPiArCQkJZ290byBvdXQ7Cj4gKwkJfQo+ICsJCS8qIERvbid0IGRlYWwgd2l0aCBvdGhl ciB0eXBlcyBvZiBmYWlsZWQgaW5pdGlhbGl6YXRpb24KPiArCQkgKiBub3cuIGNoZWNrX3BhdGgg d2lsbCBoYW5kbGUgaXQgKi8KPiArCQlpZiAoIXN0cmxlbihwcC0+d3dpZCkpCj4gKwkJCWdvdG8g b3V0Owo+ICsKPiAgCQlzdHJjcHkod3dpZCwgcHAtPnd3aWQpOwo+ICAJCWdldF91aWQocHAsIHBw LT5zdGF0ZSwgdWV2LT51ZGV2KTsKPiAgCj4gQEAgLTEyMTUsOSArMTIyNCw4IEBAIHVldl91cGRh dGVfcGF0aCAoc3RydWN0IHVldmVudCAqdWV2LCBzdHJ1Y3QKPiB2ZWN0b3JzICogdmVjcykKPiAg CQkJCXVldi0+a2VybmVsLCB3d2lkLCBwcC0+d3dpZCwKPiAgCQkJCShkaXNhYmxlX2NoYW5nZWRf d3dpZHMgPyAiZGlzYWxsb3dpbmciCj4gOgo+ICAJCQkJICJjb250aW51aW5nIikpOwo+IC0JCQlp ZiAoZGlzYWJsZV9jaGFuZ2VkX3d3aWRzICYmCj4gLQkJCSAgICAoc3RybGVuKHd3aWQpIHx8IHBw LT53d2lkX2NoYW5nZWQpKSB7Cj4gLQkJCQlzdHJjcHkocHAtPnd3aWQsIHd3aWQpOwo+ICsJCQlz dHJjcHkocHAtPnd3aWQsIHd3aWQpOwo+ICsJCQlpZiAoZGlzYWJsZV9jaGFuZ2VkX3d3aWRzKSB7 Cj4gIAkJCQlpZiAoIXBwLT53d2lkX2NoYW5nZWQpIHsKPiAgCQkJCQlwcC0+d3dpZF9jaGFuZ2Vk ID0gMTsKPiAgCQkJCQlwcC0+dGljayA9IDE7Cj4gQEAgLTEyMjUsMTEgKzEyMzMsOSBAQCB1ZXZf dXBkYXRlX3BhdGggKHN0cnVjdCB1ZXZlbnQgKnVldiwgc3RydWN0Cj4gdmVjdG9ycyAqIHZlY3Mp Cj4gIAkJCQkJCWRtX2ZhaWxfcGF0aChwcC0+bXBwLQo+ID5hbGlhcywgcHAtPmRldl90KTsKPiAg CQkJCX0KPiAgCQkJCWdvdG8gb3V0Owo+IC0JCQl9IGVsc2UgaWYgKCFkaXNhYmxlX2NoYW5nZWRf d3dpZHMpCj4gLQkJCQlzdHJjcHkocHAtPnd3aWQsIHd3aWQpOwo+IC0JCQllbHNlCj4gLQkJCQlw cC0+d3dpZF9jaGFuZ2VkID0gMDsKPiArCQkJfQo+ICAJCX0gZWxzZSB7Cj4gKwkJCXBwLT53d2lk X2NoYW5nZWQgPSAwOwo+ICAJCQl1ZGV2X2RldmljZV91bnJlZihwcC0+dWRldik7Cj4gIAkJCXBw LT51ZGV2ID0gdWRldl9kZXZpY2VfcmVmKHVldi0+dWRldik7Cj4gIAkJCWNvbmYgPSBnZXRfbXVs dGlwYXRoX2NvbmZpZygpOwo+IEBAIC0xMjQwLDkgKzEyNDYsNyBAQCB1ZXZfdXBkYXRlX3BhdGgg KHN0cnVjdCB1ZXZlbnQgKnVldiwgc3RydWN0Cj4gdmVjdG9ycyAqIHZlY3MpCj4gIAkJCXB0aHJl YWRfY2xlYW51cF9wb3AoMSk7Cj4gIAkJfQo+ICAKPiAtCQlpZiAocHAtPmluaXRpYWxpemVkID09 IElOSVRfUkVRVUVTVEVEX1VERVYpCj4gLQkJCW5lZWRzX3JlaW5pdCA9IDE7Cj4gLQkJZWxzZSBp ZiAobXBwICYmIHJvID49IDApIHsKPiArCQlpZiAobXBwICYmIHJvID49IDApIHsKPiAgCQkJY29u ZGxvZygyLCAiJXM6IHVwZGF0ZSBwYXRoIHdyaXRlX3Byb3RlY3QgdG8KPiAnJWQnICh1ZXZlbnQp IiwgdWV2LT5rZXJuZWwsIHJvKTsKPiAgCj4gIAkJCWlmIChtcHAtPndhaXRfZm9yX3VkZXYpCgot LSAKRHIuIE1hcnRpbiBXaWxjayA8bXdpbGNrQHN1c2UuY29tPiwgVGVsLiArNDkgKDApOTExIDc0 MDUzIDIxMDcKU1VTRSBMaW51eCBHbWJILCBHRjogRmVsaXggSW1lbmTDtnJmZmVyLCBKYW5lIFNt aXRoYXJkLCBHcmFoYW0gTm9ydG9uCkhSQiAyMTI4NCAoQUcgTsO8cm5iZXJnKQoKCi0tCmRtLWRl dmVsIG1haWxpbmcgbGlzdApkbS1kZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5j b20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbA==