From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: From: Chris Packham To: Guenter Roeck , "robh+dt@kernel.org" , "jdelvare@suse.com" CC: "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland Subject: Re: [PATCH 1/2] dt-bindings: hwmon: add binding documentation for adt7475 Date: Wed, 7 Nov 2018 04:27:27 +0000 Message-ID: <1ed7434bfded41bfba3b739f58f69102@svr-chch-ex1.atlnz.lc> References: <20181107040010.27436-1-chris.packham@alliedtelesis.co.nz> <20181107040010.27436-2-chris.packham@alliedtelesis.co.nz> <64720b73-dddf-783c-a3a4-3f32a748bf5d@roeck-us.net> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-ID: On 7/11/18 5:24 PM, Guenter Roeck wrote:=0A= > On 11/6/18 8:00 PM, Chris Packham wrote:=0A= >> With the addition of the invert-pwm property the adt7475 needs its own= =0A= >> binding documentation rather being captured under trivial-devices.txt.= =0A= >>=0A= >> Signed-off-by: Chris Packham =0A= >> ---=0A= >> .../devicetree/bindings/hwmon/adt7475.txt | 22 ++++++++++++++++++= +=0A= >> .../devicetree/bindings/trivial-devices.txt | 4 ----=0A= >> 2 files changed, 22 insertions(+), 4 deletions(-)=0A= >> create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.tx= t=0A= >>=0A= >> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.txt b/Docum= entation/devicetree/bindings/hwmon/adt7475.txt=0A= >> new file mode 100644=0A= >> index 000000000000..79255439e157=0A= >> --- /dev/null=0A= >> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.txt=0A= >> @@ -0,0 +1,22 @@=0A= >> +*ADT7475 hwmon sensor.=0A= >> +=0A= >> +Required properties:=0A= >> +- compatible: One of=0A= >> + "adi,adt7473"=0A= >> + "adi,adt7475"=0A= >> + "adi,adt7476"=0A= >> + "adi,adt7490"=0A= >> +=0A= >> +- reg: I2C address=0A= >> +=0A= >> +optional properties:=0A= >> +=0A= >> +- invert-pwm: This configures the PWM to use logic low for 100% duty cy= cle.=0A= >> +=0A= >> +Example:=0A= >> +=0A= >> +hwmon@2e {=0A= >> + compatible =3D ;=0A= >> + reg =3D <0x2e>;=0A= >> + invert-pwm;=0A= > =0A= > If I understand correctly, the flag is set per pwm channel. A single glob= al=0A= > property seems inappropriate.=0A= =0A= Yes it is per-channel. But I was having a hard time imagining a hardware = =0A= design that would use both inverted and non-inverted at the same time.=0A= =0A= Do you have a preference for how the properties should look?=0A= =0A= invert-pwm[123]?=0A= =0A= invert-pwm =3D <0x7>;?=0A= =0A= > =0A= > Guenter=0A= > =0A= >> +};=0A= >> diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Doc= umentation/devicetree/bindings/trivial-devices.txt=0A= >> index 69c934aec13b..4f29100d6bbf 100644=0A= >> --- a/Documentation/devicetree/bindings/trivial-devices.txt=0A= >> +++ b/Documentation/devicetree/bindings/trivial-devices.txt=0A= >> @@ -14,10 +14,6 @@ ad,ad7414 SMBus/I2C Digital Temperature Sensor in 6-= Pin SOT with SMBus Alert an=0A= >> ad,adm9240 ADM9240: Complete System Hardware Monitor for uProcessor= -Based Systems=0A= >> adi,adt7461 +/-1C TDM Extended Temp Range I.C=0A= >> adt7461 +/-1C TDM Extended Temp Range I.C=0A= >> -adi,adt7473 +/-1C TDM Extended Temp Range I.C=0A= >> -adi,adt7475 +/-1C TDM Extended Temp Range I.C=0A= >> -adi,adt7476 +/-1C TDM Extended Temp Range I.C=0A= >> -adi,adt7490 +/-1C TDM Extended Temp Range I.C=0A= >> adi,adxl345 Three-Axis Digital Accelerometer=0A= >> adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility= value "adi,adxl345" must be listed too)=0A= >> ams,iaq-core AMS iAQ-Core VOC Sensor=0A= >>=0A= > =0A= > =0A= =0A=