* [PATCH] ATA: Debugging options for the ATA subsystem
@ 2011-06-08 6:18 Viresh Kumar
2011-06-08 14:39 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2011-06-08 6:18 UTC (permalink / raw)
To: jgarzik, linux-ide; +Cc: Viresh Kumar
This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/ata/Kconfig | 14 ++++++++++++++
drivers/ata/Makefile | 2 ++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 75afa75..d527fbe 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -30,6 +30,20 @@ menuconfig ATA
if ATA
+config ATA_DEBUG
+ bool "ATA debugging"
+ help
+ This is an option for use by developers; most people should
+ say N here. This enables ATA core and driver debugging.
+
+config ATA_VDEBUG
+ bool "ATA verbose debugging"
+ depends on ATA_DEBUG != n
+ help
+ This is an option for use by developers; most people should
+ say N here. This enables deeper (more verbose) debugging of
+ the ATA core and drivers.
+
config ATA_NONSTANDARD
bool
default n
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 8ac64e1..d0b95a7 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,3 +1,5 @@
+ccflags-$(CONFIG_ATA_DEBUG) := -DDEBUG
+ccflags-$(CONFIG_ATA_VDEBUG) += -DVERBOSE_DEBUG
obj-$(CONFIG_ATA) += libata.o
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ATA: Debugging options for the ATA subsystem
2011-06-08 6:18 [PATCH] ATA: Debugging options for the ATA subsystem Viresh Kumar
@ 2011-06-08 14:39 ` Sergei Shtylyov
2011-06-09 3:52 ` viresh kumar
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2011-06-08 14:39 UTC (permalink / raw)
To: Viresh Kumar; +Cc: jgarzik, linux-ide
Hello.
Viresh Kumar wrote:
> This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
> drivers/ata/Kconfig | 14 ++++++++++++++
> drivers/ata/Makefile | 2 ++
> 2 files changed, 16 insertions(+), 0 deletions(-)
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 75afa75..d527fbe 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -30,6 +30,20 @@ menuconfig ATA
>
> if ATA
>
> +config ATA_DEBUG
> + bool "ATA debugging"
> + help
> + This is an option for use by developers; most people should
> + say N here. This enables ATA core and driver debugging.
> +
> +config ATA_VDEBUG
> + bool "ATA verbose debugging"
> + depends on ATA_DEBUG != n
Why not just on ATA_DEBUG? It can only be 'y' or 'n'.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ATA: Debugging options for the ATA subsystem
2011-06-08 14:39 ` Sergei Shtylyov
@ 2011-06-09 3:52 ` viresh kumar
0 siblings, 0 replies; 3+ messages in thread
From: viresh kumar @ 2011-06-09 3:52 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: jgarzik, linux-ide
On 06/08/2011 08:09 PM, Sergei Shtylyov wrote:
>> > +config ATA_DEBUG
>> > + bool "ATA debugging"
>> > + help
>> > + This is an option for use by developers; most people should
>> > + say N here. This enables ATA core and driver debugging.
>> > +
>> > +config ATA_VDEBUG
>> > + bool "ATA verbose debugging"
>> > + depends on ATA_DEBUG != n
> Why not just on ATA_DEBUG? It can only be 'y' or 'n'.
Yes, that's correct! Will resend it.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-09 3:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-08 6:18 [PATCH] ATA: Debugging options for the ATA subsystem Viresh Kumar
2011-06-08 14:39 ` Sergei Shtylyov
2011-06-09 3:52 ` viresh kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.