All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 4/5] doc: Clarify settings in iwd.ap(5)
Date: Mon, 26 Apr 2021 11:22:03 -0500	[thread overview]
Message-ID: <1ef9b4de-7f23-204b-aaf8-2b283266fc19@gmail.com> (raw)
In-Reply-To: <CAOq732JyYXZrd_2HHSB2iXQtRzrTTC9BhC4=FQhuABjv4ygqYg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

Hi Andrew,

On 4/26/21 11:05 AM, Andrew Zaborowski wrote:
> Hi Denis,
> 
> On Mon, 26 Apr 2021 at 17:53, Denis Kenzior <denkenz@gmail.com> wrote:
>>> -The group ``[IPv4]`` contains settings for IWD's built in DHCP server. All
>>> -settings are optional.
>>> +The group ``[IPv4]`` contains settings for IWD's built-in DHCP server. All
>>> +settings are optional.  They're used if network configuration was enabled as
>>> +described in ``iwd.config(5)``.  Omitting the ``[IPv4]`` group disables
>>> +network configuration and the DHCP server for this access point.
>>>
>>
>> Hmm.. If 'all settings are optional', then how do you know whether 'IPv4' group
>> was omitted on purpose or not?
> 
> Well, you have to assume everything in the config file is done on
> purpose.  I think this is the only place IWD looks at whether a group
> is present but this is the current behavior AFAIK.
> 

So your intent is to have an empty [IPV4] group (i.e. '[IPv4]' line with nothing 
afterward)?  This is a bit confusing since a user would simply omit the '[IPv4]' 
line as well if all the options were the defaults...

Maybe mention the need for this line in the docs?  Or alternatively... Do we 
even need the ability to turn of dhcp per profile?  Isn't 
EnableNetworkConfiguration enough?

Regards,
-Denis

  reply	other threads:[~2021-04-26 16:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 13:26 [PATCH 1/5] p2p,netdev: Fix event name typo in comments Andrew Zaborowski
2021-04-26 13:26 ` [PATCH 2/5] wscutil: Move DeviceType parsing from p2p & eap-wsc to a function Andrew Zaborowski
2021-04-26 13:26 ` [PATCH 3/5] ap: Drop struct ap_config in favor of l_settings Andrew Zaborowski
2021-04-26 16:39   ` Denis Kenzior
2021-04-26 18:06     ` Andrew Zaborowski
2021-04-26 20:22       ` Denis Kenzior
2021-04-26 13:26 ` [PATCH 4/5] doc: Clarify settings in iwd.ap(5) Andrew Zaborowski
2021-04-26 15:53   ` Denis Kenzior
2021-04-26 16:05     ` Andrew Zaborowski
2021-04-26 16:22       ` Denis Kenzior [this message]
2021-04-26 18:19         ` Andrew Zaborowski
2021-04-26 13:26 ` [PATCH 5/5] doc: Update iwd.ap(5) man page Andrew Zaborowski
2021-04-26 15:54 ` [PATCH 1/5] p2p,netdev: Fix event name typo in comments Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ef9b4de-7f23-204b-aaf8-2b283266fc19@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.