From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbbJJJda (ORCPT ); Sat, 10 Oct 2015 05:33:30 -0400 Received: from m12-16.163.com ([220.181.12.16]:44305 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbJJJd2 (ORCPT ); Sat, 10 Oct 2015 05:33:28 -0400 From: Geliang Tang To: Karsten Keil Cc: Geliang Tang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mISDN: use kstrdup() in dsp_pipeline_build Date: Sat, 10 Oct 2015 02:32:15 -0700 Message-Id: <1efbeaf13aca3797e7d7f899ca00b27e37bbde9d.1444498002.git.geliangtang@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EMCowECpNEwu2xhWiPxzDQ--.7135S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFW8CryUWw4rJF4rXFyUtrb_yoWkWrg_Ar y8tw1DJrW7X3Wv9ry7Jr45Zr9I9w4qvF1qyr18ta4fArnrJw45Ca4kCFZ5Gr15J34fGF4U ArZ0yFykAa47WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUd-PUUUUUU== X-Originating-IP: [218.17.162.133] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiNRCPmVSIJZ0LsgAAsu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use kstrdup instead of strlen-kmalloc-strcpy. Signed-off-by: Geliang Tang --- drivers/isdn/mISDN/dsp_pipeline.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/isdn/mISDN/dsp_pipeline.c b/drivers/isdn/mISDN/dsp_pipeline.c index 8b1a66c..c60722d 100644 --- a/drivers/isdn/mISDN/dsp_pipeline.c +++ b/drivers/isdn/mISDN/dsp_pipeline.c @@ -235,7 +235,7 @@ void dsp_pipeline_destroy(struct dsp_pipeline *pipeline) int dsp_pipeline_build(struct dsp_pipeline *pipeline, const char *cfg) { - int len, incomplete = 0, found = 0; + int incomplete = 0, found = 0; char *dup, *tok, *name, *args; struct dsp_element_entry *entry, *n; struct dsp_pipeline_entry *pipeline_entry; @@ -250,14 +250,9 @@ int dsp_pipeline_build(struct dsp_pipeline *pipeline, const char *cfg) if (!cfg) return 0; - len = strlen(cfg); - if (!len) - return 0; - - dup = kmalloc(len + 1, GFP_ATOMIC); + dup = kstrdup(cfg, GFP_ATOMIC); if (!dup) return 0; - strcpy(dup, cfg); while ((tok = strsep(&dup, "|"))) { if (!strlen(tok)) continue; -- 1.9.1