From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure
Date: Thu, 16 Apr 2020 19:10:13 +0000 [thread overview]
Message-ID: <1f0b3f169e91da5e9dece561c56e3f526b520cb7.camel@intel.com> (raw)
In-Reply-To: <158697941400.24667.4512728438444809786@build.alporthouse.com>
On Wed, 2020-04-15 at 20:36 +0100, Chris Wilson wrote:
> Quoting José Roberto de Souza (2020-04-15 20:14:08)
> > + i915_reset_error_state(i915);
>
> If you are bored, we should move this to unregister as that is the
> last
> point at which it can be accessed from userspace. Hopefully I
> remember
> next time we are rearranging this sequence.
What if some error happen up to i915_gem_driver_remove()? We would leak
a i915_gpu_coredump.
Looks to me that i915_reset_error_state() should be
called after i915_gem_driver_remove().
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-16 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 19:14 [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure José Roberto de Souza
2020-04-15 19:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-04-15 19:36 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-04-16 19:10 ` Souza, Jose [this message]
2020-04-15 19:39 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2020-04-15 19:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15 19:51 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-04-16 16:08 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-04-16 16:42 ` [Intel-gfx] [PATCH v2] " Imre Deak
2020-04-16 17:03 ` Souza, Jose
2020-04-16 17:06 ` Imre Deak
2020-04-16 17:20 ` Souza, Jose
2020-04-16 17:28 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f0b3f169e91da5e9dece561c56e3f526b520cb7.camel@intel.com \
--to=jose.souza@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.