From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions Date: Mon, 24 Apr 2017 08:54:13 -0400 Message-ID: <1f122892-7e67-a7ca-ae7f-7ac8e2b7a037@intel.com> References: <1492720999.3041.18.camel@redhat.com> <86425035-7da8-d2b1-8544-d4f7540d50c6@users.sourceforge.net> <755f6c2c-03a2-7248-a5e3-9190d119cdaf@users.sourceforge.net> <20170423073311.GA14088@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170423073311.GA14088@mtr-leonro.local> Sender: kernel-janitors-owner@vger.kernel.org To: Leon Romanovsky , Doug Ledford Cc: SF Markus Elfring , Devesh Sharma , Hal Rosenstock , Sean Hefty , Selvin Xavier , Yuval Shaia , linux-rdma@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 04/23/2017 03:33 AM, Leon Romanovsky wrote: > On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 22 Apr 2017 13:26:49 +0200 >> >> Replace the specification of data types by pointer dereferences >> as the parameter for the operator "sizeof" to make the corresponding size >> determinations a bit safer according to the Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> --- >> >> v2: >> Changes were rebased on source files from Linux next-20170421. >> These were recombined as requested by Doug Ledford. > > Hi Doug, > > I recommend you to be extra cautious with this blind automatic > conversions. It requires inspection that every size before and after > match each other. > > I already asked it and would be like to repeat it. Please DON'T take any > patches from Markus, which are related to mlx4/mlx5/rxe without our explicit > review of them. I agree with Leon here, and these sort of find/replace automagic clean-up patches make me nervous sometimes. Markus, what have you done to ensure your patches don't break anything? -Denny From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Date: Mon, 24 Apr 2017 12:54:13 +0000 Subject: Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions Message-Id: <1f122892-7e67-a7ca-ae7f-7ac8e2b7a037@intel.com> List-Id: References: <1492720999.3041.18.camel@redhat.com> <86425035-7da8-d2b1-8544-d4f7540d50c6@users.sourceforge.net> <755f6c2c-03a2-7248-a5e3-9190d119cdaf@users.sourceforge.net> <20170423073311.GA14088@mtr-leonro.local> In-Reply-To: <20170423073311.GA14088@mtr-leonro.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Leon Romanovsky , Doug Ledford Cc: SF Markus Elfring , Devesh Sharma , Hal Rosenstock , Sean Hefty , Selvin Xavier , Yuval Shaia , linux-rdma@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On 04/23/2017 03:33 AM, Leon Romanovsky wrote: > On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 22 Apr 2017 13:26:49 +0200 >> >> Replace the specification of data types by pointer dereferences >> as the parameter for the operator "sizeof" to make the corresponding size >> determinations a bit safer according to the Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> --- >> >> v2: >> Changes were rebased on source files from Linux next-20170421. >> These were recombined as requested by Doug Ledford. > > Hi Doug, > > I recommend you to be extra cautious with this blind automatic > conversions. It requires inspection that every size before and after > match each other. > > I already asked it and would be like to repeat it. Please DON'T take any > patches from Markus, which are related to mlx4/mlx5/rxe without our explicit > review of them. I agree with Leon here, and these sort of find/replace automagic clean-up patches make me nervous sometimes. Markus, what have you done to ensure your patches don't break anything? -Denny