From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/5] xen/domain: Stricter configuration checking Date: Wed, 14 Nov 2018 18:51:06 +0000 Message-ID: <1f29d294-a9a4-8327-1093-d8abf863092a@arm.com> References: <1542039391-32406-1-git-send-email-andrew.cooper3@citrix.com> <1542039391-32406-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1542039391-32406-4-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Stefano Stabellini , Wei Liu , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGkgQW5kcmV3LAoKT24gMTIvMTEvMjAxOCAxNjoxNiwgQW5kcmV3IENvb3BlciB3cm90ZToKPiBD dXJyZW50bHksIGEgbnVtYmVyIG9mIG9wdGlvbnMgcGFzc2VkIGZvciBkb21haW4gY3JlYXRpb24g YXJlIGlnbm9yZWQsIG9yIGhhdmUKPiBpbXBsaWNpdCBmYWxsYmFjayBiZWhhdmlvdXIuICBUaGlz IGlzIGJhZCBmb3IgZm9yd2FyZHMgY29tcGF0aWJpbGl0eSwgYW5kIGZvcgo+IGVuZCB1c2VycyB0 byBiZSBjZXJ0YWluIHRoYXQgdGhleSBnb3QgdGhlIGNvbmZpZ3VyYXRpb24gdGhleSBhc2tlZCBm b3IuCj4gCj4gV2l0aCB0aGlzIGNoYW5nZToKPiAgICogQVJNIG5vdyBzdHJpY3RseSByZXF1aXJl cyB0aGF0IFhFTl9ET01DVExfQ0RGX2hhcCBpcyBwYXNzZWQuICBQcmV2aW91c2x5LAo+ICAgICBv bmx5IFhFTl9ET01DVExfQ0RGX2h2bV9ndWVzdCB3YXMgY2hlY2tlZC4KPiAgICogRm9yIHg4Niwg cmVxdWVzdGluZyBIQVAgd2l0aG91dCBIVk0gaXMgbm93IHByb2hpYml0ZWQsIGFzIHRoZSBjb21i aW5hdGlvbgo+ICAgICBtYWtlcyBubyBzZW5zZS4KPiAgICogRm9yIHg4NiwgcmVxdWVzdGluZyBI QVAgb24gYSBub24tSEFQIGNhcGFibGUgc3lzdGVtIHdpbGwgZmFpbCwgcmF0aGVyIHRoYW4KPiAg ICAgc2lsZW50bHkgZmFsbCBiYWNrIHRvIFNoYWRvdy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRy ZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgoKRm9yIHRoZSBBcm0gYml0czoK CkFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgoKQ2hlZXJzLAoK PiAtLS0KPiBDQzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENDOiBXZWkgTGl1 IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+ Cj4gQ0M6IElhbiBKYWNrc29uIDxJYW4uSmFja3NvbkBjaXRyaXguY29tPgo+IENDOiBXZWkgTGl1 IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+IAo+IFNlbWkgUkZDIGJlY2F1c2UgdGhpcyBtYXkgY2F1 c2UgYSB1c2VyLXZpc2libGUgY2hhbmdlIGluIGJlaGF2aW91ci4gIEhvd2V2ZXIsCj4gaWYgdGhl IHVzZXIgaGFzIGdvbmUgdG8gdGhlIGVmZm9ydCBvZiBzcGVjaWZ5aW5nIGhhcD0xLCBzaWxlbnRs eSBmYWxsaW5nIGJhY2sKPiB0byBzaGFkb3cgaXMgdW5leHBlY3RlZCwgYW5kIElNTywgYSBidWcu Cj4gCj4gQWx0ZXJuYXRpdmVseSwgaWYgdGhpcyBwcm92ZXMgdG8gYmUgY29udHJvdmVyc2lhbCwg aXQgY2FuIGJlIGRyb3BwZWQgZnJvbSB0aGUKPiBzZXJpZXMgdG8gYXZvaWQgYmxvY2tpbmcgdGhl IG1haW4gYnVnZml4Lgo+IAo+IHYyOgo+ICAgKiBOZXcKPiAtLS0KPiAgIHhlbi9hcmNoL2FybS9k b21haW4uYyB8ICA3ICsrKysrKysKPiAgIHhlbi9hcmNoL3g4Ni9kb21haW4uYyB8IDQwICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIHhlbi9jb21tb24vZG9tYWlu LmMgICB8IDM0ICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDMgZmlsZXMg Y2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYwo+IGluZGV4 IGMyNGFjZTYuLjA4YmE0MTIgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jCj4g KysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jCj4gQEAgLTYwMSw2ICs2MDEsMTMgQEAgdm9pZCB2 Y3B1X3N3aXRjaF90b19hYXJjaDY0X21vZGUoc3RydWN0IHZjcHUgKnYpCj4gICAKPiAgIGludCBh cmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWlu ICpjb25maWcpCj4gICB7Cj4gKyAgICBpZiAoICEoY29uZmlnLT5mbGFncyAmIFhFTl9ET01DVExf Q0RGX2h2bV9ndWVzdCkgfHwKPiArICAgICAgICAgIShjb25maWctPmZsYWdzICYgWEVOX0RPTUNU TF9DREZfaGFwKSApCj4gKyAgICB7Cj4gKyAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgIlVu c3VwcG9ydGVkIGNvbmZpZ3VyYXRpb24gJSN4XG4iLCBjb25maWctPmZsYWdzKTsKPiArICAgICAg ICByZXR1cm4gLUVJTlZBTDsKPiArICAgIH0KPiArCj4gICAgICAgLyogRmlsbCBpbiB0aGUgbmF0 aXZlIEdJQyB2ZXJzaW9uLCBwYXNzZWQgYmFjayB0byB0aGUgdG9vbHN0YWNrLiAqLwo+ICAgICAg IGlmICggY29uZmlnLT5hcmNoLmdpY192ZXJzaW9uID09IFhFTl9ET01DVExfQ09ORklHX0dJQ19O QVRJVkUgKQo+ICAgICAgIHsKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2RvbWFpbi5jIGIv eGVuL2FyY2gveDg2L2RvbWFpbi5jCj4gaW5kZXggMjhhMTQ1YS4uZjQ3YWQwNCAxMDA2NDQKPiAt LS0gYS94ZW4vYXJjaC94ODYvZG9tYWluLmMKPiArKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMK PiBAQCAtNDIwLDYgKzQyMCw0NiBAQCB2b2lkIGFyY2hfdmNwdV9kZXN0cm95KHN0cnVjdCB2Y3B1 ICp2KQo+ICAgCj4gICBpbnQgYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKHN0cnVjdCB4ZW5f ZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29uZmlnKQo+ICAgewo+ICsgICAgYm9vbCBodm07Cj4gKwo+ ICsgICAgaWYgKCAhSVNfRU5BQkxFRChDT05GSUdfUFYpICYmICEoY29uZmlnLT5mbGFncyAmIFhF Tl9ET01DVExfQ0RGX2h2bV9ndWVzdCkgKQo+ICsgICAgewo+ICsgICAgICAgIGRwcmludGsoWEVO TE9HX0lORk8sICJQViBzdXBwb3J0IG5vdCBhdmFpbGFibGVcbiIpOwo+ICsgICAgICAgIHJldHVy biAtRUlOVkFMOwo+ICsgICAgfQo+ICsKPiArICAgIGlmICggIWh2bV9lbmFibGVkICYmIChjb25m aWctPmZsYWdzICYgWEVOX0RPTUNUTF9DREZfaHZtX2d1ZXN0KSApCj4gKyAgICB7Cj4gKyAgICAg ICAgZHByaW50ayhYRU5MT0dfSU5GTywgIkhWTSBzdXBwb3J0IG5vdCBhdmFpbGFibGVcbiIpOwo+ ICsgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgfQo+ICsKPiArICAgIGh2bSA9IGNvbmZp Zy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9odm1fZ3Vlc3Q7Cj4gKwo+ICsgICAgaWYgKCAhaHZt ICkKPiArICAgIHsKPiArICAgICAgICBpZiAoIGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NE Rl9oYXAgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywg IkhBUCBpbmFwcGxpY2FibGUgZm9yIFBWIGd1ZXN0c1xuIik7Cj4gKyAgICAgICAgICAgIHJldHVy biAtRUlOVkFMOwo+ICsgICAgICAgIH0KPiArICAgIH0KPiArICAgIGVsc2UKPiArICAgIHsKPiAr ICAgICAgICBpZiAoICFJU19FTkFCTEVEKENPTkZJR19TSEFET1dfUEFHSU5HKSAmJgo+ICsgICAg ICAgICAgICAgIShjb25maWctPmZsYWdzICYgWEVOX0RPTUNUTF9DREZfaGFwKSApCj4gKyAgICAg ICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19JTkZPLCAiU0hBRE9XIHN1cHBvcnQg bm90IGF2YWlsYWJsZVxuIik7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAg ICAgIH0KPiArCj4gKyAgICAgICAgaWYgKCAhaHZtX2hhcF9zdXBwb3J0ZWQoKSAmJiAoY29uZmln LT5mbGFncyAmIFhFTl9ET01DVExfQ0RGX2hhcCkgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAg ICAgZHByaW50ayhYRU5MT0dfSU5GTywgIkhBUCBzdXBwb3J0IG5vdCBhdmFpbGFibGVcbiIpOwo+ ICsgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiArICAgICAgICB9Cj4gKyAgICB9Cj4gKwo+ ICAgICAgIHJldHVybiAwOwo+ICAgfQo+ICAgCj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vZG9t YWluLmMgYi94ZW4vY29tbW9uL2RvbWFpbi5jCj4gaW5kZXggZGRhZjc0YS4uZjY5ZjQwNSAxMDA2 NDQKPiAtLS0gYS94ZW4vY29tbW9uL2RvbWFpbi5jCj4gKysrIGIveGVuL2NvbW1vbi9kb21haW4u Ywo+IEBAIC0zMzksMzcgKzMzOSw5IEBAIHN0cnVjdCBkb21haW4gKmRvbWFpbl9jcmVhdGUoZG9t aWRfdCBkb21pZCwKPiAgICAgICAgICAgaGFyZHdhcmVfZG9tYWluID0gZDsKPiAgICAgICB9Cj4g ICAKPiAtICAgIC8qIFNvcnQgb3V0IG91ciBpZGVhIG9mIGlzX3twdixodm19X2RvbWFpbigpLiAq Lwo+IC0gICAgaWYgKCBjb25maWcgKQo+IC0gICAgewo+IC0gICAgICAgIGlmICggY29uZmlnLT5m bGFncyAmIFhFTl9ET01DVExfQ0RGX2h2bV9ndWVzdCApCj4gLSAgICAgICAgewo+IC0jaWZkZWYg Q09ORklHX0hWTQo+IC0gICAgICAgICAgICBkLT5ndWVzdF90eXBlID0gZ3Vlc3RfdHlwZV9odm07 Cj4gLSNlbHNlCj4gLSAgICAgICAgICAgIGVyciA9IC1FSU5WQUw7Cj4gLSAgICAgICAgICAgIGdv dG8gZmFpbDsKPiAtI2VuZGlmCj4gLSAgICAgICAgfQo+IC0gICAgICAgIGVsc2UKPiAtICAgICAg ICB7Cj4gLSNpZmRlZiBDT05GSUdfUFYKPiAtICAgICAgICAgICAgZC0+Z3Vlc3RfdHlwZSA9IGd1 ZXN0X3R5cGVfcHY7Cj4gLSNlbHNlCj4gLSAgICAgICAgICAgIGVyciA9IC1FSU5WQUw7Cj4gLSAg ICAgICAgICAgIGdvdG8gZmFpbDsKPiAtI2VuZGlmCj4gLSAgICAgICAgfQo+IC0gICAgfQo+IC0g ICAgZWxzZQo+IC0gICAgewo+IC0gICAgICAgIC8qCj4gLSAgICAgICAgICogQXQgbGVhc3QgdGhl IGlkbGUgZG9tYWluIHNob3VsZCBiZSB0cmVhdGVkIGFzIFBWIGRvbWFpbgo+IC0gICAgICAgICAq IGJlY2F1c2UgaXQgdXNlcyBQViBjb250ZXh0IHN3aXRjaCBmdW5jdGlvbnMuIFRvIGVyciBvbiB0 aGUKPiAtICAgICAgICAgKiBzYWZlIHNpZGUsIGxlYXZlIGFsbCBzeXN0ZW0gZG9tYWlucyB0byBi ZSBndWVzdF90eXBlX3B2Lgo+IC0gICAgICAgICAqLwo+IC0gICAgICAgIGQtPmd1ZXN0X3R5cGUg PSBndWVzdF90eXBlX3B2Owo+IC0gICAgfQo+ICsgICAgLyogU29ydCBvdXQgb3VyIGlkZWEgb2Yg aXNfe3B2LGh2bX1fZG9tYWluKCkuICBBbGwgc3lzdGVtIGRvbWFpbnMgYXJlIFBWLiAqLwo+ICsg ICAgZC0+Z3Vlc3RfdHlwZSA9ICgoY29uZmlnICYmIChjb25maWctPmZsYWdzICYgWEVOX0RPTUNU TF9DREZfaHZtX2d1ZXN0KSkKPiArICAgICAgICAgICAgICAgICAgICAgPyBndWVzdF90eXBlX2h2 bSA6IGd1ZXN0X3R5cGVfcHYpOwo+ICAgCj4gICAgICAgVFJBQ0VfMUQoVFJDX0RPTTBfRE9NX0FE RCwgZC0+ZG9tYWluX2lkKTsKPiAgIAo+IAoKLS0gCkp1bGllbiBHcmFsbAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==