All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, lukma@denx.de,
	marex@denx.de,  u-boot@lists.denx.de
Subject: Re: [PATCH v1 4/4] arm: dts: rockchip: remove usb-phy fallback string for rk3188
Date: Thu, 26 May 2022 15:02:06 +0800	[thread overview]
Message-ID: <1f3bdd23-9a4f-37b3-5139-4ca5c31453b8@rock-chips.com> (raw)
In-Reply-To: <20220429214008.26977-4-jbx6244@gmail.com>


On 2022/4/30 05:40, Johan Jonker wrote:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3188
> to prevent possible strange side effects.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3188.dtsi | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/rk3188.dtsi b/arch/arm/dts/rk3188.dtsi
> index 6764776c..9a80f83a 100644
> --- a/arch/arm/dts/rk3188.dtsi
> +++ b/arch/arm/dts/rk3188.dtsi
> @@ -642,8 +642,7 @@
>   	compatible = "rockchip,rk3188-grf", "syscon", "simple-mfd";
>   
>   	usbphy: usbphy {
> -		compatible = "rockchip,rk3188-usb-phy",
> -			     "rockchip,rk3288-usb-phy";
> +		compatible = "rockchip,rk3188-usb-phy";
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   		status = "disabled";

  reply	other threads:[~2022-05-26  7:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 21:40 [PATCH v1 1/4] rockchip: usb: gadget: add rk3066 product id Johan Jonker
2022-04-29 21:40 ` [PATCH v1 2/4] rockchip: usb: phy: add rk3066/rk3188 support Johan Jonker
2022-05-26  7:01   ` Kever Yang
2022-04-29 21:40 ` [PATCH v1 3/4] rockchip: board: change condition board_usb_init() in function Johan Jonker
2022-05-26  7:01   ` Kever Yang
2022-04-29 21:40 ` [PATCH v1 4/4] arm: dts: rockchip: remove usb-phy fallback string for rk3188 Johan Jonker
2022-05-26  7:02   ` Kever Yang [this message]
2022-05-26  7:01 ` [PATCH v1 1/4] rockchip: usb: gadget: add rk3066 product id Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f3bdd23-9a4f-37b3-5139-4ca5c31453b8@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=jbx6244@gmail.com \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.